From: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Singh, Jasvinder" <jasvinder.singh@intel.com>
Subject: Re: [dpdk-dev] [PATCH] ip_pipeline: fix parsing error in TM port section
Date: Tue, 21 Jun 2016 23:28:41 +0000 [thread overview]
Message-ID: <3EB4FA525960D640B5BDFFD6A3D8912647A0B027@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <19575533.UNkKiejxmv@xps13>
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Tuesday, June 21, 2016 9:49 PM
> To: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
> Cc: dev@dpdk.org; Singh, Jasvinder <jasvinder.singh@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] ip_pipeline: fix parsing error in TM port
> section
>
> 2016-06-16 10:04, Jasvinder Singh:
> > Replace APP_PARAM_ADD_LINK_FOR_TXQ with
> APP_PARAM_ADD_LINK_FOR_TM macro
> > in TM (Traffic Manager) port section parsing function. This macro adds
> > nic ports entry specified in TM port section of the application
> > configuration file to the application parameters structure.
> >
> > Fixes: e5a1cd8a4847 ("examples/ip_pipeline: clean up configuration
> parser")
> >
> > Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> > Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
>
> Already fixed in 81d084dd2aa8 ("examples/ip_pipeline: support KNI")
>
> Cristian, you should not ack a patch which do more than announced in
> the title. This pipeline KNI patch do a lot of things without any
> explanation for the fixes.
> 1 explanation = 1 patch
Yeah, there were several small issues to fix and several people spotted them at the same time. I agree we should do a better job at separating different fixes into different patches. Sorry about this.
next prev parent reply other threads:[~2016-06-21 23:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-16 9:04 Jasvinder Singh
2016-06-21 20:49 ` Thomas Monjalon
2016-06-21 23:28 ` Dumitrescu, Cristian [this message]
2016-06-22 9:01 ` Singh, Jasvinder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3EB4FA525960D640B5BDFFD6A3D8912647A0B027@IRSMSX108.ger.corp.intel.com \
--to=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=jasvinder.singh@intel.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).