From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 9919F5A49 for ; Mon, 27 Jun 2016 11:20:53 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP; 27 Jun 2016 02:20:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,536,1459839600"; d="scan'208";a="1010325620" Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by fmsmga002.fm.intel.com with ESMTP; 27 Jun 2016 02:20:51 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.183]) by IRSMSX107.ger.corp.intel.com ([169.254.10.96]) with mapi id 14.03.0248.002; Mon, 27 Jun 2016 10:20:51 +0100 From: "Dumitrescu, Cristian" To: Thomas Monjalon , Panu Matilainen CC: "dev@dpdk.org" , "Singh, Jasvinder" Thread-Topic: [dpdk-dev] [PATCH v2 3/7] pipeline: fix truncated dependency list Thread-Index: AQHRz8nN1FxN2tZaFkCpn8YRx9S9Jp/9CcpA Date: Mon, 27 Jun 2016 09:20:50 +0000 Message-ID: <3EB4FA525960D640B5BDFFD6A3D8912647A0E682@IRSMSX108.ger.corp.intel.com> References: <1466959325-9426-1-git-send-email-thomas.monjalon@6wind.com> <1466959325-9426-4-git-send-email-thomas.monjalon@6wind.com> In-Reply-To: <1466959325-9426-4-git-send-email-thomas.monjalon@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYmZiZWZkNWUtODNmNy00N2IzLTlmNzgtZWVlNDM3ZDYwNDJjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IjhnUDNtOFIxT2JyVk1EdTU1dWNYNEgxYmhKOVwvMUtONFVFOENSYUhRS0JrPSJ9 x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 3/7] pipeline: fix truncated dependency list X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Jun 2016 09:20:54 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Sunday, June 26, 2016 5:42 PM > To: Panu Matilainen > Cc: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v2 3/7] pipeline: fix truncated dependency lis= t >=20 > From: Panu Matilainen >=20 > In other libraries, dependency list is always appended to, but > in commit 6cbf4f75e059 it with an assignment. This causes the > librte_eal dependency added in commit 6cbf4f75e059 to get discarded, > resulting in missing dependency on librte_eal. >=20 Acked-by: Cristian Dumitrescu Hi Thomas, As discussed in some other email thread, it would also make sense to replac= e the ':=3D' operator with '+=3D' operator in Makefile of rte_port and rte_= table as well, do you want us to send a separate patch for this? Thanks, Cristian