From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id A0FD42C60 for ; Wed, 27 Jul 2016 12:08:37 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga104.fm.intel.com with ESMTP; 27 Jul 2016 03:08:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,429,1464678000"; d="scan'208";a="1003400310" Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by orsmga001.jf.intel.com with ESMTP; 27 Jul 2016 03:08:36 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.71]) by IRSMSX103.ger.corp.intel.com ([169.254.3.204]) with mapi id 14.03.0248.002; Wed, 27 Jul 2016 11:08:34 +0100 From: "Dumitrescu, Cristian" To: Thomas Monjalon , Panu Matilainen CC: "Zhang, Roy Fan" , "Singh, Jasvinder" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2] doc: announce ABI change of struct rte_port_source_params and rte_port_sink_params Thread-Index: AQHRsdmQofo/VKT/j0a4IV/tfU/KXaAsdzqQ Date: Wed, 27 Jul 2016 10:08:33 +0000 Message-ID: <3EB4FA525960D640B5BDFFD6A3D8912647A3BBB9@IRSMSX108.ger.corp.intel.com> References: <1463404710-25146-1-git-send-email-roy.fan.zhang@intel.com> <1463667515-11766-1-git-send-email-roy.fan.zhang@intel.com> In-Reply-To: <1463667515-11766-1-git-send-email-roy.fan.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYzI4ZmY0YjQtZmQ4Yy00MDgwLWEzNzMtMDRlMWRhMTBmZjg3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX1BVQkxJQyJ9XX1dfSwiU3ViamVjdExhYmVscyI6W10sIlRNQ1ZlcnNpb24iOiIxNS45LjYuNiIsIlRydXN0ZWRMYWJlbEhhc2giOiI2ak1hTko3RUMrOW1GdHhqZXpEMjZFRFwvU3hsZ0xsdzVQV05kWlIxdG5Ldz0ifQ== x-ctpclassification: CTP_PUBLIC x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] doc: announce ABI change of struct rte_port_source_params and rte_port_sink_params X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Jul 2016 10:08:38 -0000 As Thomas mentioned, today is probably the last day to discuss ABI changes.= This one is pretty small and straightforward, any issues with it? Panu had a concern that the change from "char *" to "const char *" is too s= mall to be regarded as ABI breakage and we should simply go ahead and do it= . My conservative proposal was to put a notice anyway. Nonetheless, what I would like to get from Thomas and Panu is a path forwar= d for this now: a) If we agree to consider this an ABI change, please merge the notice for = 16.7; b) If we agree this is too small for an ABI change, please let us agree now= to accept our quick patch for 16.11 for this change. Thanks, Cristian > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Fan Zhang > Sent: Thursday, May 19, 2016 3:19 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v2] doc: announce ABI change of struct > rte_port_source_params and rte_port_sink_params >=20 > The ABI changes are planned for rte_port_source_params and > rte_port_sink_params, which will be supported from release 16.11. Here > announces that ABI changes in detail. >=20 > Signed-off-by: Fan Zhang > Acked-by: Cristian Dumitrescu > --- > doc/guides/rel_notes/deprecation.rst | 8 ++++++++ > 1 file changed, 8 insertions(+) >=20 > diff --git a/doc/guides/rel_notes/deprecation.rst > b/doc/guides/rel_notes/deprecation.rst > index fffe9c7..4f3fefe 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -74,3 +74,11 @@ Deprecation Notices > a handle, like the way kernel exposes an fd to user for locating a > specific file, and to keep all major structures internally, so that > we are likely to be free from ABI violations in future. > + > +* ABI will change for rte_port_source_params struct. The member > file_name > + data type will be changed from char * to const char *. This change tar= gets > + release 16.11 > + > +* ABI will change for rte_port_sink_params struct. The member file_name > + data type will be changed from char * to const char *. This change tar= gets > + release 16.11 > -- > 2.5.5