From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id B096B2B9A for ; Wed, 12 Oct 2016 22:44:08 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP; 12 Oct 2016 13:44:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,485,1473145200"; d="scan'208";a="19423868" Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66]) by orsmga004.jf.intel.com with ESMTP; 12 Oct 2016 13:44:06 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.164]) by IRSMSX152.ger.corp.intel.com ([169.254.6.13]) with mapi id 14.03.0248.002; Wed, 12 Oct 2016 21:44:06 +0100 From: "Dumitrescu, Cristian" To: Thomas Monjalon , "Singh, Jasvinder" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2 1/3] lib/librte_port: enable file descriptor port support Thread-Index: AQHSBrjy7OpFivKxzkSB1gKv0HAAY6ClcYSAgAARDWA= Date: Wed, 12 Oct 2016 20:44:05 +0000 Message-ID: <3EB4FA525960D640B5BDFFD6A3D8912647A91878@IRSMSX108.ger.corp.intel.com> References: <1470432064-59047-1-git-send-email-jasvinder.singh@intel.com> <1472999921-43283-1-git-send-email-jasvinder.singh@intel.com> <8534270.5teDzHbgep@xps13> In-Reply-To: <8534270.5teDzHbgep@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzZkMWJhOTktMDA1Zi00MTFkLWE3YWItYWEyNDA4OGFhZTJjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IkR2YWFkSWJxWG1RaDU5RFVLdGVRUGpKRFJpWHB6aGpmY1pcLzVjSlRKRHZvPSJ9 x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 1/3] lib/librte_port: enable file descriptor port support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Oct 2016 20:44:09 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Wednesday, October 12, 2016 9:33 PM > To: Singh, Jasvinder > Cc: dev@dpdk.org; Dumitrescu, Cristian > Subject: Re: [dpdk-dev] [PATCH v2 1/3] lib/librte_port: enable file descr= iptor > port support >=20 > 2016-09-04 15:38, Jasvinder Singh: > > +#define RTE_PORT_FD_READER_STATS_PKTS_IN_ADD(port, val) \ > > + do { port->stats.n_pkts_in +=3D val } while (0) > > +#define RTE_PORT_FD_READER_STATS_PKTS_DROP_ADD(port, val) \ > > + do { port->stats.n_pkts_drop +=3D val } while (0) > > + >=20 > It does not compile because of missing ; >=20 > > + * Copyright(c) 2010-2014 Intel Corporation. All rights reserved. >=20 > The years seem outdated. Will fix immediately. >=20 > This patchset was probably not tested as it does not compile. > And it could be useless if a TAP PMD is integrated. > I suggest to wait 17.02 cycle and see. This patch was tested by me and Jasvinder as well and it works brilliantly. We did not enable stats when testing, will sort out the missing semicolon i= ssue in the stats macros and resend v3 asap. This is a trivial issue, no ne= ed to wait for 17.02. This is not conflicting with TAP PMD, and as said the scope of this superse= des the TAP PMD.