From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 5AA86952 for ; Fri, 3 Mar 2017 13:17:19 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Mar 2017 04:17:18 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,237,1484035200"; d="scan'208";a="940207546" Received: from irsmsx109.ger.corp.intel.com ([163.33.3.23]) by orsmga003.jf.intel.com with ESMTP; 03 Mar 2017 04:17:17 -0800 Received: from irsmsx155.ger.corp.intel.com (163.33.192.3) by IRSMSX109.ger.corp.intel.com (163.33.3.23) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 3 Mar 2017 12:17:15 +0000 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.173]) by irsmsx155.ger.corp.intel.com ([169.254.14.204]) with mapi id 14.03.0248.002; Fri, 3 Mar 2017 12:17:15 +0000 From: "Dumitrescu, Cristian" To: "Legacy, Allain (Wind River)" , Yuanhan Liu , "Richardson, Bruce" CC: "dev@dpdk.org" , "Jolliffe, Ian (Wind River)" Thread-Topic: [dpdk-dev] [PATCH 1/5] cfgfile: configurable comment character Thread-Index: AQHSk4tgAm80mLhvyUurDX68XH1fJKGCC6+AgAA+aICAAKeiQIAACoGAgAAHsWCAAARPAIAAAFEQ Date: Fri, 3 Mar 2017 12:17:14 +0000 Message-ID: <3EB4FA525960D640B5BDFFD6A3D891265275825D@IRSMSX108.ger.corp.intel.com> References: <1488482971-170522-1-git-send-email-allain.legacy@windriver.com> <1488482971-170522-2-git-send-email-allain.legacy@windriver.com> <20170302211015.GA18940@bricha3-MOBL3.ger.corp.intel.com> <20170303005337.GB18844@yliu-dev.sh.intel.com> <3EB4FA525960D640B5BDFFD6A3D8912652758102@IRSMSX108.ger.corp.intel.com> <70A7408C6E1BFB41B192A929744D85238A75B22B@ALA-MBC.corp.ad.wrs.com> <3EB4FA525960D640B5BDFFD6A3D8912652758220@IRSMSX108.ger.corp.intel.com> <70A7408C6E1BFB41B192A929744D85238A75B2D3@ALA-MBC.corp.ad.wrs.com> In-Reply-To: <70A7408C6E1BFB41B192A929744D85238A75B2D3@ALA-MBC.corp.ad.wrs.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZGRmZjNiYzUtN2YyOS00YzUwLWJlMGEtMzA4OGNhOTY1NDYyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjIuMTEuMCIsIlRydXN0ZWRMYWJlbEhhc2giOiJxMW42Z3R3Qk5HNnZSMG5wNzk4ekhqcmFXZzk2M1BhcWtUM04zMWxmc05RPSJ9 x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 1/5] cfgfile: configurable comment character X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Mar 2017 12:17:19 -0000 > -----Original Message----- > From: Legacy, Allain [mailto:Allain.Legacy@windriver.com] > Sent: Friday, March 3, 2017 12:14 PM > To: Dumitrescu, Cristian ; Yuanhan Liu > ; Richardson, Bruce > > Cc: dev@dpdk.org; Jolliffe, Ian (Wind River) > Subject: RE: [dpdk-dev] [PATCH 1/5] cfgfile: configurable comment charact= er >=20 >=20 > > -----Original Message----- > > From: Dumitrescu, Cristian [mailto:cristian.dumitrescu@intel.com] > > Both approaches can support this. Therefore, IMO the separator char is > not > > enough to justify approach 1. I would only go for approach 1 if there a= re > > some other parameters that we could consider adding to the load functio= n > > now or later. Do you see any? >=20 > No, I don't have any future parameters in mind but that doesn't mean that > none will arise eventually. IMO, the comment character should be specif= ied > as an actual "char" in the rte_cfgfile_params. Specifying it as a flag i= s a bit > kludgy - I don't like overloading a flag/enum to specify something that > already has a type that can be used (char). Also, I don't think we need= to > control which comment characters are valid. If the app wants to use a 'X= ' > then that's their choice. >=20 >=20 I disagree here. I think we must control the set of allowed separators to a= void confusion.