From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 97C55952 for ; Tue, 7 Mar 2017 11:16:51 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Mar 2017 02:16:50 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,258,1484035200"; d="scan'208";a="1138950247" Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75]) by fmsmga002.fm.intel.com with ESMTP; 07 Mar 2017 02:16:48 -0800 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.173]) by IRSMSX153.ger.corp.intel.com ([169.254.9.160]) with mapi id 14.03.0248.002; Tue, 7 Mar 2017 10:14:21 +0000 From: "Dumitrescu, Cristian" To: Stephen Hemminger , "Wiles, Keith" CC: Thomas Monjalon , DPDK , "jerin.jacob@caviumnetworks.com" , "balasubramanian.manoharan@cavium.com" , "hemant.agrawal@nxp.com" , "shreyansh.jain@nxp.com" , "Richardson, Bruce" Thread-Topic: [dpdk-dev] [PATCH v3 1/2] ethdev: add capability control API Thread-Index: AQHSlmT9/DkS4b/2AkeHpbDSe8ZJ3KGH+A7AgAAQkYCAABafoIAAInaAgAAFj4CAAAOggIAA3ocQ Date: Tue, 7 Mar 2017 10:14:20 +0000 Message-ID: <3EB4FA525960D640B5BDFFD6A3D891265275B5BA@IRSMSX108.ger.corp.intel.com> References: <1488589820-206947-1-git-send-email-cristian.dumitrescu@intel.com> <12629083.yAQ7FffjSn@xps13> <3EB4FA525960D640B5BDFFD6A3D891265275B202@IRSMSX108.ger.corp.intel.com> <10140076.z0k8vql8dv@xps13> <77383876-70CD-4F81-B179-B95ED52933D6@intel.com> <20170306125425.51b6455b@xeon-e3> In-Reply-To: <20170306125425.51b6455b@xeon-e3> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDMwZGQxZjMtNjg5OS00YWY1LWIyMzUtNGQ3ZDgyYjNmMWY0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjIuMTEuMCIsIlRydXN0ZWRMYWJlbEhhc2giOiJvUHRkQWFoeTc2VFZkRFI2MTI1YjBvbmhRSm83NmdTU1FzdGIwMjZNajgwPSJ9 x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 1/2] ethdev: add capability control API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Mar 2017 10:16:52 -0000 > -----Original Message----- > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > Sent: Monday, March 6, 2017 8:54 PM > To: Wiles, Keith > Cc: Thomas Monjalon ; Dumitrescu, Cristian > ; DPDK ; > jerin.jacob@caviumnetworks.com; > balasubramanian.manoharan@cavium.com; hemant.agrawal@nxp.com; > shreyansh.jain@nxp.com; Richardson, Bruce > Subject: Re: [dpdk-dev] [PATCH v3 1/2] ethdev: add capability control API >=20 > On Mon, 6 Mar 2017 20:41:27 +0000 > "Wiles, Keith" wrote: >=20 > > Being able to add features without having to change DPDK maybe a strong > feature for companies that have special needs for its application. They j= ust > need to add a rte_eth_capability enum in a range that they want to contro= l > (which does not mean they need to change the above structure) and they > can provide private features to the application especially if they are ve= ry > specific features to some HW. I do not like private features, but I also = do not > want to stick just any old API in DPDK for any given special feature. >=20 >=20 > I understand why you make that argument, but in practice it doesn't work > that way. > When new features get added to DPDK, then the application must request > those features through configration and other > API's. Therefore building everything into eth_dev doesn't seem to be > helpful. Stephen, I think we are all aligned here. Question is: do you want the appl= ication to discover the supported capabilities through a standard API or do= you want each capability to provide its own specific discovery mechanism (= if any)? This patch proposes a standard API.