From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id ECC9AD23A for ; Fri, 24 Mar 2017 20:10:11 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1490382612; x=1521918612; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=az2u6SEYSvORQBEqlnhsREBc+NKtr5Bx5nBqkc0Qlbc=; b=kS7FweuZPhtO+/gaKRUaf+xUMvScrUx6T4rTWwol6l7KyrrpelMfk1KJ kLi13OC+IrI/TssTvVXepr/oclgkNg==; Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Mar 2017 12:10:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,216,1486454400"; d="scan'208";a="1111869649" Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75]) by orsmga001.jf.intel.com with ESMTP; 24 Mar 2017 12:10:09 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.25]) by IRSMSX153.ger.corp.intel.com ([169.254.9.237]) with mapi id 14.03.0248.002; Fri, 24 Mar 2017 19:10:09 +0000 From: "Dumitrescu, Cristian" To: Shyam Kumar Shrivastav CC: "dev@dpdk.org" Thread-Topic: [PATCH v2] pipeline_firewall: Fix for port range filtering Thread-Index: AQHSomF233pall3lJ0iuzJrNWc/jm6GkX0wQ Date: Fri, 24 Mar 2017 19:10:08 +0000 Message-ID: <3EB4FA525960D640B5BDFFD6A3D891265277302E@IRSMSX108.ger.corp.intel.com> References: <1490146535-5065-1-git-send-email-shrivastav.shyam@gmail.com> In-Reply-To: <1490146535-5065-1-git-send-email-shrivastav.shyam@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOGVjYTYzNmItYWEwOS00YWI2LWEwZjYtYzU3NjFhYzNkM2U2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IlFsTWIyeHFTcG9LSGJqMzYrTW1cL3ZCdWFCSElvMUlmSXR2UzhkalBRMk1jPSJ9 x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] pipeline_firewall: Fix for port range filtering X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Mar 2017 19:10:12 -0000 > -----Original Message----- > From: Shyam Kumar Shrivastav [mailto:shrivastav.shyam@gmail.com] > Sent: Wednesday, March 22, 2017 1:36 AM > To: Dumitrescu, Cristian > Cc: dev@dpdk.org; Shyam Kumar Shrivastav > Subject: [PATCH v2] pipeline_firewall: Fix for port range filtering >=20 > Firewall ACL definition need to use same input index for source and > destination ports as these are 16 bits and would fit in one ACL > field of 32 bits. This is required as per librte_acl API. Without this > UDP/TCP source and destination ports filtering (and for that > matter ICMP type/code filtering) does not work. >=20 > Signed-off-by: Shyam Kumar Shrivastav > --- Reviewed-by: Jasvinder.Singh@intel.com Acked-by: Cristian.Dumitrescu@intel.com Thanks, Shyam, for debugging this!