From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <cristian.dumitrescu@intel.com>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id 00A87FAB8
 for <dev@dpdk.org>; Mon, 27 Mar 2017 12:54:41 +0200 (CEST)
Received: from fmsmga006.fm.intel.com ([10.253.24.20])
 by orsmga105.jf.intel.com with ESMTP; 27 Mar 2017 03:54:40 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.36,231,1486454400"; d="scan'208";a="81372804"
Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153])
 by fmsmga006.fm.intel.com with ESMTP; 27 Mar 2017 03:54:39 -0700
Received: from irsmsx108.ger.corp.intel.com ([169.254.11.239]) by
 IRSMSX101.ger.corp.intel.com ([163.33.3.153]) with mapi id 14.03.0319.002;
 Mon, 27 Mar 2017 11:54:38 +0100
From: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
To: "Legacy, Allain (Wind River)" <allain.legacy@windriver.com>, "Richardson, 
 Bruce" <bruce.richardson@intel.com>
CC: "yuanhan.liu@linux.intel.com" <yuanhan.liu@linux.intel.com>,
 "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [PATCH v2 6/6] cfgfile: add support for empty value string
Thread-Index: AQHSmNa2lkCJrPvZok+KFh8AUjGBdqGonjcg
Date: Mon, 27 Mar 2017 10:54:37 +0000
Message-ID: <3EB4FA525960D640B5BDFFD6A3D891265277BE82@IRSMSX108.ger.corp.intel.com>
References: <1488482971-170522-1-git-send-email-allain.legacy@windriver.com>
 <1489065060-98370-1-git-send-email-allain.legacy@windriver.com>
 <1489065060-98370-7-git-send-email-allain.legacy@windriver.com>
In-Reply-To: <1489065060-98370-7-git-send-email-allain.legacy@windriver.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYzZmYmVjNTMtNTZiOC00MTRkLTk2NTUtZGUzZjY0N2Y3NmVjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6ImJZWFZ6cllTdnJDTUUrdVVhbU5mOGZ3SDJlVis4THA4V3BhdDhRakxnVE09In0=
x-ctpclassification: CTP_IC
x-originating-ip: [163.33.239.182]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v2 6/6] cfgfile: add support for empty value
	string
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 27 Mar 2017 10:54:42 -0000



> -----Original Message-----
> From: Allain Legacy [mailto:allain.legacy@windriver.com]
> Sent: Thursday, March 9, 2017 1:11 PM
> To: Richardson, Bruce <bruce.richardson@intel.com>; Dumitrescu, Cristian
> <cristian.dumitrescu@intel.com>
> Cc: yuanhan.liu@linux.intel.com; dev@dpdk.org
> Subject: [PATCH v2 6/6] cfgfile: add support for empty value string
>=20
> This commit adds support to the cfgfile library for parsing a key=3Dvalue
> line that has no value string specified (e.g., "key=3D").  This can be us=
ed
> to override a configuration attribute that has a default value or default
> list of values to set it back to an undefined value to disable
> functionality.
>=20

IMO allowing empty string key values is confusing and should not be allowed=
.

I think there are better alternatives for setting a key to its default valu=
e:
	key =3D default
	key =3D DEFAULT
	key =3D <the specific default value>

Any reason not to use these approaches?