From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <cristian.dumitrescu@intel.com>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id 42E0EFAC0
 for <dev@dpdk.org>; Mon, 27 Mar 2017 13:24:42 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
 d=intel.com; i=@intel.com; q=dns/txt; s=intel;
 t=1490613883; x=1522149883;
 h=from:to:cc:subject:date:message-id:references:
 in-reply-to:content-transfer-encoding:mime-version;
 bh=9zS++/BpGnM1EgV2EiXng2RWL8yyQM74AvgSJqJsQI8=;
 b=Cd02okUvzR+vaH5F3LCLQNDHunMcmiQ3jM0i027qVFewvRPioZF/u22C
 B5+tV3Qne4Dh3RUkOuCCtyAy9Ff47w==;
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 27 Mar 2017 04:24:42 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.36,231,1486454400"; d="scan'208";a="1147397848"
Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155])
 by fmsmga002.fm.intel.com with ESMTP; 27 Mar 2017 04:24:41 -0700
Received: from irsmsx108.ger.corp.intel.com ([169.254.11.239]) by
 IRSMSX102.ger.corp.intel.com ([169.254.2.153]) with mapi id 14.03.0319.002;
 Mon, 27 Mar 2017 12:24:39 +0100
From: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
To: "Legacy, Allain (Wind River)" <allain.legacy@windriver.com>, "Richardson, 
 Bruce" <bruce.richardson@intel.com>
CC: "yuanhan.liu@linux.intel.com" <yuanhan.liu@linux.intel.com>,
 "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [PATCH v2 6/6] cfgfile: add support for empty value string
Thread-Index: AQHSmNa2lkCJrPvZok+KFh8AUjGBdqGonjcggAAFgVCAAAMnIA==
Date: Mon, 27 Mar 2017 11:24:38 +0000
Message-ID: <3EB4FA525960D640B5BDFFD6A3D891265277CF3A@IRSMSX108.ger.corp.intel.com>
References: <1488482971-170522-1-git-send-email-allain.legacy@windriver.com>
 <1489065060-98370-1-git-send-email-allain.legacy@windriver.com>
 <1489065060-98370-7-git-send-email-allain.legacy@windriver.com>
 <3EB4FA525960D640B5BDFFD6A3D891265277BE82@IRSMSX108.ger.corp.intel.com>
 <70A7408C6E1BFB41B192A929744D8523968F7D70@ALA-MBC.corp.ad.wrs.com>
In-Reply-To: <70A7408C6E1BFB41B192A929744D8523968F7D70@ALA-MBC.corp.ad.wrs.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiM2NkZTNiZjYtMDZiMy00NmM4LWIzOTQtNTU0MmY1NzM1ZDkyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6InE4ems4aERObjY3cVdRb012WnFZSU9SbUtvRFk1MWliZENTcm4wNG9FeEk9In0=
x-ctpclassification: CTP_IC
x-originating-ip: [163.33.239.182]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v2 6/6] cfgfile: add support for empty value
	string
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 27 Mar 2017 11:24:43 -0000



> -----Original Message-----
> From: Legacy, Allain [mailto:Allain.Legacy@windriver.com]
> Sent: Monday, March 27, 2017 12:13 PM
> To: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; Richardson, Bru=
ce
> <bruce.richardson@intel.com>
> Cc: yuanhan.liu@linux.intel.com; dev@dpdk.org
> Subject: RE: [PATCH v2 6/6] cfgfile: add support for empty value string
>=20
> We have a legacy file format that we need to support.   Other parts of ou=
r
> system are able to handle a "key=3D" entry in the file so we are trying t=
o gain
> parity with those parsers.
>=20
> Allain
>=20
>=20
> Allain Legacy, Software Developer
> direct 613.270.2279  fax 613.492.7870 skype allain.legacy
>=20
>=20
>=20

OK, for legacy reasons I am OK to allow this feature, but please let's have=
 the user explicitly ask for it by providing a specific flag for it in the =
flags argument of the load/load_with_params functions.

>=20
> > -----Original Message-----
> > From: Dumitrescu, Cristian [mailto:cristian.dumitrescu@intel.com]
> > Sent: Monday, March 27, 2017 6:55 AM
> > To: Legacy, Allain; RICHARDSON, BRUCE
> > Cc: yuanhan.liu@linux.intel.com; dev@dpdk.org
> > Subject: RE: [PATCH v2 6/6] cfgfile: add support for empty value string
> >
> >
> >
> > > -----Original Message-----
> > > From: Allain Legacy [mailto:allain.legacy@windriver.com]
> > > Sent: Thursday, March 9, 2017 1:11 PM
> > > To: Richardson, Bruce <bruce.richardson@intel.com>; Dumitrescu,
> > > Cristian <cristian.dumitrescu@intel.com>
> > > Cc: yuanhan.liu@linux.intel.com; dev@dpdk.org
> > > Subject: [PATCH v2 6/6] cfgfile: add support for empty value string
> > >
> > > This commit adds support to the cfgfile library for parsing a
> > > key=3Dvalue line that has no value string specified (e.g., "key=3D").
> > > This can be used to override a configuration attribute that has a
> > > default value or default list of values to set it back to an undefine=
d
> > > value to disable functionality.
> > >
> >
> > IMO allowing empty string key values is confusing and should not be
> allowed.
> >
> > I think there are better alternatives for setting a key to its default =
value:
> > 	key =3D default
> > 	key =3D DEFAULT
> > 	key =3D <the specific default value>
> >
> > Any reason not to use these approaches?
>=20