From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <cristian.dumitrescu@intel.com> Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 43FDF2BB9 for <dev@dpdk.org>; Thu, 8 Jun 2017 15:27:51 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Jun 2017 06:27:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,315,1493708400"; d="scan'208";a="1179917879" Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by fmsmga002.fm.intel.com with ESMTP; 08 Jun 2017 06:27:48 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.133]) by IRSMSX103.ger.corp.intel.com ([169.254.3.9]) with mapi id 14.03.0319.002; Thu, 8 Jun 2017 14:27:15 +0100 From: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com> To: Thomas Monjalon <thomas@monjalon.net>, "Singh, Jasvinder" <jasvinder.singh@intel.com> CC: "dev@dpdk.org" <dev@dpdk.org>, "Yigit, Ferruh" <ferruh.yigit@intel.com>, "hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>, "Jerin.JacobKollanukkaran@cavium.com" <Jerin.JacobKollanukkaran@cavium.com>, "Lu, Wenzhuo" <wenzhuo.lu@intel.com> Thread-Topic: [dpdk-dev] [PATCH 0/2] net/softnic: sw fall-back for traffic management Thread-Index: AQHS1kofzek5gL8jNEei9E7E7OP6yqIZeFGAgAGII1A= Date: Thu, 8 Jun 2017 13:27:15 +0000 Message-ID: <3EB4FA525960D640B5BDFFD6A3D891267BA669D7@IRSMSX108.ger.corp.intel.com> References: <20170526181149.44085-1-jasvinder.singh@intel.com> <3485754.OcGeoT3SaN@xps> In-Reply-To: <3485754.OcGeoT3SaN@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYmUyZjI1ZjgtMjFlOC00ODQzLThmYWEtNmFlYjNiZDI1MjBjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6Ikc4SDhOWlhXaHNtNkFtOFAxR0ZZRVU1T3pVWWhWOE1ncEJYYnRIdzUyYVk9In0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 0/2] net/softnic: sw fall-back for traffic management X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Thu, 08 Jun 2017 13:27:52 -0000 Hi Thomas, Thanks for reviewing this patch set! > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Wednesday, June 7, 2017 3:32 PM > To: Singh, Jasvinder <jasvinder.singh@intel.com> > Cc: dev@dpdk.org; Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; > Yigit, Ferruh <ferruh.yigit@intel.com>; hemant.agrawal@nxp.com; > Jerin.JacobKollanukkaran@cavium.com; Lu, Wenzhuo > <wenzhuo.lu@intel.com> > Subject: Re: [dpdk-dev] [PATCH 0/2] net/softnic: sw fall-back for traffic > management >=20 > Hi Jasvinder, >=20 > 26/05/2017 20:11, Jasvinder Singh: > > The SoftNIC PMD provides SW fall-back option for the NICs not supportin= g > > the Traffic Management (TM) features. >=20 > Do you mean that you want to stack PMDs in order to offer some fallbacks? > It means the user needs to instantiate this PMD for each HW which does > not support traffic management, instead of normal hardware probing? >=20 No, the normal HW probing still takes place for the HW device. Then if QoS = "probing" fails, the user can decide to create a new virtual device on top = of the HW device. > > SoftNIC PMD overview: > > - The SW fall-back is based on the existing librte_sched DPDK library. > > - The TM-agnostic port (the underlay device) is wrapped into a TM-aware > > softnic port (the overlay device). > > - Once the overlay device (virtual device) is created, the configuratio= n of > > the underlay device is taking place through the overlay device. > > - The SoftNIC PMD is generic, i.e. it works for any underlay device PMD= that > > implements the ethdev API. >=20 > Why not calling librte_sched directly in ethdev for PMDs which do not > implement hardware offload? > Am I missing something obvious? Yes, we are calling the librte_sched in ethdev, but how else can we do it? - We cannot change the ethdev ops of the HW device PMD because same might = be used by other HW devices in the system where TM feature is not required. - We cannot change the ethdev ops of the current HW device, as on-the-fly = changes of the ops structure are not allowed, right? - We can create a new virtual device on top of existing HW device to inher= it most of the ethdev ops of the HW device and patch some specific ethdev o= ps with librte_sched. IMHO there aren't two different ways to do this. Regards, Cristian