From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <cristian.dumitrescu@intel.com>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
by dpdk.org (Postfix) with ESMTP id BE29B201
for <dev@dpdk.org>; Wed, 26 Jul 2017 17:20:49 +0200 (CEST)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
by orsmga105.jf.intel.com with ESMTP; 26 Jul 2017 08:20:47 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.40,415,1496127600"; d="scan'208";a="1199562584"
Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153])
by fmsmga002.fm.intel.com with ESMTP; 26 Jul 2017 08:20:44 -0700
Received: from irsmsx108.ger.corp.intel.com ([169.254.11.133]) by
IRSMSX101.ger.corp.intel.com ([169.254.1.242]) with mapi id 14.03.0319.002;
Wed, 26 Jul 2017 16:17:43 +0100
From: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
To: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
CC: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
Thread-Topic: [dpdk-dev] [PATCH] net/ixgbe: fix hierarchy commit check
Thread-Index: AQHTBh8Js3/m+5jN+kOCpnzVtOY2bqJmOFaQ
Date: Wed, 26 Jul 2017 15:17:42 +0000
Message-ID: <3EB4FA525960D640B5BDFFD6A3D891267BA8556D@IRSMSX108.ger.corp.intel.com>
References: <1501080853-88038-1-git-send-email-wenzhuo.lu@intel.com>
In-Reply-To: <1501080853-88038-1-git-send-email-wenzhuo.lu@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDk2MzMzOGUtN2U1Zi00ODRmLTg2NmEtZmFmNDlmOWZlNTQ5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IitKSlZjVVJWM2hsMlRXSVpQdk9Pd2tGK1FzTVJsYzUzWUhQQVlxK0FwRVk9In0=
x-ctpclassification: CTP_IC
x-originating-ip: [163.33.239.181]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: fix hierarchy commit check
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 26 Jul 2017 15:20:50 -0000
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wenzhuo Lu
> Sent: Wednesday, July 26, 2017 3:54 PM
> To: dev@dpdk.org
> Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>
> Subject: [dpdk-dev] [PATCH] net/ixgbe: fix hierarchy commit check
>=20
> If there's no Traffic Management node added,
> not necessary to check if TM is committed.
>=20
> Fixes: 5713ade69776 ("net/ixgbe: support committing TM hierarchy")
>=20
> Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
> ---
> drivers/net/ixgbe/ixgbe_ethdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> b/drivers/net/ixgbe/ixgbe_ethdev.c
> index 194058f..e436dca 100644
> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> @@ -2693,7 +2693,7 @@ static int eth_ixgbevf_pci_remove(struct
> rte_pci_device *pci_dev)
> ixgbe_l2_tunnel_conf(dev);
> ixgbe_filter_restore(dev);
>=20
> - if (!tm_conf->committed)
> + if (tm_conf->root && !tm_conf->committed)
> PMD_DRV_LOG(WARNING,
> "please call hierarchy_commit() "
> "before starting the port");
> --
> 1.9.3
Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>