From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 847352C18 for ; Fri, 4 Aug 2017 16:38:48 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Aug 2017 07:38:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,321,1498546800"; d="scan'208";a="115649238" Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75]) by orsmga004.jf.intel.com with ESMTP; 04 Aug 2017 07:38:47 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.133]) by IRSMSX153.ger.corp.intel.com ([169.254.9.74]) with mapi id 14.03.0319.002; Fri, 4 Aug 2017 15:38:46 +0100 From: "Dumitrescu, Cristian" To: Thomas Monjalon , "Horton, Remy" CC: "dev@dpdk.org" , "Mcnamara, John" , "Singh, Jasvinder" , "Nicolau, Radu" , "Hunt, David" Thread-Topic: [PATCH] doc: API change notice for librte_meter Thread-Index: AQHTDS4HQXpfAwzYtUSuf6fvFUIjTKJ0QnZQ Date: Fri, 4 Aug 2017 14:38:45 +0000 Message-ID: <3EB4FA525960D640B5BDFFD6A3D891267BA8A968@IRSMSX108.ger.corp.intel.com> References: <1501852780-191124-1-git-send-email-cristian.dumitrescu@intel.com> <3871111.0JZd9azV8i@xps> In-Reply-To: <3871111.0JZd9azV8i@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] doc: API change notice for librte_meter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2017 14:38:50 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Friday, August 4, 2017 3:29 PM > To: Dumitrescu, Cristian ; Horton, Remy > > Cc: dev@dpdk.org; Mcnamara, John ; Singh, > Jasvinder ; Nicolau, Radu > ; Hunt, David > Subject: Re: [PATCH] doc: API change notice for librte_meter >=20 > 04/08/2017 15:19, Cristian Dumitrescu: > > +* librte_meter: The API will change to accommodate configuration > profiles. > > + Most of the API functions will have an additional opaque parameter. >=20 > Why? > Why opaque parameter? > If you want to use it with a configuration file, you just have to > implement a configuration file in your application. >=20 > Moreover, I already explained my fear of adding this library in DPDK > which is really an application-level statistics lib. >=20 > Without more explanations, my vote is a nack. >=20 > However I remember there was a promise to merge every metrics libs in > one. Thomas, Confusion with librte_metrics, which is a totally different library? This i= s about librte_meter, nothing to do with stats/metrics. This librte_meter is doing traffic metering, essentially the computing the = packet color according to the IETF RFCs 2697 (srTCM =3D Single Rate Three C= olor Marker) and 2698 (trTCM =3D Two Rate Three Color Marker). This is a fu= ndamental block for pretty much every edge router upstream path. You asked me on numerous occasions to be concise, so here is a concise depr= ecation notice. I have to say initially I wrote a more laborious one, then = I remembered your advice and cut it down to this version. Do you need more = details on the motivation? Regards, Cristian