From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id F335A7CD1 for ; Wed, 6 Sep 2017 19:05:56 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga105.jf.intel.com with ESMTP; 06 Sep 2017 10:05:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,354,1500966000"; d="scan'208";a="308676008" Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by fmsmga004.fm.intel.com with ESMTP; 06 Sep 2017 10:05:53 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.167]) by IRSMSX104.ger.corp.intel.com ([163.33.3.159]) with mapi id 14.03.0319.002; Wed, 6 Sep 2017 18:05:52 +0100 From: "Dumitrescu, Cristian" To: Stephen Hemminger , "Pavan Nikhilesh Bhagavatula" CC: Kevin Traynor , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v6 2/3] eal: add u64 bit variant for reciprocal Thread-Index: AQHTJvojEw3JZXBmAkWHaUIlAzpkxaKnuIwAgAAlNQCAAA+OgIAAKV8g Date: Wed, 6 Sep 2017 17:05:52 +0000 Message-ID: <3EB4FA525960D640B5BDFFD6A3D891267BAB4151@IRSMSX108.ger.corp.intel.com> References: <1504693294-2100-1-git-send-email-pbhagavatula@caviumnetworks.com> <1504693294-2100-2-git-send-email-pbhagavatula@caviumnetworks.com> <11668986-444f-4238-147f-4baa82d15285@redhat.com> <20170906144133.GA21468@PBHAGAVATULA-LT> <20170906083715.2084ec8d@xeon-e3> In-Reply-To: <20170906083715.2084ec8d@xeon-e3> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v6 2/3] eal: add u64 bit variant for reciprocal X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Sep 2017 17:05:57 -0000 > -----Original Message----- > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > Sent: Wednesday, September 6, 2017 4:37 PM > To: Pavan Nikhilesh Bhagavatula > Cc: Kevin Traynor ; Dumitrescu, Cristian > ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v6 2/3] eal: add u64 bit variant for recip= rocal >=20 > On Wed, 6 Sep 2017 20:11:34 +0530 > Pavan Nikhilesh Bhagavatula wrote: >=20 > > On Wed, Sep 06, 2017 at 01:28:24PM +0100, Kevin Traynor wrote: > > > On 09/06/2017 11:21 AM, Pavan Nikhilesh wrote: > > > > From: Pavan Bhagavatula > > > > > > > > Currently, rte_reciprocal only supports unsigned 32bit divisors. Th= is > > > > commit adds support for unsigned 64bit divisors. > > > > > > > > Rename unsigned 32bit specific functions appropriately and update > > > > librte_sched accordingly. > > > > > > > > Signed-off-by: Pavan Nikhilesh > > > > --- > > > > lib/librte_eal/bsdapp/eal/rte_eal_version.map | 3 +- > > > > lib/librte_eal/common/include/rte_reciprocal.h | 109 > ++++++++++++++++++++-- > > > > lib/librte_eal/common/rte_reciprocal.c | 116 > +++++++++++++++++++++--- > > > > lib/librte_eal/linuxapp/eal/rte_eal_version.map | 3 +- > > > > lib/librte_sched/Makefile | 4 +- > > > > lib/librte_sched/rte_sched.c | 9 +- > > > > 6 files changed, 219 insertions(+), 25 deletions(-) > > > > > > > > diff --git a/lib/librte_eal/bsdapp/eal/rte_eal_version.map > b/lib/librte_eal/bsdapp/eal/rte_eal_version.map > > > > index 90d7258..59a85bb 100644 > > > > --- a/lib/librte_eal/bsdapp/eal/rte_eal_version.map > > > > +++ b/lib/librte_eal/bsdapp/eal/rte_eal_version.map > > > > @@ -241,6 +241,7 @@ EXPERIMENTAL { > > > > DPDK_17.11 { > > > > global: > > > > > > > > - rte_reciprocal_value; > > > > + rte_reciprocal_value_u32; > > > > + rte_reciprocal_value_u64; > > > > > > > > } DPDK_17.08; > > > > diff --git a/lib/librte_eal/common/include/rte_reciprocal.h > b/lib/librte_eal/common/include/rte_reciprocal.h > > > > index b6d752f..85599e6 100644 > > > > --- a/lib/librte_eal/common/include/rte_reciprocal.h > > > > +++ b/lib/librte_eal/common/include/rte_reciprocal.h > > > > > > Hi Pavan, sorry for commenting late but the license in v1 of this fil= e > > > states it cannot be removed. It is not included in later versions - c= an > > > you explain why? > > > > > Hi Kevin, > > > > I have misinterpreted this mail > > http://dpdk.org/ml/archives/dev/2017-August/073781.html, > > any suggestion on how to proceed on this further? > > > > Thanks, > > Pavan >=20 > License issues need legal advice (TAB could ask LF if required). > Sorry, I am a cynic engineer not a lawyer. >=20 > Easiest solution is to find equivalent code in FreeBSD or some other proj= ect > which does not have the restrictions. How about just adding your copyright on the existing BSD license?