From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id DB7FBDE0; Wed, 20 Sep 2017 14:21:15 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Sep 2017 05:21:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,421,1500966000"; d="scan'208";a="1016570436" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by orsmga003.jf.intel.com with ESMTP; 20 Sep 2017 05:21:11 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.167]) by IRSMSX102.ger.corp.intel.com ([169.254.2.180]) with mapi id 14.03.0319.002; Wed, 20 Sep 2017 13:21:12 +0100 From: "Dumitrescu, Cristian" To: "Singh, Jasvinder" , "Iremonger, Bernard" , "dev@dpdk.org" , "Yigit, Ferruh" , "Ananyev, Konstantin" , "adrien.mazarguil@6wind.com" CC: "Iremonger, Bernard" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v5 1/6] librte_table: fix acl entry add and delete functions Thread-Index: AQHTMJL3YlF1NOLqZUGp5bp7dThq/aK9tF1g Date: Wed, 20 Sep 2017 12:21:11 +0000 Message-ID: <3EB4FA525960D640B5BDFFD6A3D891267BABCE7F@IRSMSX108.ger.corp.intel.com> References: <1504693668-2062-1-git-send-email-bernard.iremonger@intel.com> <1504802598-27296-2-git-send-email-bernard.iremonger@intel.com> <54CBAA185211B4429112C315DA58FF6D33253912@IRSMSX103.ger.corp.intel.com> In-Reply-To: <54CBAA185211B4429112C315DA58FF6D33253912@IRSMSX103.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v5 1/6] librte_table: fix acl entry add and delete functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Sep 2017 12:21:16 -0000 > -----Original Message----- > From: Singh, Jasvinder > Sent: Monday, September 18, 2017 4:30 PM > To: Iremonger, Bernard ; dev@dpdk.org; > Yigit, Ferruh ; Ananyev, Konstantin > ; Dumitrescu, Cristian > ; adrien.mazarguil@6wind.com > Cc: Iremonger, Bernard ; stable@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v5 1/6] librte_table: fix acl entry add an= d > delete functions >=20 > Hi Bernard, >=20 > >=20 > > --- a/lib/librte_table/rte_table_acl.c > > +++ b/lib/librte_table/rte_table_acl.c > > @@ -316,8 +316,7 @@ struct rte_table_acl { > > if (status =3D=3D 0) { > > *key_found =3D 1; > > *entry_ptr =3D &acl->memory[i * acl->entry_size]; > > - memcpy(*entry_ptr, entry, acl->entry_size); > > - > > + memcpy(entry, *entry_ptr, acl->entry_size); > > return 0; > > } > > } >=20 > In this case, table entry which is being added already presents in the ta= ble. > So, first the pointer to that entry from the memory[] that stores the pi= peline > table data(struct rte_pipeline_table_entry) associated with key is retrie= ved > and the changes (action and metadara) are stored in the internal table > pointed by action_table. So, above fix doesn't seem correct. >=20 > > @@ -353,8 +352,8 @@ struct rte_table_acl { > > rte_acl_free(acl->ctx); > > acl->ctx =3D ctx; > > *key_found =3D 0; > > - *entry_ptr =3D &acl->memory[free_pos * acl->entry_size]; > > - memcpy(*entry_ptr, entry, acl->entry_size); > > + *entry_ptr =3D &acl->acl_rule_memory[free_pos * acl->entry_size]; > > + memcpy(entry, *entry_ptr, acl->entry_size); > > > > return 0; > > } > > @@ -435,7 +434,7 @@ struct rte_table_acl { > > acl->ctx =3D ctx; > > *key_found =3D 1; > > if (entry !=3D NULL) > > - memcpy(entry, &acl->memory[pos * acl->entry_size], > > + memcpy(entry, &acl->acl_rule_memory[pos * acl- > > >entry_size], > > acl->entry_size); >=20 >=20 > Above fixes also seems not correct. As per documentation, *entry_ptr is > intended to store the handle to the pipeline table entry containing the d= ata > associated with the current key instead of pointing to memory used to sto= re > the acl rules, etc. Please refer rte_table_acl_create() where memory is > initialized and organized to stores different types of internal tables (p= ointed > by action_table, acl_rule_list and acl_rule_memory). NACK Fully agree with Jasvinder. Existing code is correct, proposed code changes are wrong.