From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 9B33AF94; Wed, 20 Sep 2017 14:24:23 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga105.fm.intel.com with ESMTP; 20 Sep 2017 05:24:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,421,1500966000"; d="scan'208";a="1016571183" Received: from irsmsx109.ger.corp.intel.com ([163.33.3.23]) by orsmga003.jf.intel.com with ESMTP; 20 Sep 2017 05:24:20 -0700 Received: from irsmsx111.ger.corp.intel.com (10.108.20.4) by IRSMSX109.ger.corp.intel.com (163.33.3.23) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 20 Sep 2017 13:24:20 +0100 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.167]) by irsmsx111.ger.corp.intel.com ([169.254.2.30]) with mapi id 14.03.0319.002; Wed, 20 Sep 2017 13:24:20 +0100 From: "Dumitrescu, Cristian" To: "Iremonger, Bernard" , "dev@dpdk.org" , "Yigit, Ferruh" , "Ananyev, Konstantin" , "adrien.mazarguil@6wind.com" CC: "stable@dpdk.org" Thread-Topic: [PATCH v5 2/6] librte_table: fix acl lookup function Thread-Index: AQHTJ/h4O2eoegIyrUCUGxVxFk0SH6K9xmvw Date: Wed, 20 Sep 2017 12:24:20 +0000 Message-ID: <3EB4FA525960D640B5BDFFD6A3D891267BABCEB2@IRSMSX108.ger.corp.intel.com> References: <1504693668-2062-1-git-send-email-bernard.iremonger@intel.com> <1504802598-27296-3-git-send-email-bernard.iremonger@intel.com> In-Reply-To: <1504802598-27296-3-git-send-email-bernard.iremonger@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v5 2/6] librte_table: fix acl lookup function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Sep 2017 12:24:24 -0000 > -----Original Message----- > From: Iremonger, Bernard > Sent: Thursday, September 7, 2017 5:43 PM > To: dev@dpdk.org; Yigit, Ferruh ; Ananyev, > Konstantin ; Dumitrescu, Cristian > ; adrien.mazarguil@6wind.com > Cc: Iremonger, Bernard ; stable@dpdk.org > Subject: [PATCH v5 2/6] librte_table: fix acl lookup function >=20 > The rte_table_acl_lookup() function was returning data from acl_memory > instead of acl_rule_memory. >=20 > Fixes: 166923eb2f78 ("table: ACL") > Cc: stable@dpdk.org >=20 > Signed-off-by: Bernard Iremonger > --- > lib/librte_table/rte_table_acl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/lib/librte_table/rte_table_acl.c b/lib/librte_table/rte_tabl= e_acl.c > index e84b437..258916d 100644 > --- a/lib/librte_table/rte_table_acl.c > +++ b/lib/librte_table/rte_table_acl.c > @@ -794,7 +794,7 @@ struct rte_table_acl { > if (action_table_pos !=3D 0) { > pkts_out_mask |=3D pkt_mask; > entries[pkt_pos] =3D (void *) > - &acl->memory[action_table_pos * > + &acl->acl_rule_memory[action_table_pos * > acl->entry_size]; > rte_prefetch0(entries[pkt_pos]); > } > -- > 1.9.1 NACK Existing code is correct, proposed code changes are wrong (for same reasons= described in patch 1 of this patch set).