From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id EDAD21B281 for ; Fri, 6 Oct 2017 12:02:19 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Oct 2017 03:02:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,482,1500966000"; d="scan'208";a="320270963" Received: from irsmsx154.ger.corp.intel.com ([163.33.192.96]) by fmsmga004.fm.intel.com with ESMTP; 06 Oct 2017 03:02:17 -0700 Received: from irsmsx111.ger.corp.intel.com (10.108.20.4) by IRSMSX154.ger.corp.intel.com (163.33.192.96) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 6 Oct 2017 11:02:16 +0100 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.167]) by irsmsx111.ger.corp.intel.com ([169.254.2.30]) with mapi id 14.03.0319.002; Fri, 6 Oct 2017 11:02:16 +0100 From: "Dumitrescu, Cristian" To: Adrien Mazarguil CC: "dev@dpdk.org" , "thomas@monjalon.net" , "jerin.jacob@caviumnetworks.com" , "hemant.agrawal@nxp.com" Thread-Topic: [PATCH 3/3] rte_flow: add new action for traffic metering and policing Thread-Index: AQHTJyyaREYSZ1ptWEi6bCtLR0sUI6K8eLOw///54oCAGlLogA== Date: Fri, 6 Oct 2017 10:02:16 +0000 Message-ID: <3EB4FA525960D640B5BDFFD6A3D891267BACA97F@IRSMSX108.ger.corp.intel.com> References: <1496162653-137817-3-git-send-email-cristian.dumitrescu@intel.com> <1503705973-80742-1-git-send-email-cristian.dumitrescu@intel.com> <1503705973-80742-4-git-send-email-cristian.dumitrescu@intel.com> <20170906162302.GD4301@6wind.com> <3EB4FA525960D640B5BDFFD6A3D891267BABC13D@IRSMSX108.ger.corp.intel.com> <20170919170051.GP2481@6wind.com> In-Reply-To: <20170919170051.GP2481@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 3/3] rte_flow: add new action for traffic metering and policing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Oct 2017 10:02:20 -0000 Hi Adrien, > -----Original Message----- > From: Adrien Mazarguil [mailto:adrien.mazarguil@6wind.com] > Sent: Tuesday, September 19, 2017 6:01 PM > To: Dumitrescu, Cristian > Cc: dev@dpdk.org; thomas@monjalon.net; > jerin.jacob@caviumnetworks.com; hemant.agrawal@nxp.com > Subject: Re: [PATCH 3/3] rte_flow: add new action for traffic metering an= d > policing >=20 > Hi Cristian, >=20 > On Tue, Sep 19, 2017 at 04:36:50PM +0000, Dumitrescu, Cristian wrote: > > > > > /** > > > > + * RTE_FLOW_ACTION_TYPE_METER > > > > + * > > > > + * Traffic metering and policing (MTR). > > > > + * > > > > + * Packets matched by items of this type can be either dropped or > passed > > > to the > > > > + * next item with their color set by the MTR object. > > > > + * > > > > + * Non-terminating by default. > > > > + */ > > > > +struct rte_flow_action_meter { > > > > + uint32_t mtr_id; /**< MTR object ID created with rte_mtr_create()= . > > > */ > > > > +}; > > > > + > > > > > > Default mask definition is missing. > > > > > > > I do not understand this comment. This is a flow action, not a flow ite= m > (that might be a packet field with an associated mask); this mtr_id is si= milar to > queue ID/index/VF ID from other flow actions, none having any mask > attached. Adrien, can you please clarify? >=20 > Yes, I actually misread it as a pattern item definition for some > reason. Nothing to see here, move along! >=20 No worries. > > > > > > +/** > > > > * Definition of a single action. > > > > * > > > > * A list of actions is terminated by a END action. > > > > -- > > > > 2.7.4 > > > > > > > > > > Even if MTR is a separate API, please add to this commit: > > > > > > - Documentation update: guides/prog_guide/rte_flow.rst > > > - Testpmd update: app/test-pmd/cmdline_flow.c > > > - Testpmd documentation update: > > > doc/guides/testpmd_app_ug/testpmd_funcs.rst > > > > > > You can find examples in previous commits related to rte_flow. > > > > > > > All of these items are a must and will get done, but do they have to be > done in the same patch set? >=20 > That'd be much better as far as I'm involved in this review (rte_flow > changes). You should put them in the same patch as the above. >=20 > > My plan was to introduce test-pmd updates through separate patch sets > after the API is accepted. I know you had these items done in the same pa= tch > set for rte_flow, but there are other APIs such as eventdev and ethdev > traffic management which introduced sample app one release later. >=20 > In that case, could you split these changes in two parts? >=20 > This patch could bring the basic MTR action support in testpmd, by this I > mean the ability to type a flow command with such an action and not get > rejected with a "bad arguments" error since it is actually part of the AP= I, > even if nothing is connected to that action at this point. The rule shoul= d > however get rejected by its lack of support in the underlying PMD. >=20 > Same idea for rte_flow and testpmd documentation update, this patch only > needs the minimum amount describing what this action is without a link to > the actual MTR documentation, which is not present at this point. >=20 > Subsequent commits shall update these as they complete the MTR API. >=20 Full doc and test-pmd have been implemented in V2 just sent earlier, so let= me know if you are OK with V2. > -- > Adrien Mazarguil > 6WIND Thanks, Cristian