Re: [dpdk-dev] [PATCH] examples/ip_pipeline: avoid the failure of creating hash table

["Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>]

> -----Original Message-----
> From: Jianbo Liu [mailto:jianbo.liu@arm.com]
> Sent: Friday, October 27, 2017 3:55 AM
> To: dev@dpdk.org; Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
> Cc: Jianbo Liu <jianbo.liu@arm.com>
> Subject: [PATCH] examples/ip_pipeline: avoid the failure of creating hash
> table
> 
> Hash table function will check if the input bucket size is power of 2,
> so the parameter should be rounded up before sending to the creating
> function.
> 
> Signed-off-by: Jianbo Liu <jianbo.liu@arm.com>
> ---
>  examples/ip_pipeline/pipeline/pipeline_flow_classification_be.c | 2 +-
>  examples/ip_pipeline/pipeline/pipeline_routing_be.c             | 3 ++-
>  2 files changed, 3 insertions(+), 2 deletions(-)
> 

Existing code is simply letting the library detect the misconfiguration and gracefully fail. It avoids duplicating library checks in the app.

Your proposal tries to prevent library from failing by silently tweaking some user configuration params. Easier to debug in some cases.

For this case, I am OK with your proposal, although not really required, so:

Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>