From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 9BA5C1B20D for ; Wed, 3 Jan 2018 17:20:43 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Jan 2018 08:20:42 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,501,1508828400"; d="scan'208";a="7574459" Received: from irsmsx109.ger.corp.intel.com ([163.33.3.23]) by orsmga007.jf.intel.com with ESMTP; 03 Jan 2018 08:20:41 -0800 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.167]) by IRSMSX109.ger.corp.intel.com ([169.254.13.28]) with mapi id 14.03.0319.002; Wed, 3 Jan 2018 16:20:40 +0000 From: "Dumitrescu, Cristian" To: "Dewar, Alan" , "'alangordondewar@gmail.com'" CC: "'dev@dpdk.org'" , 'Alan Dewar' Thread-Topic: [PATCH v4] sched: make RED scaling configurable Thread-Index: AQHTPCkmMC45iwutMkmJVpgYoHqKcqNhViyggAFwGgCAAB0LIA== Date: Wed, 3 Jan 2018 16:20:39 +0000 Message-ID: <3EB4FA525960D640B5BDFFD6A3D891267BAF86FB@IRSMSX108.ger.corp.intel.com> References: <1505913120-5521-1-git-send-email-alan.dewar@att.com> <1507022514-21831-1-git-send-email-alan.dewar@att.com> <3EB4FA525960D640B5BDFFD6A3D891267BAF7F2A@IRSMSX108.ger.corp.intel.com> <3F9268EEC0E43747A5FFFC6B48EF0321FBE645@gbcdcmbx03.intl.att.com> In-Reply-To: <3F9268EEC0E43747A5FFFC6B48EF0321FBE645@gbcdcmbx03.intl.att.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4] sched: make RED scaling configurable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Jan 2018 16:20:44 -0000 > > > +int > > > +rte_red_set_scaling(uint16_t max_red_queue_length); > > > + > > > +/** > > > + * @brief Reset the RED scaling factor - only for use by RED > > > +unit-tests > > > + * > > > + * @return Operation status > > > + */ > > > +void > > > +rte_red_reset_scaling(void); > > > > As stated above, this function is probably not useful and my vote is to > remove it. > > >=20 > It is needed by the revised unit-test program. This function can't be mo= ved > into the unit-test program because it needs to reset variables that are > statically declared within rte_red.c >=20 >=20 Hi Alan, We only put API that makes sense for a real app, not for unit test. About unit tests: Each test in the unit test suite should start from scratc= h, i.e. create a RED object from scratch, configure it, use it, free it rat= her than use RED objects created by previous tests. We need to avoid the la= tter approach, as it is creating fake dependencies between tests that alter= the overall test results. Each test should be independent, and not rely on= previous tests. Makes sense? Regards, Cristian