From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id F2FCDA499 for ; Tue, 8 May 2018 16:30:06 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 May 2018 07:30:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,378,1520924400"; d="scan'208";a="49209341" Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31]) by orsmga003.jf.intel.com with ESMTP; 08 May 2018 07:30:05 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.150]) by IRSMSX106.ger.corp.intel.com ([169.254.8.125]) with mapi id 14.03.0319.002; Tue, 8 May 2018 15:30:04 +0100 From: "Dumitrescu, Cristian" To: "Singh, Jasvinder" , "dev@dpdk.org" Thread-Topic: [PATCH] table: add dedicated params struct for cuckoo hash Thread-Index: AQHT5tdLQUEo8IXyuUu4Q6MeAI6IAaQl5F9g Date: Tue, 8 May 2018 14:30:03 +0000 Message-ID: <3EB4FA525960D640B5BDFFD6A3D891267BB6680A@IRSMSX108.ger.corp.intel.com> References: <20180508141718.18706-1-jasvinder.singh@intel.com> In-Reply-To: <20180508141718.18706-1-jasvinder.singh@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] table: add dedicated params struct for cuckoo hash X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 May 2018 14:30:07 -0000 > -----Original Message----- > From: Singh, Jasvinder > Sent: Tuesday, May 8, 2018 3:17 PM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian > Subject: [PATCH] table: add dedicated params struct for cuckoo hash >=20 > Add dedicated parameter structure for cuckoo hash. The cuckoo hash from > librte_hash uses slightly different prototype for the hash function (no > key_mask parameter, 32-bit seed and return value) that require either > of the following approaches: > 1/ Function pointer conversion: gcc 8.1 warning [1], misleading [2] > 2/ Union within the parameter structure: pollutes a very generic API > parameter structure with some implementation dependent detail > (i.e. key mask not available for one of the available > implementations) > 3/ Using opaque pointer for hash function: same issue from 2/ > 4/ Different parameter structure: avoid issue from 2/; hopefully, > it won't be long before librte_hash implements the key mask feature= , > so the generic API structure could be used. >=20 > [1] http://www.dpdk.org/ml/archives/dev/2018-April/094950.html > [2] http://www.dpdk.org/ml/archives/dev/2018-April/096250.html >=20 > Fixes: 5a80bf0ae613 ("table: add cuckoo hash") >=20 > Signed-off-by: Jasvinder Singh > Acked-by: Cristian Dumitrescu > --- Acked-by: Cristian.Dumitrescu Applied to next-pipeline tree, thanks!