From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 3961F1B430 for ; Thu, 12 Jul 2018 14:03:51 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Jul 2018 05:03:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,342,1526367600"; d="scan'208";a="71760100" Received: from irsmsx108.ger.corp.intel.com ([163.33.3.3]) by fmsmga001.fm.intel.com with ESMTP; 12 Jul 2018 05:03:44 -0700 Received: from irsmsx112.ger.corp.intel.com (10.108.20.5) by IRSMSX108.ger.corp.intel.com (163.33.3.3) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 12 Jul 2018 13:02:18 +0100 Received: from irsmsx107.ger.corp.intel.com ([169.254.10.193]) by irsmsx112.ger.corp.intel.com ([169.254.1.22]) with mapi id 14.03.0319.002; Thu, 12 Jul 2018 13:02:18 +0100 From: "Dumitrescu, Cristian" To: "thomas@monjalon.net" CC: "dev@dpdk.org" , "Singh, Jasvinder" Thread-Topic: [dpdk-dev] [PATCH v4 13/23] net/softnic: add connection agent Thread-Index: AdQZ16QfXkKJKVrNQ7uKQE/4x/S/rw== Date: Thu, 12 Jul 2018 12:02:17 +0000 Message-ID: <3EB4FA525960D640B5BDFFD6A3D891268E772F65@IRSMSX107.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 13/23] net/softnic: add connection agent X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Jul 2018 12:03:51 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Wednesday, July 11, 2018 8:58 PM > To: Singh, Jasvinder > Cc: dev@dpdk.org; Dumitrescu, Cristian > Subject: Re: [dpdk-dev] [PATCH v4 13/23] net/softnic: add connection agen= t >=20 > 05/07/2018 17:47, Jasvinder Singh: > > Add connection agent to enable connectivity with external agen (e.g. > > telnet, netcat, Python script, etc). > > > > Signed-off-by: Cristian Dumitrescu > > Signed-off-by: Jasvinder Singh > > --- > > config/common_base | 2 +- > > config/common_linuxapp | 1 + > > drivers/net/softnic/Makefile | 12 +- > > drivers/net/softnic/conn.c | 332 +++++++++++++= ++++++++ > > drivers/net/softnic/conn.h | 49 +++ > > drivers/net/softnic/rte_eth_softnic.c | 79 ++++- > > drivers/net/softnic/rte_eth_softnic.h | 16 + > > drivers/net/softnic/rte_eth_softnic_internals.h | 3 + > > ...nic_version.map =3D> rte_eth_softnic_version.map} | 6 + > > 9 files changed, 496 insertions(+), 4 deletions(-) create mode > > 100644 drivers/net/softnic/conn.c create mode 100644 > > drivers/net/softnic/conn.h rename > > drivers/net/softnic/{rte_pmd_softnic_version.map =3D> > > rte_eth_softnic_version.map} (52%) >=20 > Why are you renaming this file? >=20 > If you test the compilation with devtools/test-meson-builds.sh you will s= ee this > error: > drivers/meson.build:111:3: ERROR: > File drivers/net/softnic/rte_pmd_softnic_version.map does not exist. >=20 >=20 Fixed. Rebased on DPDK master latest as well. > > +ifneq ($(CONFIG_RTE_EXEC_ENV),"linuxapp") > > +$(info Softnic PMD can only operate in a linuxapp environment, \ >=20 > I think it is a really wrong idea to limit softnic to Linux only. >=20 Main reasons are: use of epoll API, use of TAP ports, etc which are Linux o= nly. At some point we'll consider re-implementing some of the internals wit= h alternatives that are portable to Free BSD as well.