From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 7BEBF2BAF for ; Thu, 16 Aug 2018 10:51:54 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Aug 2018 01:51:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,246,1531810800"; d="scan'208";a="77260040" Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by fmsmga002.fm.intel.com with ESMTP; 16 Aug 2018 01:51:52 -0700 Received: from irsmsx155.ger.corp.intel.com (163.33.192.3) by IRSMSX103.ger.corp.intel.com (163.33.3.157) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 16 Aug 2018 09:51:51 +0100 Received: from irsmsx107.ger.corp.intel.com ([169.254.10.116]) by irsmsx155.ger.corp.intel.com ([169.254.14.243]) with mapi id 14.03.0319.002; Thu, 16 Aug 2018 09:51:51 +0100 From: "Dumitrescu, Cristian" To: "Xu, Rosen" , "dev@dpdk.org" CC: "Lu, Wenzhuo" , "Singh, Jasvinder" , "jerin.jacob@caviumnetworks.com" , "Yigit, Ferruh" Thread-Topic: [PATCH] lib/librte_ethdev: expand queue threshold size of RED parameters Thread-Index: AQHUNP5ztKS3jBkNbUiCh96c29B+0KTCEo5Q Date: Thu, 16 Aug 2018 08:51:50 +0000 Message-ID: <3EB4FA525960D640B5BDFFD6A3D891268E79E2C0@IRSMSX107.ger.corp.intel.com> References: <1534382056-98198-1-git-send-email-rosen.xu@intel.com> In-Reply-To: <1534382056-98198-1-git-send-email-rosen.xu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] lib/librte_ethdev: expand queue threshold size of RED parameters X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Aug 2018 08:51:55 -0000 > -----Original Message----- > From: Xu, Rosen > Sent: Thursday, August 16, 2018 2:14 AM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian ; Lu, Wenzhuo > ; Singh, Jasvinder ; > jerin.jacob@caviumnetworks.com; Xu, Rosen ; Yigit, > Ferruh > Subject: [PATCH] lib/librte_ethdev: expand queue threshold size of RED > parameters >=20 > There's very commonly that more than 4G DDR memory in NIC for HQoS, > so right now the queue threshold size of RED needs to expand to > uint64_t. This patch fixes it. >=20 > Signed-off-by: Rosen Xu > --- > lib/librte_ethdev/rte_tm.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/lib/librte_ethdev/rte_tm.h b/lib/librte_ethdev/rte_tm.h > index 955f02f..646ef38 100644 > --- a/lib/librte_ethdev/rte_tm.h > +++ b/lib/librte_ethdev/rte_tm.h > @@ -831,10 +831,10 @@ enum rte_tm_cman_mode { > */ > struct rte_tm_red_params { > /** Minimum queue threshold */ > - uint32_t min_th; > + uint64_t min_th; >=20 > /** Maximum queue threshold */ > - uint32_t max_th; > + uint64_t max_th; >=20 > /** Inverse of packet marking probability maximum value (maxp), > i.e. > * maxp_inv =3D 1 / maxp > -- > 1.8.3.1 Did you also check that this change does not break any drivers that are cur= rently using the ethdev TM API?