From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 43B91201 for ; Mon, 12 Nov 2018 17:40:19 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Nov 2018 08:40:18 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,495,1534834800"; d="scan'208";a="85245345" Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by fmsmga007.fm.intel.com with ESMTP; 12 Nov 2018 08:40:17 -0800 Received: from irsmsx112.ger.corp.intel.com (10.108.20.5) by IRSMSX104.ger.corp.intel.com (163.33.3.159) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 12 Nov 2018 16:40:16 +0000 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.101]) by irsmsx112.ger.corp.intel.com ([169.254.1.93]) with mapi id 14.03.0415.000; Mon, 12 Nov 2018 16:40:16 +0000 From: "Dumitrescu, Cristian" To: "Zhang, Roy Fan" , "dev@dpdk.org" Thread-Topic: [PATCH] lib/pipeline: fix logically dead code Thread-Index: AQHUdQLna7p67hxFbECPoS0g8WtnbaVMYk6Q Date: Mon, 12 Nov 2018 16:40:15 +0000 Message-ID: <3EB4FA525960D640B5BDFFD6A3D891268E7FBCE9@IRSMSX108.ger.corp.intel.com> References: <20181105122702.33460-1-roy.fan.zhang@intel.com> In-Reply-To: <20181105122702.33460-1-roy.fan.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiODZkYTgwZWMtN2YxOC00OGU4LWIzY2QtMDQ4NGVkOTUyMWU1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUEY5TWNCSENnZDVtNHQzNmFFd2RYVzZYOFJNVHdreGo5elwvMXZkRXFcL0JsV0pqd3hJWWpPTWVpWldxZWpJaDhLIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] lib/pipeline: fix logically dead code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Nov 2018 16:40:20 -0000 > -----Original Message----- > From: Zhang, Roy Fan > Sent: Monday, November 5, 2018 12:27 PM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian > Subject: [PATCH] lib/pipeline: fix logically dead code >=20 > This patches fixes the coverity issue of logically dead code. >=20 > Fixes: 96303217a606 ("pipeline: add symmetric crypto table action") > Coverity issue: 323523 >=20 > Signed-off-by: Fan Zhang > --- > lib/librte_pipeline/rte_table_action.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) >=20 > diff --git a/lib/librte_pipeline/rte_table_action.c > b/lib/librte_pipeline/rte_table_action.c > index 537e6593e..7c7c8dd82 100644 > --- a/lib/librte_pipeline/rte_table_action.c > +++ b/lib/librte_pipeline/rte_table_action.c > @@ -1694,10 +1694,9 @@ get_block_size(const struct > rte_crypto_sym_xform *xform, uint8_t cdev_id) >=20 > rte_cryptodev_info_get(cdev_id, &dev_info); >=20 > - for (i =3D 0;; i++) { > + for (i =3D 0; dev_info.capabilities[i].op !=3D > RTE_CRYPTO_OP_TYPE_UNDEFINED; > + i++) { > cap =3D &dev_info.capabilities[i]; > - if (!cap) > - break; >=20 > if (cap->sym.xform_type !=3D xform->type) > continue; > -- > 2.13.6 Acked-by: Cristian Dumitrescu Applied to next-pipeline tree, thanks!