DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
To: "Singh, Jasvinder" <jasvinder.singh@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Cc: "Peng, Yuan" <yuan.peng@intel.com>
Subject: Re: [dpdk-dev] [PATCH] examples/qos_meter: fix meter color type conversion
Date: Fri, 9 Aug 2019 11:56:52 +0000	[thread overview]
Message-ID: <3EB4FA525960D640B5BDFFD6A3D891268E901EA9@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <20190809093713.25114-1-jasvinder.singh@intel.com>



> -----Original Message-----
> From: Singh, Jasvinder
> Sent: Friday, August 9, 2019 10:37 AM
> To: dev@dpdk.org
> Cc: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; Peng, Yuan
> <yuan.peng@intel.com>
> Subject: [PATCH] examples/qos_meter: fix meter color type conversion
> 
> In APP_MODE_SRTCM_COLOR_AWARE mode, sample app compilation fails
> due to wrong meter color type conversion.
> 
> Fixes: fc8a10d8527a ("examples/qos_meter: add color policy")
> 
> error log-
> /qos_meter/main.c:error: conversion to incomplete type
> (enum rte_meter_color) input_color);
> 
> Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> Reported-by: Peng Yuan <yuan.peng@intel.com>
> ---
>  examples/qos_meter/main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/examples/qos_meter/main.c b/examples/qos_meter/main.c
> index ce1f63dc7..da7afe8be 100644
> --- a/examples/qos_meter/main.c
> +++ b/examples/qos_meter/main.c
> @@ -156,7 +156,7 @@ app_pkt_handle(struct rte_mbuf *pkt, uint64_t time)
>  		&PROFILE,
>  		time,
>  		pkt_len,
> -		(enum rte_meter_color) input_color);
> +		(enum rte_color) input_color);
> 
>  	/* Apply policing and set the output color */
>  	action = policer_table[input_color][output_color];
> --
> 2.21.0

Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>


  reply	other threads:[~2019-08-09 11:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-09  9:37 Jasvinder Singh
2019-08-09 11:56 ` Dumitrescu, Cristian [this message]
2019-08-10 22:08   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3EB4FA525960D640B5BDFFD6A3D891268E901EA9@IRSMSX108.ger.corp.intel.com \
    --to=cristian.dumitrescu@intel.com \
    --cc=dev@dpdk.org \
    --cc=jasvinder.singh@intel.com \
    --cc=yuan.peng@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).