From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EA6E6A2E8C for ; Thu, 5 Sep 2019 17:01:10 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2C9A41BF12; Thu, 5 Sep 2019 17:01:09 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 6BF291BEDB; Thu, 5 Sep 2019 17:01:07 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga105.fm.intel.com with ESMTP; 05 Sep 2019 08:01:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,470,1559545200"; d="scan'208";a="190519758" Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by FMSMGA003.fm.intel.com with ESMTP; 05 Sep 2019 08:01:05 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.50]) by IRSMSX101.ger.corp.intel.com ([169.254.1.129]) with mapi id 14.03.0439.000; Thu, 5 Sep 2019 16:01:05 +0100 From: "Dumitrescu, Cristian" To: "Yigit, Ferruh" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH 09/10] app/test-pipeline: fix global variable multiple definitions Thread-Index: AQHVY/m1FrXk+/yvBUy3+P6brZtXdacdLRpA Date: Thu, 5 Sep 2019 15:01:04 +0000 Message-ID: <3EB4FA525960D640B5BDFFD6A3D891268E9198B9@IRSMSX108.ger.corp.intel.com> References: <20190905145315.19395-1-ferruh.yigit@intel.com> <20190905145315.19395-10-ferruh.yigit@intel.com> In-Reply-To: <20190905145315.19395-10-ferruh.yigit@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzcwMDUyNjMtZjcyYy00NDQ3LThjZjctYWNkNjBiMWJlNGJkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiNm1YRGJOMEpSVkllVGJoNWVTRk5pS1Ircm9aOTBvWmZCNEt5V1NHS0hcL0hndk5wc29iUFBLMGRIZ1J1VVMrOUYifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 09/10] app/test-pipeline: fix global variable multiple definitions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Yigit, Ferruh > Sent: Thursday, September 5, 2019 3:53 PM > To: Dumitrescu, Cristian > Cc: dev@dpdk.org; stable@dpdk.org > Subject: [PATCH 09/10] app/test-pipeline: fix global variable multiple > definitions >=20 > 'app' global variable is defined in multiple .c files, fixed it by > marking one copy as 'extern' >=20 > Issue has been detected by '-fno-common' gcc flag. >=20 > Fixes: 48f31ca50cc4 ("app/pipeline: packet framework benchmark") > Cc: stable@dpdk.org >=20 > Signed-off-by: Ferruh Yigit > --- > app/test-pipeline/config.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/app/test-pipeline/config.c b/app/test-pipeline/config.c > index 28ac9fcc0..42c6ed9b2 100644 > --- a/app/test-pipeline/config.c > +++ b/app/test-pipeline/config.c > @@ -42,7 +42,7 @@ >=20 > #include "main.h" >=20 > -struct app_params app; > +extern struct app_params app; >=20 > static const char usage[] =3D "\n"; >=20 > -- > 2.21.0 The global variable "app" is already declared as extern in the main.h file,= which is included into config.c file, so please remove this "app" definiti= on in config.c altogether. Thanks, Cristian