* [dpdk-dev] [PATCH v2] port: fix library build order dependency
@ 2019-11-06 14:43 Rahul Shah
2019-11-07 15:22 ` Dumitrescu, Cristian
0 siblings, 1 reply; 3+ messages in thread
From: Rahul Shah @ 2019-11-06 14:43 UTC (permalink / raw)
To: cristian.dumitrescu; +Cc: dev
The port library should be build after eventdev library.
Fixes: 5d92c4e5 ("port: add eventdev port type")
Signed-off-by: Rahul Shah <rahul.r.shah@intel.com>
---
lib/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/Makefile b/lib/Makefile
index 5d04ab915..1ff00ba8c 100644
--- a/lib/Makefile
+++ b/lib/Makefile
@@ -89,7 +89,7 @@ DIRS-$(CONFIG_RTE_LIBRTE_DISTRIBUTOR) += librte_distributor
DEPDIRS-librte_distributor := librte_eal librte_mbuf librte_ethdev
DIRS-$(CONFIG_RTE_LIBRTE_PORT) += librte_port
DEPDIRS-librte_port := librte_eal librte_mempool librte_mbuf librte_ethdev
-DEPDIRS-librte_port += librte_ip_frag librte_sched
+DEPDIRS-librte_port += librte_ip_frag librte_sched librte_eventdev
ifeq ($(CONFIG_RTE_LIBRTE_KNI),y)
DEPDIRS-librte_port += librte_kni
endif
--
2.20.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH v2] port: fix library build order dependency
2019-11-06 14:43 [dpdk-dev] [PATCH v2] port: fix library build order dependency Rahul Shah
@ 2019-11-07 15:22 ` Dumitrescu, Cristian
2019-11-07 16:44 ` David Marchand
0 siblings, 1 reply; 3+ messages in thread
From: Dumitrescu, Cristian @ 2019-11-07 15:22 UTC (permalink / raw)
To: Shah, Rahul R; +Cc: dev
> -----Original Message-----
> From: Shah, Rahul R <rahul.r.shah@intel.com>
> Sent: Wednesday, November 6, 2019 2:43 PM
> To: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
> Cc: dev@dpdk.org
> Subject: [PATCH v2] port: fix library build order dependency
>
> The port library should be build after eventdev library.
>
> Fixes: 5d92c4e5 ("port: add eventdev port type")
>
> Signed-off-by: Rahul Shah <rahul.r.shah@intel.com>
> ---
> lib/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/Makefile b/lib/Makefile
> index 5d04ab915..1ff00ba8c 100644
> --- a/lib/Makefile
> +++ b/lib/Makefile
> @@ -89,7 +89,7 @@ DIRS-$(CONFIG_RTE_LIBRTE_DISTRIBUTOR) +=
> librte_distributor
> DEPDIRS-librte_distributor := librte_eal librte_mbuf librte_ethdev
> DIRS-$(CONFIG_RTE_LIBRTE_PORT) += librte_port
> DEPDIRS-librte_port := librte_eal librte_mempool librte_mbuf librte_ethdev
> -DEPDIRS-librte_port += librte_ip_frag librte_sched
> +DEPDIRS-librte_port += librte_ip_frag librte_sched librte_eventdev
> ifeq ($(CONFIG_RTE_LIBRTE_KNI),y)
> DEPDIRS-librte_port += librte_kni
> endif
> --
> 2.20.1
Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH v2] port: fix library build order dependency
2019-11-07 15:22 ` Dumitrescu, Cristian
@ 2019-11-07 16:44 ` David Marchand
0 siblings, 0 replies; 3+ messages in thread
From: David Marchand @ 2019-11-07 16:44 UTC (permalink / raw)
To: Shah, Rahul R; +Cc: dev, Dumitrescu, Cristian, Yigit, Ferruh
On Thu, Nov 7, 2019 at 4:23 PM Dumitrescu, Cristian
<cristian.dumitrescu@intel.com> wrote:
> > -----Original Message-----
> > From: Shah, Rahul R <rahul.r.shah@intel.com>
> > Sent: Wednesday, November 6, 2019 2:43 PM
> > To: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
> > Cc: dev@dpdk.org
> > Subject: [PATCH v2] port: fix library build order dependency
> >
> > The port library should be build after eventdev library.
built*
> >
> > Fixes: 5d92c4e5 ("port: add eventdev port type")
Fixes: 5d92c4e592c4 ("port: add eventdev port type")
Cc: stable@dpdk.org
> >
> > Signed-off-by: Rahul Shah <rahul.r.shah@intel.com>
Tested-by: Ferruh Yigit <ferruh.yigit@intel.com>
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Applied, thanks.
--
David Marchand
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-11-07 16:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-06 14:43 [dpdk-dev] [PATCH v2] port: fix library build order dependency Rahul Shah
2019-11-07 15:22 ` Dumitrescu, Cristian
2019-11-07 16:44 ` David Marchand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).