From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30078.outbound.protection.outlook.com [40.107.3.78]) by dpdk.org (Postfix) with ESMTP id 49AA11E34; Wed, 27 Feb 2019 03:56:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LazNgVk4NiiKKC0LaC8FNXGBcIJztppnA9RqxJKvdGU=; b=nYszMJGmSUgC7zqlN95P7/yz10RwDJr/cLd+X4cMLwTMb0oqFX+xSgglpeGSmJtrushJ+5INf+GOSMJyrZYhdUHMC+rYMAzAbjvlxv+yV3ysOq87qQ7XxjgGCtAo2oov9Sb4NTjWaQVkPDJGFVL3unqOaP5DPjsb/D1Xqu23COY= Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com (52.134.72.27) by DB3PR0502MB4058.eurprd05.prod.outlook.com (52.134.68.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1643.14; Wed, 27 Feb 2019 02:56:33 +0000 Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::580c:ae7b:8278:cc50]) by DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::580c:ae7b:8278:cc50%3]) with mapi id 15.20.1665.015; Wed, 27 Feb 2019 02:56:33 +0000 From: Yongseok Koh To: Dekel Peled CC: Matan Azrad , Shahaf Shuler , dev , Ori Kam , "stable@dpdk.org" Thread-Topic: [PATCH v2] net/mlx4: fix default flow rule create Thread-Index: AQHUzCXzyWXW5pDTuUWt2mcnjy0qLqXy98oA Date: Wed, 27 Feb 2019 02:56:33 +0000 Message-ID: <3FDA1FB6-5EED-46BC-8571-E810964CE8FB@mellanox.com> References: <1550995648-60249-1-git-send-email-dekelp@mellanox.com> <1551001269-62890-1-git-send-email-dekelp@mellanox.com> In-Reply-To: <1551001269-62890-1-git-send-email-dekelp@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-originating-ip: [209.116.155.178] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5f0fb388-c190-4e21-30aa-08d69c5f2e79 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(4618075)(2017052603328)(7153060)(7193020); SRVR:DB3PR0502MB4058; x-ms-traffictypediagnostic: DB3PR0502MB4058: x-microsoft-exchange-diagnostics: =?us-ascii?Q?1; DB3PR0502MB4058; 23:Lvqih9prJppQeq2tfDiWGdrvmh7d7PsjK1VzWw8?= =?us-ascii?Q?WtuEeaJ+mf8B+5SPz6EQ0mG/Wol7KU9HR+mRpeKPf11tnmUO0LiKJnnC0SZ+?= =?us-ascii?Q?VXIr/F8lGvydkfioXQLBe8zerWuZmXnJ8JAXeln9QaogKPkoCHVcRStWbyU7?= =?us-ascii?Q?zAAippQgmwivKkzaZjdDEnMQT2BnNwgZEA25WQ69y83Tu25oqcs/QSYHnMtE?= =?us-ascii?Q?bWNTmL61wkSWQt3iZcQ8/cfrTyTe/802d+/dBB8iuSAE8aS4YdmNSJaZk9zQ?= =?us-ascii?Q?pYokHs+0SD5TkFIrlSO3tTespoSEJcc9s7ZdhhaHjhqqPJW35ZAR4IHwUICW?= =?us-ascii?Q?YJD7ZuV2qUpmZSQ+dalffZcaETyoBAfK6d7ja8COyiOv3F4hrY2bGjdB1ayd?= =?us-ascii?Q?oGwdgURQ6qc7lfoEx7MWmG3VcPuYuAo80vhACbtO3kzSJQXwHpjvbU4xN/mT?= =?us-ascii?Q?Ejt4F1Z7iLsVBhE9OJYKbzh1gFjakUTLWEqghXlUwxiRxYW2LjX3UmrRmWUV?= =?us-ascii?Q?U3wBlP+MBN6latk3fY9A4T3QVVvqi/KRCexWzJ4GPOrXGphfMYZ7H1jvRSE1?= =?us-ascii?Q?IshFoet6B//mW7pIblr1DfGXmltEAozStbsJExpKh/mQQD279sh2Eba2BsIL?= =?us-ascii?Q?M3EneAxPGYiboBXgTsT4qiQMBUqozhTOBaEm/2mSLnkmBjLdqPNHxF08IwxH?= =?us-ascii?Q?DaWa3DSK7na6Uhxpv4H8G1QNJWYjxYfua9atwQbBsk37RDTqTzCTNgcb9foa?= =?us-ascii?Q?updE8dIltIthbS8F80HjWiC+pOtYxY27HH5+Pq62H/JS0LnaBk+qRQbmBzt6?= =?us-ascii?Q?6MBSBiYZshu4tet8EgmEPEPAoFPQiB6kd4INzuHA3mre3107kT1ZGN962wHf?= =?us-ascii?Q?U/4cafpTs69FZlDQfxo+RTA9Y0MbH7rrbHjrvvc2VJFsBljT36YB6dfe1Chb?= =?us-ascii?Q?Gssc28LHYxjP72ySBub8IdjsBl88PsEmcIlPA+Co/jMC2u4GApHVchFlEJUx?= =?us-ascii?Q?x9fa1XWbsJkzuO7lbz/4K59D7MyWbS7G6UCWRfvMNbZnPxpzUGXsqj4zBNeO?= =?us-ascii?Q?42Ogpvle3cW7DZl8J5Mx0uz1vWs9eBMiCunCoBqOn2417rH9MF/ACuFqek56?= =?us-ascii?Q?7TSckyfAKZEyQHh7eVm1zJzU51lJMoY9WmkwuqIqTztt/H/MQsGU+ri68etp?= =?us-ascii?Q?jdARrClSngqMYWTiGGJALPNnWqA7Nu55YzNZwqJKQUK9uY8ZzbbbKNgpzgDQ?= =?us-ascii?Q?sCtnG+t0DCRf0d8Wk8FaeG/hXAoNXrz29fqdHa8gFLqeYvScah/3tJH01yHx?= =?us-ascii?Q?yHbdOtbzFMzkBrZDO0hs+XqRPmM+b1A3ZmRaJYZbR8GeXRFfFAXSZvGVuYib?= =?us-ascii?Q?kbNC2Tw=3D=3D?= x-microsoft-antispam-prvs: x-forefront-prvs: 0961DF5286 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(346002)(136003)(396003)(366004)(39860400002)(189003)(199004)(102836004)(4326008)(450100002)(66066001)(14454004)(53546011)(6506007)(476003)(478600001)(26005)(11346002)(2616005)(446003)(486006)(25786009)(8936002)(81156014)(8676002)(81166006)(76176011)(68736007)(6246003)(33656002)(186003)(99286004)(305945005)(4744005)(7736002)(106356001)(6862004)(97736004)(36756003)(37006003)(82746002)(6116002)(54906003)(3846002)(2906002)(316002)(105586002)(71200400001)(229853002)(86362001)(5660300002)(6512007)(6486002)(83716004)(6636002)(256004)(53936002)(14444005)(6436002)(71190400001); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB4058; H:DB3PR0502MB3980.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: SH9uyeGhjrN/dphb+G+1diJblKz1MQ/g9CJ+YMaZu5BmyEt2yiI7oOE2lrUNvEz6xu1t08F0cDEX/RtEwIlG0UrNUa02qf3nZRgK3kc/eg4c2pTX9rz3IpN/gmPDNFDNPlQEGqe5z2Su3EPZ7mSXCb4YZk4cSdjGOnwheVnDb3Rs07sfOcSvtcynM7kDumj5OOP6bHUVVsZDYH9+R9ALTmcI6POG8yF/y73SUv1x7EBTJeAvaOXdWrLaey6GShVtp3/HTxnPylvQnc2bpPH5gVd1pPi8uW0QE6DOwSChXcbhzDvbtHmf+MDbe69yNC/SomwJJI41uGNWcFYjNiU+iNNQquEYaQ6MQQP7nOaYZIFscyuYQLakv7HCLK89NExeugLECeIMJPu586JS49CXCSuYP/WHDtzT4cIazx+l38U= Content-Type: text/plain; charset="us-ascii" Content-ID: <04324E2C20953C40A146ACF4127D5A93@eurprd05.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5f0fb388-c190-4e21-30aa-08d69c5f2e79 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Feb 2019 02:56:33.1512 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB4058 Subject: Re: [dpdk-dev] [PATCH v2] net/mlx4: fix default flow rule create X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Feb 2019 02:56:37 -0000 > On Feb 24, 2019, at 1:41 AM, Dekel Peled wrote: >=20 > Original patch changed logic of function mlx4_flow_merge_eth(). > The setting of flow->promisc was wrongly removed. > This patch adds the removed setting of flow->promisc, to restore > the required behavior. >=20 > Fixes: c0d239263156 ("net/mlx4: support flow w/o ETH spec and with VLAN") > Cc: stable@dpdk.org >=20 > --- > v2: Correct typo in 'stable' email address. > --- >=20 > Signed-off-by: Dekel Peled > --- Acked-by: Yongseok Koh =20 Thanks > drivers/net/mlx4/mlx4_flow.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/drivers/net/mlx4/mlx4_flow.c b/drivers/net/mlx4/mlx4_flow.c > index 3abde30..b7af324 100644 > --- a/drivers/net/mlx4/mlx4_flow.c > +++ b/drivers/net/mlx4/mlx4_flow.c > @@ -250,6 +250,7 @@ struct mlx4_drop { > if (!mask) { > eth->val.dst_mac[0] =3D 0xff; > flow->ibv_attr->type =3D IBV_FLOW_ATTR_ALL_DEFAULT; > + flow->promisc =3D 1; > return 0; > } > memcpy(eth->val.dst_mac, spec->dst.addr_bytes, ETHER_ADDR_LEN); > --=20 > 1.8.3.1 >=20