From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 91B2A45C4F; Sat, 2 Nov 2024 01:56:17 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7CB99402B7; Sat, 2 Nov 2024 01:56:17 +0100 (CET) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2045.outbound.protection.outlook.com [40.107.223.45]) by mails.dpdk.org (Postfix) with ESMTP id 260544029A for ; Sat, 2 Nov 2024 01:56:16 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=VFitkgOVjKzDuqJtpzlqstzxI54Xjp5ytjrYTbxTYaARozPZr62h7uH1lpvpJFpUGYrxLcEMMzFDLeTuuF1lxyTD94LEK8D8sGEDHCHA2S0/2TvjasrDNp6DolZUwCwYdiWqzKvLtJ7M+ohA0uApI6pdHDsB6oC2N91jMJ3IJj1/tke75Aib1QpH1UTM3ZP3sduNfzBSObauZmUpLQXUtNkr8CMGkXZep7+pU09IwbEEspGwnrVZ79EZeOTO2Qg3gYYHyqUg3WdyYAxpg5nSf1QqfVJCjDS2bIKXUOnFUwOGiKa036CcDmh7Pe8yz1ls8aXuQiNpckeisJNH0I7kIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fkHjssWwBPKn8Zkt9jCm1zDDhET/C466KDtQ8u/tLNI=; b=hC0+bDFtb2WTtLeBRaXqD8JUIaBG3jPw1sN6PpUCDnmk2Bu2WQajhAnoUIbUFiHc0GfvplPqHIHB7WnO1cCrNyuhfsPDyUsbOxBJozp3GgTaRG92jqwrbxYnfe/NsIyNqj3lGr7GRGeYaBxoT3JTochbGJjr/j7nEDcsSUUJebjZ+08qKIF53BvSmenpQL1x+uVntrSKB9LSEBkIPcKhKmziGw9YOZYiQZASMCoQNGzTKQPRhDtuIidSrfmZbinRldFkeJu7DG08A6cyeresuzrrGHrahbJZz16okJ/hGRS0zTsOrM/RqFHjDmy1HipTLWQIjex8T2r652o5/QJKFQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fkHjssWwBPKn8Zkt9jCm1zDDhET/C466KDtQ8u/tLNI=; b=dz7yAJ5u+B23f3N6rlhMNliVZWARUpOQrZfkuOlK5/D3t4N3iJB0/rgkO4xDa49sG08REsnCsM4szIRChI47NlOYxCVCfqQRaL8GEefTmn712HKE5FjtcLf+Qe77eq2rda4/OSo1vT4dQyzcspy2HiwqnxoCPr9pnRlL0tr83Ns= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from SJ2PR12MB8830.namprd12.prod.outlook.com (2603:10b6:a03:4d0::9) by SA1PR12MB8920.namprd12.prod.outlook.com (2603:10b6:806:38e::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8114.23; Sat, 2 Nov 2024 00:56:13 +0000 Received: from SJ2PR12MB8830.namprd12.prod.outlook.com ([fe80::c3eb:df02:eaa9:2055]) by SJ2PR12MB8830.namprd12.prod.outlook.com ([fe80::c3eb:df02:eaa9:2055%4]) with mapi id 15.20.8114.015; Sat, 2 Nov 2024 00:56:13 +0000 Message-ID: <3a0e933d-f9f3-4450-a8d1-41b9b067a07e@amd.com> Date: Sat, 2 Nov 2024 00:56:07 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9 0/9] net/zxdh: introduce net zxdh driver To: Junlong Wang , dev@dpdk.org Cc: wang.yong19@zte.com.cn References: <20241030090124.2540776-2-wang.junlong1@zte.com.cn> <20241101062156.2637339-1-wang.junlong1@zte.com.cn> Content-Language: en-US From: Ferruh Yigit In-Reply-To: <20241101062156.2637339-1-wang.junlong1@zte.com.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P265CA0067.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2af::17) To SJ2PR12MB8830.namprd12.prod.outlook.com (2603:10b6:a03:4d0::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ2PR12MB8830:EE_|SA1PR12MB8920:EE_ X-MS-Office365-Filtering-Correlation-Id: 5f34bb7c-dab2-4600-b920-08dcfad925f7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?ZFpTYmxuRHo3Ui9NdmU3b2RSVGVQZllWRG9UMUhpOFBtT0QvYldKUTdkZWhH?= =?utf-8?B?b2Ntb3RjaWtXUkZ3d09Ha2V2ZFpkZEZ6cjl0aS9tVCtON0gxbFFvc3VtVFk0?= =?utf-8?B?eFVucGwzNExqMm5paExFQkNuNnp4bWtHdWVseXNxcFYvYnZvMy9MeGJrMzlM?= =?utf-8?B?RVlOSzdtNldXQ0R2M1B4eUplK1lvVGVhNk1UTzExR1hBYTJqN2t3TW84MHJ5?= =?utf-8?B?UGpuZ1NNRlpyOHoyQ2xvV1NzVnhmcDhDRFY0UnNVd2lKQlR0WDZ0OTV1TFNy?= =?utf-8?B?ZWNsVUdYbnVpU1psRElnQ0dFUUlGYkZyL1lUSWlBaU1QVmlLWjlRNzRhTkVo?= =?utf-8?B?dkxuS09sZVF4bXZDRURSbzhsdWE4Z2JJeTFZbHF1U1JmejJWQnc0Mlk0Zlg1?= =?utf-8?B?ZzlxUWNrWkxxcU5OTDhRbzFDc1Bwa2FOQlgxYkNtck9sanRUMHpqZWU2V3p3?= =?utf-8?B?cUt1bksrVTJzSjF2ak5JQXVXRnQ0eWlZa1JHbEdIS3FWaE5pUW9lNmxQQXN1?= =?utf-8?B?T25lQU82L1F6MkRtVlFFV1lqeW9PRWRmSmRmTnF5UE9pY2FvaHVrQmdDS1Nv?= =?utf-8?B?bnp2aW1RSGd2bWZIZHo0YS9ISTk3c1Fqa0pEb2xEVkoxa3RlV0VxcEJlazBO?= =?utf-8?B?NUpJRVhMSURFcURZUFhpcjF6S1NEeE9hdzVHS28zSkJjKy9lY2VCWHAyUFhl?= =?utf-8?B?Y3h0OTBOS25WOWo0VE83MUxtdUZUNWRnNkVUdnVqMEM0NEpvckxKcWtGMjJN?= =?utf-8?B?NEpBbXRmVmRYU2RGRkZ4TERPZkwzUkFUT1Y1WDRad0l5UDF2d2tlR3c2WFZK?= =?utf-8?B?c0FrNHR6b3lqejN2S3F0MFgwRUxTb2daRTRPMjlvaWVONzVWMy8vbWd0bmdW?= =?utf-8?B?Z09iR3RpUHBlcXpDUUVRT1h5QnpzeDdrcXVOb1EyMTN3VWN2TW5uMnhDYTdZ?= =?utf-8?B?NzZ5alE4V3g5UWlZc2grUDQyRHBSdkxXMjN3b29xdVlZTTREamIxWTQ3eGtW?= =?utf-8?B?MXQyNjNab2ZFeVBWMHRYTFRnMXR3cTA3NHdsZkIxV1FlcXJTaEFJVWIzQTQ5?= =?utf-8?B?SmhpVEV0Sjd1TGpoTVVEeDRBY1lWajJIdXRLazZIZllUZHdmL0FGOXZ5OFR6?= =?utf-8?B?Y25wcVE4Y0Q0Vmo2TkVvZ2Y3ZDVZV1VMOFVnT08xUWZFNExHT2xJUEJLQUlP?= =?utf-8?B?VWhuVUlaWTdPc0F1OWZTZkw0Z0xxMVVTT3c5MlE3NlNkNWdyTzhTcmpTWGg0?= =?utf-8?B?amdGS2VEM1FDVXlNZlNzdDlHbEJvMHRFdnBGSE0xdU1kSEZBeUs0c1dhMXZr?= =?utf-8?B?WlZueXpjWFhXeUpJaVZvMitvOWhDQnQzdWZSM2tDZEJjSDk4aTNrclYyVWFk?= =?utf-8?B?QitRR3RHNlRzMVBVcDRUZlZOZXh5ZkxGd09YclJjN1lBSitVbURnbkNQUE1D?= =?utf-8?B?ZW8vUEhVbTNzYWJqeUpnemRKZW1jcEJLQTdLaTRxVHNrK2VmR0hKU1dsRGFm?= =?utf-8?B?bnZRd21NVWQvbHRXWVFQTVpkeWd5OXF3ZTM5MzF5ZUpnaVRuTUJnVklXdk5B?= =?utf-8?B?TCtTZmFXdkJzblorc0RUeUczV0h4ckZiQTB3QWpjVENSNUVkTTFTdXZBM1kr?= =?utf-8?B?WlNyK1k2bFJnR2FacEkxZnlSL1RwVWpsNnVHdVJENHhYR0pnWmIySU5ncFdT?= =?utf-8?B?Wko4TkljTCtTcXFSQitVbVdORmJUMjQ4TjlGRWdZV0Z0RUVFcmdNZ1RlWXpR?= =?utf-8?Q?p/ie8dZJvyKMgmsZRx1vHmj1z+3MaK1UGznvLVR?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ2PR12MB8830.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TVhJa2R4VkphWEJsOFY3bHY2Qzh0eGV6WU4raUNLVS90SDhTL010TnVCK0Jm?= =?utf-8?B?SE0wNTdpYkw3UVNlcENrdFg5UkpNQ3NOVnJ5QUx4RUFqVGozTkcra0h6Rkk3?= =?utf-8?B?NldYRVJTZnpISUszbmNwdlJnNEREYUNyTjF5V2h1WTUwRmdoNFVUV2xsS1hT?= =?utf-8?B?QmNubmlYclVwWVVLZCtWWGFvcENlcDlvWk5yYzVXMy9rS1N0UkdkcnFkY1hm?= =?utf-8?B?NWR5ekVJcHp2dUU5OFk2VVNjZnlYU1psL1FxNHBaMXN5RWE1SEFKcVRLbWkr?= =?utf-8?B?TzlqOFVhV0tOOHBMYjZFMk92ZC9FOTcxcTA2QkloZ1prTHhvTDVKTjR2RUJV?= =?utf-8?B?SzIzRm93andsWlR0TkRFQzVSc0l5UzA5WU4vVWdESTVYVHJSVGFpT21qOTZi?= =?utf-8?B?cWRvSlBiWW0yVkRybGN4MzFhNkRIektwQ00wL2JZWGFqeTZRM091Ni81eG0y?= =?utf-8?B?OGhGbldLcXp4SDZZVk9UcEo5Mi94YTBGMXovWVpUVnJCMnJHVnhQcXJHeXBC?= =?utf-8?B?UEhXRXFTWmZVc1MzeDMrcEpTRDgrUytvNmFoT3YxckZGMlZYWE1HRCs5a3kx?= =?utf-8?B?anRzZHRVV1FGTERJWmU3bWs2YjNQVWdjL29mMUpnZDB1RHVTR1lSS3dMblVl?= =?utf-8?B?ZDYvM3ozQzd6MXYrME5Ua0orQjRzMlUzbjI1VlJyRHB4eWZIcUx0Y2ZCUG9m?= =?utf-8?B?QTZJRjlUS1pWSkZvVldQY2pmL0p1UzAwQXBDZUkrR3lSbG54MHN5MEE2M3BY?= =?utf-8?B?WDVuVVpnUzRIRVpnVG5SY2QxTitLVjJ4ekRoYlR6Uk9UU1k4TXRDcjl3UUNv?= =?utf-8?B?M1hYTWxHYXhDUGJ6WjBtSUtYRHRoQ0h0OGJKdW04bUs0bzZLMHJLTjZCUEpr?= =?utf-8?B?dWxkSElTOXkzeDY4eXVCcFhmRVlVd0tXaDdrTndFdEViV2lkS0dZWG1Rc3pi?= =?utf-8?B?YjFDNmlTQ3Q2M2p0K2k2WXF5WTdlWmtodjJDczBza2dud24zM2NzbTEyeHpi?= =?utf-8?B?U1VleWtnWGFFcE5zbFE5c2RZcFlIRC95MVgyUWd2Nyt3OXE5SUwwNUg2cmRL?= =?utf-8?B?WUFpU3RvN2tJSkZJRlFlaE1VblB0VU1iT200VmhQUHFobWIrdHZZZTFFNExu?= =?utf-8?B?S213UkxHd2Y0N2Q4N0g1OXFid2x6WDhNUlJ6VFhMYWQzMGF5ZXZ5V1I4Mldt?= =?utf-8?B?ZEYwSjFpSmUxcU5kZTNpVGZ4WFZYdWdZWjVITjhFQU5zMkE5MGtscEVDMGth?= =?utf-8?B?VEVpdGNaK1BFNUtEZGVGSXBOUDl4S09zSlFEVHZrUkd1MFlnTUQvSlFjejFq?= =?utf-8?B?U3VWTmZ4QVpqN0R1L0pYbzAvYXh2NWhZSm9YbmJXdTFuUGFWVkF5VHBwcWVz?= =?utf-8?B?dmF6Mlg4citEYTY4UWlKNisrdGZCbGVZRE5PeVFhQ3pRSURtUXBObDlBek5t?= =?utf-8?B?dUhlazA2M25VbTZDMU8vV2FxZ1Erb1lLSTdBMkJLM3VZK0RITFVGRDZCYXF0?= =?utf-8?B?WUxwUkVJZHpvVVNsRGNFeFFPNzh0YmMyNjhSMnJmeHBmTVMxMmI1Zmk1VnJ5?= =?utf-8?B?SUluTDJBVnZ5SUJURFkxT25TR2F2UzAwRVNYRURRZVVqaFoxdzl4MlRiV0hH?= =?utf-8?B?enlTQW1YbmtyNmd2a0ptRE5QZ0cySUV2THowenRwZDQ5U2RPeU5IZXhpWXVW?= =?utf-8?B?NHNyVXNMbHczYi8yMzRUcmZNRThra2M4QzVjTzA2enZ1UmpHSjZHZGIwZGcx?= =?utf-8?B?SXhXUkMvZnJSd3YzUnhHYzlnZUlGbThKUjJsQXFQVzZSQXI5eDRESjBQYVJ4?= =?utf-8?B?THU3bUw1U2tTbzBVdHJPRU5EeWlYMEVFb1U3UEZyQ05kTXlCdDY1cnphUlcy?= =?utf-8?B?YmVnaWRJZDNNVmRCTXpYc2MzNXdNTkRXMU1TVWg0eXRmZk4rTzZTcks2R0U0?= =?utf-8?B?TWJsRjB6Qkl2UGU0V3cycTk0VkFaTTZiY3FwMHVmTUNkTGRCaGVzc3RPZXZQ?= =?utf-8?B?ZWhTcmlmRWdKRVM2bGlwa2JVU2NJTnpudDUzaWlLUDJ1WXY1dVVvWEpYZHZk?= =?utf-8?B?TllxQXA4N1NaZXpsTUt4Q29vWlFWbTBQTHc2UUdoeWJxMklBSEo5SmNGODBB?= =?utf-8?Q?8DeshIwFlYvhkDYYW0KJBEPaS?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5f34bb7c-dab2-4600-b920-08dcfad925f7 X-MS-Exchange-CrossTenant-AuthSource: SJ2PR12MB8830.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2024 00:56:13.3942 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: riQA6+Ha1AHWDBFzZORd4PnEubJRqO1L7GnuMQs4vbUeI4kHoEr0wa+AC33H5jwG X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB8920 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/1/2024 6:21 AM, Junlong Wang wrote: > v9: >   - fix 'v8 3/9' patch use PCI bus API, >     and common PCI constants according to David Marchand's comments. > > v8: >   - fix flexible arrays、Waddress-of-packed-member error. >   - all structs、enum、define ,etc use zxdh/ZXDH_ prefixed. >   - use zxdh_try/release_lock,and move loop into zxdh_timedlock, >     make hardware lock follow spinlock pattern. > > v7: >   - add release notes and modify zxdh.rst issues. >   - avoid use pthread and use rte_spinlock_lock. >   - using the prefix ZXDH_ before some definitions. >   - resole issues according to thomas's comments. > > v6: >   - Resolve ci/intel compilation issues. >   - fix meson.build indentation in earlier patch. > > V5: >   - split driver into multiple patches,part of the zxdh driver, >     later provide dev start/stop,queue_setup,npsdk_init,mac,vlan,rss ,etc. >   - fix errors reported by scripts. >   - move the product link in zxdh.rst. >   - fix meson check use RTE_ARCH_X86_64/RTE_ARCH_ARM64. >   - modify other comments according to Ferruh's comments. > > Junlong Wang (9): >   net/zxdh: add zxdh ethdev pmd driver >   net/zxdh: add logging implementation >   net/zxdh: add zxdh device pci init implementation >   net/zxdh: add msg chan and msg hwlock init >   net/zxdh: add msg chan enable implementation >   net/zxdh: add zxdh get device backend infos >   net/zxdh: add configure zxdh intr implementation >   net/zxdh: add zxdh dev infos get ops >   net/zxdh: add zxdh dev configure ops > Hi Junlong, I can see not all of the eth_dev_ops implemented, and datapath not implemented, so driver is not functional right now. What happens if you want to run testpmd with the current state of the driver, I assume it crashes? And what is the plan for the driver? Are you planning to upstream remaining support in this release or in future releases? As the driver is not functional yet, to set the expectation right for the users, I suggest marking driver as experimental in the maintainers file and document the restrictions in the driver documentation, also clarify this in the release notes update, what do you think?