From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from nbfkord-smmo03.seg.att.com (nbfkord-smmo03.seg.att.com [209.65.160.84]) by dpdk.org (Postfix) with ESMTP id 176F158EB for ; Fri, 25 Nov 2016 15:22:23 +0100 (CET) Received: from unknown [193.34.186.16] (EHLO webmail.solarflare.com) by nbfkord-smmo03.seg.att.com(mxl_mta-7.2.4-7) with ESMTP id 02948385.2b6357a98940.69001.00-2476.129092.nbfkord-smmo03.seg.att.com (envelope-from ); Fri, 25 Nov 2016 14:22:24 +0000 (UTC) X-MXL-Hash: 583849200411d68c-85c46696adeaf8bfceb2bee9842cab6d112a5dec Received: from unknown [193.34.186.16] (EHLO webmail.solarflare.com) by nbfkord-smmo03.seg.att.com(mxl_mta-7.2.4-7) over TLS secured channel with ESMTP id d1948385.0.68998.00-2345.129082.nbfkord-smmo03.seg.att.com (envelope-from ); Fri, 25 Nov 2016 14:22:22 +0000 (UTC) X-MXL-Hash: 5838491e19c23f8f-16ae49b6314d8fabef848f7fb41610fe078daa2d Received: from [192.168.38.17] (84.52.89.52) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1044.25; Fri, 25 Nov 2016 14:22:16 +0000 To: Ferruh Yigit , References: <1479740470-6723-1-git-send-email-arybchenko@solarflare.com> <1479740470-6723-2-git-send-email-arybchenko@solarflare.com> From: Andrew Rybchenko Message-ID: <3a2ecff9-eee0-a66d-e18e-a7a20abfc9f5@solarflare.com> Date: Fri, 25 Nov 2016 17:22:11 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.0 MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [84.52.89.52] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-11.0.0.1191-8.000.1202-22720.003 X-TM-AS-Result: No--18.241800-0.000000-31 X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-AnalysisOut: [v=2.1 cv=HuVwbhnS c=1 sm=1 tr=0 a=8P+NB+fYZDP74ap4g4d9Kw==] X-AnalysisOut: [:17 a=RB3BGLmKESwA:10 a=L24OOQBejmoA:10 a=zRKbQ67AAAAA:8 a] X-AnalysisOut: [=se2TSXHzWJC3_KYImyEA:9 a=pILNOxqGKmIA:10 a=QyXUC8HyAAAA:8] X-AnalysisOut: [ a=rAxik90DKwEQ-N8O7SYA:9 a=Qv8uV7CGAZ7E7MTo:21 a=_W_S_7Ve] X-AnalysisOut: [coQA:10 a=PA03WX8tBzeizutn5_OT:22 a=avl4LiGQNoF5OB0DmCJ7:2] X-AnalysisOut: [2] X-Spam: [F=0.4557428374; CM=0.500; S=0.455(2015072901)] X-MAIL-FROM: X-SOURCE-IP: [193.34.186.16] Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH 01/56] net/sfc: libefx-based PMD stub sufficient to build and init X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Nov 2016 14:22:24 -0000 On 11/25/2016 01:17 PM, Ferruh Yigit wrote: > On 11/24/2016 3:59 PM, Andrew Rybchenko wrote: >> On 11/23/2016 06:26 PM, Ferruh Yigit wrote: >>> On 11/21/2016 3:00 PM, Andrew Rybchenko wrote: >>>> The PMD is put into the sfc/efx subdirectory to have a place for >>>> the second PMD and library shared by both. >>>> >>>> Enable the PMD by default on supported configuratons. >>>> >>>> Reviewed-by: Andy Moreton >>>> Signed-off-by: Andrew Rybchenko >>>> --- >>>> MAINTAINERS | 6 ++ >>>> config/common_base | 6 ++ >>>> config/defconfig_arm-armv7a-linuxapp-gcc | 1 + >>>> config/defconfig_arm64-armv8a-linuxapp-gcc | 1 + >>>> config/defconfig_i686-native-linuxapp-gcc | 5 + >>>> config/defconfig_i686-native-linuxapp-icc | 5 + >>>> config/defconfig_ppc_64-power8-linuxapp-gcc | 1 + >>>> config/defconfig_tile-tilegx-linuxapp-gcc | 1 + >>>> config/defconfig_x86_64-native-linuxapp-icc | 5 + >>>> config/defconfig_x86_x32-native-linuxapp-gcc | 5 + >>>> doc/guides/nics/features/sfc_efx.ini | 10 ++ >>>> doc/guides/nics/index.rst | 1 + >>>> doc/guides/nics/sfc_efx.rst | 109 +++++++++++++++++++++ <...> >>> And you can add extra options here, please keep in mind that there are >>> three compiler supported right now: gcc, clang and icc. You may require >>> to add compiler and version checks.. >> I've tried to disable the driver build on ICC since we've never tested it. > I believe we don't support selective config per compiler. Currently if a > code is enabled by default, it should support compilation with all three > compilers. I thought that the following lines in config/defconfig_x86_64-native-linuxapp-icc do the job: # # Solarflare PMD build is not supported using icc toolchain # CONFIG_RTE_LIBRTE_SFC_EFX_PMD=n >> I've failed to find list of compiler versions which must/should be checked. > That list is not clear as far as I know. Mostly version related fixes > added based on reported build errors. So you can leave as it is right > now, or can test with default compiler versions of some common > distributions. I see. Thanks. <...>