From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 841B1A0548; Tue, 22 Jun 2021 15:00:34 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 739E140040; Tue, 22 Jun 2021 15:00:34 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 69CA240DF5 for ; Tue, 22 Jun 2021 15:00:32 +0200 (CEST) IronPort-SDR: ejpanDUEVOTcWnWTaYmdO1+yptlP112Hy7kXGpRRUQpoT4Urqn/n+nuDIM2kSmAbQIbACIYm8B UAH1549Pf9tw== X-IronPort-AV: E=McAfee;i="6200,9189,10022"; a="194357549" X-IronPort-AV: E=Sophos;i="5.83,291,1616482800"; d="scan'208";a="194357549" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jun 2021 06:00:30 -0700 IronPort-SDR: AKcDnysCr8Is+VZyQ7qByKJkUtM+XczIsuSfL0tSvC1dYfK0QzBQVwXF+H2upsrrSy5nivlwDM ajCfy312Gljw== X-IronPort-AV: E=Sophos;i="5.83,291,1616482800"; d="scan'208";a="423309133" Received: from ebaldwin-mobl1.ger.corp.intel.com (HELO [10.252.14.169]) ([10.252.14.169]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jun 2021 06:00:28 -0700 To: dev@dpdk.org Cc: anatoly.burakov@intel.com References: <20210622124335.2213-1-david.hunt@intel.com> <20210622124335.2213-2-david.hunt@intel.com> From: David Hunt Message-ID: <3a3a8245-6a85-058a-f01b-9b7795f17336@intel.com> Date: Tue, 22 Jun 2021 14:00:27 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: <20210622124335.2213-2-david.hunt@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Subject: Re: [dpdk-dev] [PATCH v2 2/2] power: refactor pstate and acpi code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 22/6/2021 1:43 PM, David Hunt wrote: > From: Anatoly Burakov > > Currently, ACPI and PSTATE modes have lots of code duplication, > confusing logic, and a bunch of other issues that can, and have, led to > various bugs and resource leaks. > > This commit factors out the common parts of sysfs reading/writing for > ACPI and PSTATE drivers. > > Signed-off-by: Anatoly Burakov > Signed-off-by: David Hunt > > --- > changes in v2 > * fixed bugs raised by Richael Zhuang in review - open file rw+, etc. > * removed FOPS* and FOPEN* macros, which contained control statements. > * fixed some checkpatch warnings. Please ignore, should have been sent as v5.