From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E28E542D31; Fri, 23 Jun 2023 16:00:37 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6FAD540ED7; Fri, 23 Jun 2023 16:00:37 +0200 (CEST) Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02on2073.outbound.protection.outlook.com [40.107.95.73]) by mails.dpdk.org (Postfix) with ESMTP id 41A0A406B8 for ; Fri, 23 Jun 2023 16:00:35 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=by/W6dN2d30jlWZJmgRoIt0374QhKZlegN+yLiHpXuh/sK+p2ofcwvkJXmb2SC/dlKAmc5B91VuxrFsrV/91Aibi/1qg1X3C8hzGa5mE5YFbdkqcOyajtmYP6SPxRzLZTlP+vFDL9L+Nz1NfkSRVzLff3kim1hDhfUnsNGnavcp7tqKCwJ2B12zf3rzj9aKnak6x/YYzlBmY/wC4rzdIBjSyZ+abWa4TzgU4l6wfbKrFwr27+TK5eqG0xTtP8V3dywZ0dZauWlnfIvRGl5OA3xAtsM3LMfHJzOBnsks9tatzaMWFpN67En4vM8kGZC4kYmsgBTyZFcpBa8FtdK+d6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0WowedRBfQhS5Ysfw3fhnILMxpbRPRWZ/W92v+NIf5I=; b=DbjiU6yElkZ7bJytd0xc1Yv/LMQiCPqaixtu8Yw8kxlmK58KcmF6QmqS+PDPS/fi3un8DZhCju9gmOBeUWXIqdpTzB8D08HAp9B1O4aT2UPoXZUiEEHyHehH7lAtw1aGvHTUvFGf+ezUbDnKIK1YM+U0/Jmshi7LghWHSaqM3BYW9qTbnLWcAK+E7IOEZl7gFxqSgQ7/qcNX8v15UoMjjCT7Ds2ChkMq/ChbdTy3quQm6kgj1p/PovwsZjrTVJLWyyMmsyqMtRYmr/ghT5K3sz4YDtL4X7GGF2SDRGvJ5NFXRf1+kZxsfLX8iDUCC1krHD9rw7OeWnenXkIzRvBWYQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0WowedRBfQhS5Ysfw3fhnILMxpbRPRWZ/W92v+NIf5I=; b=q5sVnh1PqmfdUiIGEoL6r8kyMtCgnYcDSAJJnmWV8u9dcG3f2cBJ7tC78upOd/I0gAs1gjAORRk2zTZhXShYGSuBTCmt7WA3ak4xjck203QNCvZDAjSBCYJIcWFP/s0+eCwlGsudc+VZIMm4csncBS4WCeEKC9Kd1m+ES5Zqs64= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by DM6PR12MB4122.namprd12.prod.outlook.com (2603:10b6:5:214::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.24; Fri, 23 Jun 2023 14:00:31 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::16e3:326c:5c2a:be42]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::16e3:326c:5c2a:be42%3]) with mapi id 15.20.6521.024; Fri, 23 Jun 2023 14:00:31 +0000 Message-ID: <3a74993a-a37d-381a-f33f-49deff8f0f10@amd.com> Date: Fri, 23 Jun 2023 15:00:21 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Content-Language: en-US To: Thomas Monjalon , dev@dpdk.org Cc: Aman Singh , Yuying Zhang , Ajit Khaparde , Somnath Kotur , Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , Hemant Agrawal , Sachin Saxena , Simei Su , Wenjun Wu , Qi Zhang , Xiao Wang , Beilei Xing , Qiming Yang , Jiawen Wu , Jian Wang References: <20230203132810.14187-1-thomas@monjalon.net> From: Ferruh Yigit Subject: Re: [PATCH] drivers: remove compile-time option for IEEE 1588 In-Reply-To: <20230203132810.14187-1-thomas@monjalon.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0211.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a5::18) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|DM6PR12MB4122:EE_ X-MS-Office365-Filtering-Correlation-Id: 8e25786e-c29e-4405-2ec6-08db73f234f2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hEVrSzgYCV1+M3u2gwnanz1zc9x6+atky+WkXxFX4LCNShqyt8ptfKESpHDAatyusNxnjkMo5eO8X2Agc1XKZtYFrxwQc/l/tKKN8FZzaTfTQtIG0RkIDaNCHVEWIu30wWvwyiNkjzSVMzyqkw8v8QdpFjhlgwalGRn1frcR51DpIoO6A2i641zA0nUZKqGYDM8S1jr1i6enj8/cfae5S1rKVvFQShaDX6XD0IEy72VrtWWmuZ/VPksWJQMALpODcJTBrZS+EAbRiaP6YBpxEGbnOZMcyo+XdHbxUBWcBi7xEy/NqVRQIMauvQ7sMLTXjY7b2ikkp4QNnwVxEXj5FGopSBQqXAvxLvPAaaUZAn4SqyJL85d1tisCuJY9pb0MD6OVewRC0GL9xPvNvcjX4bAF7KBv5SEK1WmA4ZEIgkI+CtHvycPPHpY2JzTnb5Q3RpyNYRNgqYFKdaO1bZ0AOup5PBuS8NAeQgBURKmiUYs8ycicQZXmsVVDrGH42kE3Gpk4R5aiRECqZJ0HN3OFlS7gsaz3aclGcLFixKEYVr1APta/kMbYnnhK3m/A0PM6RNiP/J8mH4o+vbfe7Tw5B9AzzOCa/hjilzvtKrjefG45kjxy9WlVR87KfktGZ1GT8GUwWxGoiB1nGAHB5akCog== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(366004)(376002)(396003)(346002)(39860400002)(136003)(451199021)(478600001)(26005)(186003)(8936002)(8676002)(6512007)(41300700001)(38100700002)(316002)(2616005)(54906003)(66946007)(66556008)(66476007)(4326008)(36756003)(44832011)(6666004)(86362001)(31686004)(7416002)(6506007)(31696002)(53546011)(2906002)(4744005)(6486002)(5660300002)(83380400001)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VytlUHIzWjhQODQ2cDVNQVZoUG1sVy8zYUlJcmJuT0VFOXVBM0ZkT2NiMm03?= =?utf-8?B?NXhEK3p1a2t1YkJ4RGxWUFJCaFAyd0M0Y3NpRHhBWE04RERLcWdqSGQvTkdq?= =?utf-8?B?OWYzWlMwbExJOHhzb04rRkNBSmJWUGloLzJwWVZJZFpLT2k2bnN1WlE2amx4?= =?utf-8?B?UHlPS2VYOG5ENDVFUXM0UktNSjVhdGR1dHN2eDdIRVR0UFhrckNqZkU2Uy9a?= =?utf-8?B?M214SncrU2duelByRHcrOXp0bDNyR0NkUnlDUThpRmNWSWRSNlpJM3Q3U3Zz?= =?utf-8?B?ejBJME02QWx6QWVjbjBiaFN3Zy9ldkNQTVgvYnkrd1VsMGRzcUZEbUxvcWh1?= =?utf-8?B?Vk5KdVEzRllpSVUyNXBsbUFRZ1RUYmY5aTVsTEo2ZVVJd2gxYU5SUzNIVGQ1?= =?utf-8?B?eGkrVlVmOHVyRE1adi9MdHdIai9jWjhTSkVoUlgwTXp2dlpPK2k1NnZPVjFl?= =?utf-8?B?MHpPSGdFaHpzbFdnSmdxSGhoNERTelNKdWFQMWhaS0xLWlhaOFMzM1VsZ0lR?= =?utf-8?B?MG9oamRFdER0Q2RRZTVrVUl0RERVNnVVVkZzYVZwMUgrcTdodFRLQnREYkVN?= =?utf-8?B?dVZDL05qaHZNUXhIK3JHSUQrZ0ZPaTFySHM5M2UrTUN1Z1MvWFl4V1JIMk9t?= =?utf-8?B?UGNieFIydmIvQ1M1QUFXV0tmTGFjVmJRMjFpcE5ZY2FENFdtSzVmNDlsbyt1?= =?utf-8?B?QndvaU1mTnBvZG5UeHE0QUdTYlJ0VnludkdaZTJ4R3pLOXdHR3FtZEc3MWN2?= =?utf-8?B?T3dEKy9ya2tNOTREdjVtMll2dHN4ZmVSeXFEdDlaWHNkbTdYZStpeEpmUzNR?= =?utf-8?B?dk95d0FLS3VQVk9OVVd3RHVma2MxY1dyWDV2S1BqY1BnNW0yZ25hUlc0S3R1?= =?utf-8?B?NGpjWkphZytFaW81WkJ6RW8reCtPb1lmbnJBNnRhcWpRQnk5ZGFGMUMyVGNh?= =?utf-8?B?bnJxcE4wUHZJNENFSTA0VTZMZUFPYUUvZkMwdnFKeHh5K04zN0Rwdk16eEJX?= =?utf-8?B?WEFNMGVOMHd6bDRzRDVadmxVbGh4a2M4UjVUSENJWHZzbzBjdXBDMmZ2cnZO?= =?utf-8?B?d3AwUVVTSW4xczY0ZnJ0QkFVdEJSMVNHNCtyM0U3bER0dmVZRWdmUGJvWTFr?= =?utf-8?B?aStYeXFmdUxHOStDa01DSC9DQzJGYyswR0xsYlRFemRickpPbHFEU0JTZmFv?= =?utf-8?B?ZnByRGgrekZYM1F2K1JpS2VJcTBEMmdmZFZXSDJFakNJU3JhaWliZmovNUZN?= =?utf-8?B?czVTMDNMU1B5YVdnMEpHVVN1dmNKeUMvSVVjQU5YMVdVdy9oWWl2Z204bnVD?= =?utf-8?B?K2RPaEN1WnVEVnJmS0d6OE9hL0RiRDNTUElMMVYrSTAwRUk4MmRaanJ4VndB?= =?utf-8?B?Um5zTVQ4c1hzWElqNGIyaW9uL0hXdDZyRExMSThDWG5kRHFhSk1Dczk3eVMv?= =?utf-8?B?NGRPdWNlRUF5bDJqbFBmY2dHM2U5ek5tVlp3TTU1VjFVdjRpai9WZ1lrdFJG?= =?utf-8?B?Z0dPL1dWRk5oWWFSZERDTWVwMXVIb01MdWNBV0Z1cWdQTDJHNnd3NXpIK0Vm?= =?utf-8?B?eC9USWdsZVJ4bjVDQ015bXlxYUZscXNBUnM2dTdDUHU0WGxOckVTQUVWVEhF?= =?utf-8?B?MHdwaElPM3RBQXBRWEtsNHYweTdJU3EyWFNaQjMrZnZNYndjQWloTGRObUIv?= =?utf-8?B?ZGQ5S1VnbGRreDA0Q0R4cGd6a0tET0tJNkVWeHc2dWkvNW9zWGhPZDJkaFd3?= =?utf-8?B?cUtFUEttSlY4WG9TVW9COTBSK2lWTXNURDl2ZXZPUEpBYWxqMjUrQ0VSaXNM?= =?utf-8?B?clJFNTdTYUc2djNVekhwbkl4OWljZU5MZmdVS1Q5UzBLQXhmOEZndXNoamxu?= =?utf-8?B?Mm1vbUs2YUpjVWtZN01IZzVPd1o1UGdyZFkwZC9mWnV1Nm1GekpyN3hUb1FO?= =?utf-8?B?Y2VWVFdkek1qNEtTS0dXdEFkSnk2TTh6OWtwc0ZnSXUvZzlFR21VN2RLRG9J?= =?utf-8?B?eWx0MW82VEQ1S283VGRvNGdRdmRxaFpUcjFjVmZuRHZ2d0xpRnVLMmE0Q2Zm?= =?utf-8?B?MlRzaENYanJZOERpL3oweDh0NkVxcFNmQk1rTTZnZTVCU3pxYnVKazN4Ry9Y?= =?utf-8?Q?HUxvTDGEoCNgUyR0QOZt0SGoA?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8e25786e-c29e-4405-2ec6-08db73f234f2 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jun 2023 14:00:31.1925 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vMrBVTlVlyqbhZbNmoV0HJZBeuxJXEYCt0HryJz3oQ8rNJsf/XVvxyNm0/j1GAWM X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4122 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/3/2023 1:28 PM, Thomas Monjalon wrote: > The option RTE_LIBRTE_IEEE1588 has no effect on any library > unlike its name. > > Also we are suppose to enable/disable features dynamically, > not at compilation time. > > And the best is that this macro is neither documented, > nor in rte_config.h. > > It looks to be a mistake keeping this flag, so it is removed, > meaning always enabled. > PS: it is disabling vector paths of some drivers. > PTP (IEEE1588) processing brings additional overhead to datapath. Agree that it is not good to have undocumented compile macro, but just removing it may cause performance degradation. It may be possible to have separate burst function that supports PTP and driver configures it when application explicitly request it with a new offload flag (although it is not exactly an offload), what do you think?