From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Jiawen Wu <jiawenwu@trustnetic.com>, dev@dpdk.org
Cc: stable@dpdk.org
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH 2/4] net/txgbe: fix VF MTU limit setting
Date: Tue, 27 Apr 2021 17:44:09 +0100 [thread overview]
Message-ID: <3a7b4c16-1bb7-8959-b2bc-62ea9dd16ede@intel.com> (raw)
In-Reply-To: <20210425080347.20376-3-jiawenwu@trustnetic.com>
On 4/25/2021 9:03 AM, Jiawen Wu wrote:
> Fix to set MTU bigger than mbuf size when device is stopped, scattered
> rx may be enabled in next starting, exempt from setting in EAL parameters.
>
The main change is 'dev_started' check, right? Can you please reword above
paragraph to clarify it?
> Fixes: a2beaa4a769e ("net/txgbe: support VF MTU update")
> Cc: stable@dpdk.org
>
> Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>
> ---
> drivers/net/txgbe/txgbe_ethdev_vf.c | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/txgbe/txgbe_ethdev_vf.c b/drivers/net/txgbe/txgbe_ethdev_vf.c
> index 3a5123733e..5597968e18 100644
> --- a/drivers/net/txgbe/txgbe_ethdev_vf.c
> +++ b/drivers/net/txgbe/txgbe_ethdev_vf.c
> @@ -1115,7 +1115,7 @@ txgbevf_dev_set_mtu(struct rte_eth_dev *dev, uint16_t mtu)
> {
> struct txgbe_hw *hw;
> uint32_t max_frame = mtu + RTE_ETHER_HDR_LEN + RTE_ETHER_CRC_LEN;
> - struct rte_eth_rxmode *rx_conf = &dev->data->dev_conf.rxmode;
> + struct rte_eth_dev_data *dev_data = dev->data;
>
> hw = TXGBE_DEV_HW(dev);
>
> @@ -1123,13 +1123,15 @@ txgbevf_dev_set_mtu(struct rte_eth_dev *dev, uint16_t mtu)
> max_frame > RTE_ETHER_MAX_JUMBO_FRAME_LEN)
> return -EINVAL;
>
> - /* refuse mtu that requires the support of scattered packets when this
> - * feature has not been enabled before.
> + /* If device is started, refuse mtu that requires the support of
> + * scattered packets when this feature has not been enabled before.
> */
> - if (!(rx_conf->offloads & DEV_RX_OFFLOAD_SCATTER) &&
> + if (dev_data->dev_started && !dev_data->scattered_rx &&
> (max_frame + 2 * TXGBE_VLAN_TAG_SIZE >
> - dev->data->min_rx_buf_size - RTE_PKTMBUF_HEADROOM))
> + dev->data->min_rx_buf_size - RTE_PKTMBUF_HEADROOM)) {
> + PMD_INIT_LOG(ERR, "Stop port first.");
> return -EINVAL;
> + }
>
> /*
> * When supported by the underlying PF driver, use the TXGBE_VF_SET_MTU
>
next prev parent reply other threads:[~2021-04-27 16:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-25 8:03 [dpdk-dev] [PATCH 0/4] Fixes for txgbe Jiawen Wu
2021-04-25 8:03 ` [dpdk-dev] [PATCH 1/4] net/txgbe: fix RSS in double VALN Jiawen Wu
2021-04-27 16:42 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2021-04-25 8:03 ` [dpdk-dev] [PATCH 2/4] net/txgbe: fix VF MTU limit setting Jiawen Wu
2021-04-27 16:44 ` Ferruh Yigit [this message]
2021-04-25 8:03 ` [dpdk-dev] [PATCH 3/4] net/txgbe: remove port representor Jiawen Wu
2021-04-27 16:46 ` Ferruh Yigit
2021-04-25 8:03 ` [dpdk-dev] [PATCH 4/4] net/txgbe: add copyright owner Jiawen Wu
2021-04-27 16:50 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a7b4c16-1bb7-8959-b2bc-62ea9dd16ede@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=jiawenwu@trustnetic.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).