From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr60088.outbound.protection.outlook.com [40.107.6.88]) by dpdk.org (Postfix) with ESMTP id 728291B01F for ; Thu, 21 Dec 2017 11:12:39 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=cE+R3pGg+RWMbufBqf2MurxxbYZ21/We7N7WKc35HLc=; b=NRdtsDZQQHYTL63Khozpqtv5o9c2hoA3JX7GHtu59c5HR3f1WVhcN2h5gaMve2a4h3ovzEui1hh7G4hFWCN5l9ZwwWAoFxSL5bPWIOdGkcY5Qcawecld6195FcVStmsJyHsrE9LqrXGxqZOormt+u+GIYPVoqjyxfkmPaPZkLcw= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=borisp@mellanox.com; Received: from [10.8.8.16] (193.47.165.251) by DB6PR0501MB2229.eurprd05.prod.outlook.com (2603:10a6:4:4b::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.323.15; Thu, 21 Dec 2017 10:12:35 +0000 To: Anoob Joseph , =?UTF-8?Q?N=c3=a9lio_Laranjeiro?= , Sergio Gonzalez Monroy , Radu Nicolau , Aviad Yehezkel , Liran Liss Cc: "dev@dpdk.org" References: <5d3fdd0c05d5f8afd3f8e38ca03eaf25187d5c98.1513000931.git.nelio.laranjeiro@6wind.com> <5777791b-3dd6-f746-aa37-d572c108f042@caviumnetworks.com> <20171212134456.4x3uaus2poovddlf@laranjeiro-vm.dev.6wind.com> <20171212143800.ggdtdfnbknttr45g@laranjeiro-vm.dev.6wind.com> <047cadcf-13dc-5368-4ad5-a27ff25c42f8@caviumnetworks.com> <20171213100237.uvpbg2qewhxqgaln@laranjeiro-vm.dev.6wind.com> <817bec1f-4bff-ebdc-07b4-f8f24ec2084a@caviumnetworks.com> <20171213125353.2zyllxk7pwkncm76@laranjeiro-vm.dev.6wind.com> <577d100a-d021-1219-89e3-721e02b77b90@caviumnetworks.com> <20171213144710.tyqvcvpkrymzqriv@laranjeiro-vm.dev.6wind.com> From: Boris Pismenny Message-ID: <3a91e865-ca96-09d4-b842-7e5d0a5ad6e1@mellanox.com> Date: Thu, 21 Dec 2017 12:12:29 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [193.47.165.251] X-ClientProxiedBy: HE1PR0102CA0020.eurprd01.prod.exchangelabs.com (2603:10a6:7:14::33) To DB6PR0501MB2229.eurprd05.prod.outlook.com (2603:10a6:4:4b::22) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 92d9fb72-df84-4978-b3e3-08d5485b5c76 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(5600026)(4604075)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(48565401081)(2017052603307)(7153060); SRVR:DB6PR0501MB2229; X-Microsoft-Exchange-Diagnostics: 1; DB6PR0501MB2229; 3:f4pK3lrGMbW1EQlRUO7UIF/7/d0WN5F0rcR6ttAPA29Tuyk1rUq+7OUgGdO3NKN1cbB98NBpyOei1AUhLD18QzkR35m29VaLcvtk9bzDqWnzZY2rJCvCyONz7+XoDDg+yKPD6aAXAoPWNeuiGIZBFBj4wK7A7R2w2WBPCz3IQBn6s2LpQZs/rY0e0rTZqgo1IA1qUN5olJDqOp6s3NBnEee7XTpVHP040o6mmQper9V7kAwUxWTigsNCDDK55SVC; 25:p6xs2m36cF+puc68/VF2ThbfZvTdSPUtCauskGdacxdL/iko4rTW9a6CQwbHS0B4d8eNfz3frMb0naq13HoK4al5kDbC4LwQCCMa+85MrDRy/7dWJW2qZiwkg9ys/ZuQxlG8o5v/RrB8nh4CuGknkrZ92fiLx8h6/Yap9VYq7WLULh4dxD7EDvyVGA07OSuzZQrvw/vvpyLPmigqr+9QitTeyFxLZ43jvrN5pVonF0omIeMVSDDYXnXrCrTCGU7IQdL/ZcI/jkdmvphD0ZNhgg5uo78iNNEXkOFKbed7InS3bF3lm8qto+gDX6v8dGhn72W5eIybYSVRzJ8pk5/12P5DF5CUfdDBGM4VYKw2eSs=; 31:swgK55R2xROlVsAonys1MLpi/y5sWqJZTzXoj/EzN+QA/d8tYqrCKP/At8kNThn+Azhhi8q7z3pwCFp5XSIqP3pX6U0L+XMsN9lYFzBAg1NvzP3wWuL++R5VhDhScJCvvS+hSERJ9Ao7jitdAt3K1bYV5ijZpjTKb/9NuAcYkO7aToutnQDfqfGAobroFzijfA4d2yjJwcLkp0DQ/5LJ3TbRfvP1Orm+G5YNXkvxsbk= X-MS-TrafficTypeDiagnostic: DB6PR0501MB2229: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; DB6PR0501MB2229; 20:LAvSGx8iAy8kwydEpJouslcXBcKUt15ZbhWHHD6EDhYjxkW4uAnu7BckOKOHFkDe+fpggLjMnCDO+9tovsPToLcTq3py+QKFVpHNNhFHGGPp8Wsxz51DtVgu4560sA6pk2zWPCCjQK1Il9SRIWXKvIs5a9faCS2GfMgh2Za+vEMV6eeTd5BVO9BMEX449uTQ46TYn69eHKjoB1z5X+CitfBTJ/WLKDWxWVehwTvbWWcclM3Mx7dqbdykLsiAEq+pBdY50aYVL2rb9Age1oFr5ItgHHiWv93dhfzpSvZbxq/zuCcp2B8KnTeydgiVeKD+sfjoFuxB5bFJyPmxHnHUOd7baBi7qv7iz3DwcUzVcCbPxFQGp/HfiRCy6OTjAEQYJZLOi6SMPQy4kANXVF2vKxJhHOrB7cx5JfdtF0gb1UCSk2G/C+12BoUg5YqK6L19nHghmralZqrb5qo5vr0Xjt2wplZDNsj3voGOe+5ac+9ftydS66rk0LZcIkQogox3; 4:hx3l/7cnHtjI0e94nKEgw66FMG12mmX6FA1HB1MYOpPgvvnOsGt22/E5Sv1Bvq+V+5sEvGAJMckiUPtGZI9cmOYnckKERYiSMGzJhz/kio/H8Lt+E533tYx80iZw61AYeUbKmKh+mfcVpccNyxoaOJgUP8cYRho08nKUmgNQzbIbawRfDXs3AiHn5lSErWSApXW5nU7x9BQ0WbcQJyom8zzP7IiTd4ZEDumalkEfR4OnMxTHIztJ3bmONWO+12uyaXqa6WxTmd4G6ppVMc9ar4DZ6KebpeCl7rr+gGbwnGM7WRAywWX+oG7e83kDYBCGtLguCddYmDct+5dbU+uRzcuQZYcseJQf5hXL4XdmScgz2JGOAP+JeA3M01dgAPIs X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(278428928389397)(192374486261705)(17755550239193); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040470)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3231023)(3002001)(6055026)(6041268)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123558120)(20161123562045)(20161123560045)(6072148)(201708071742011); SRVR:DB6PR0501MB2229; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:DB6PR0501MB2229; X-Forefront-PRVS: 0528942FD8 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6049001)(366004)(376002)(396003)(346002)(39380400002)(39860400002)(51444003)(52314003)(199004)(189003)(24454002)(16526018)(3260700006)(110136005)(25786009)(36756003)(50466002)(47776003)(65956001)(16576012)(66066001)(4326008)(65806001)(31696002)(58126008)(3846002)(2870700001)(6116002)(6666003)(53936002)(93886005)(105586002)(86362001)(77096006)(106356001)(6636002)(6486002)(478600001)(229853002)(2950100002)(59450400001)(305945005)(81166006)(386003)(76176011)(316002)(2486003)(6246003)(7736002)(68736007)(2906002)(52116002)(53546011)(52146003)(23676004)(67846002)(81156014)(31686004)(8936002)(8676002)(64126003)(97736004)(83506002)(5660300001)(65826007); DIR:OUT; SFP:1101; SCL:1; SRVR:DB6PR0501MB2229; H:[10.8.8.16]; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtEQjZQUjA1MDFNQjIyMjk7MjM6a1U4eG1adWhoNEtMU1l1M0ZDbGdNSG1C?= =?utf-8?B?dTFQYWJ2QU44YmtwSE9vRXZBN0RHYnV0WUc1UVlYa3hlRlVHaG1rQlc5VC8r?= =?utf-8?B?bFVnZCtnUHlRMmlISzVTWGNQS0xXdW1tQXR6S3RaWDBPS29taVd2QjdWVkNL?= =?utf-8?B?LzYxUEMvdXVpVksxbVNRS2NMc1RQSFNOa1VPN2hwQkJHbnpXR2hwbE1QY1JU?= =?utf-8?B?dVdrNE5US2RJUkFST3c5Q1N6ZFJ2RlNTQy9NcUdsbmdyQjV1UldEaGhKN055?= =?utf-8?B?bUdWR2RIV1lPZ09BRDJaQUp2ZTlONjBGaDZRRE92MFNPNzl3Vm1JeGVLR3Vo?= =?utf-8?B?M0tnb2VwY3h6anN0MEJFZjFlRFloT01EaUdtKzFQM2szZmJWM0J4QVpEY3Qv?= =?utf-8?B?eDRmQklhUlRoSE85MHVyZWxaL0VkRWowbmNaei8yNVRDVytPUkJnSGZrVTh5?= =?utf-8?B?anN3VitkYjU1Z0V4eFg3OXRrb1JBemhrcUFRVFBlV01yQ1loYXBLZ0xUczNB?= =?utf-8?B?MkMwWkU1TmRveDUwWVV2QitlVHVGWVcwUFlNNm1qZUxPY1d5dXpjWmNpRG5M?= =?utf-8?B?NHNOTnY2R3Frdm16Q2FubUc1NFBKT2NEcWVLUHN1cnErZG5HcEFYRCtnTVpQ?= =?utf-8?B?dU5pSzBtOWs0aytMZkNmbzJNRWlsQW1QL1lqNkN0anVLaUpMWHlqaUE5UmJr?= =?utf-8?B?ZXRDV3p6R21CVEs4emw4My9GdUtPUTc3endoNlpLYUxkUHZpWFd2aXZadkJv?= =?utf-8?B?cHNwSFYvaWs4YmhjSVg3dzdFY3RUQ01lejhMZ0hXMGZCRlB1MVVGeEwxMEJy?= =?utf-8?B?VnphZHpYdVQ5cS9ZVmJSRzViTXplcCsrYnppcXQyQTIyZnYyQ0grc3cxL3Fp?= =?utf-8?B?YW5IRmQxcWxscDVmNEhRVjRBdXdIbm9EbG1HaGI0ODhacEYzUmpZL0hQSkRy?= =?utf-8?B?c3UybTVacmJvU2FOalMycmZOMW92YnhHQkMvc0lSUEVOSkxMS1pZU0RZTWFt?= =?utf-8?B?MUJWeUsxWTU3NXpvZHRBR3psMlZRa1hIUDZBTnRVbmNlSkttWjgzd3FDZ0h4?= =?utf-8?B?OWJySy9GOTN3Z3M2WXhvZmZ4YnVYMXdkOGtsM2NIMCtvZzczWi9JRS8rQXRG?= =?utf-8?B?Q1VOL0V6UjJ1SmZ3RHhCRGU5c3ROU0R1T0RpdWFaK05FcFpEMnBSUXFkV21N?= =?utf-8?B?Wno5SmtWV0k5YUdTM1JRUndodUVtamI4M2JPSHVSc0VrOG85bmpnMWJaZ2xM?= =?utf-8?B?eEFYZ1dyTmJab0c3Z3ViZkk3eFIwdXlqdXQzZ3dYQTNPQjQ0T3g4cWk5cWFk?= =?utf-8?B?L1pOdWNqMU85RkladFlCR2FwWmR1UWlabXpyU1dTamFZbmw1RlBZcEVvZU54?= =?utf-8?B?UXZwRGIrM0l2endBdWpVYmZwUkZuMlB6d2lBVm5ocnprMHFUMTBoQW1xeDRu?= =?utf-8?B?bFMybkx2dnc5SDBsdGp3azRLTElMMWRsNXBrbDYxOTY1N2FyQjRwdUJVZy9D?= =?utf-8?B?ZkVaRnZKYUVxamZGY3dWdEdUMTl3cjNXNGhEVmpBNUluMlViMXVNeEVjc2F3?= =?utf-8?B?RmxMaWFJdWFQbGpGa0hQTTB2cTFyeHBQUmVpUU5iN0xWZ3YrRXhqaE16djFt?= =?utf-8?B?bGZDRzFId1FocFVYN00yUnhSbDNvcU9vR2JJcVNBSXBJenNjTklTRXdFTDdZ?= =?utf-8?B?MHRyTFlJOUZWV2FOeXZjVUdBYzFEL3JQOHoyQlpKVVhqWEFpZHVWTWs2Q3By?= =?utf-8?B?eitGMGN0UjB6QUFqZ3BncUJPdTYweUtzMXN3aHZxZ1JibU1qV3RwRm41ZVJ1?= =?utf-8?B?SDROdlAzMFVRRUtFNWF1U3pzSTZpSTVSZXFjZERiak9CYjNFanlpWDUvcUc0?= =?utf-8?B?STV6KzgybytJeTJyUHo3cGxlL2Evc0o1ZnB0cVJCZ2VhaTErV2s4UkhiUkZk?= =?utf-8?B?amVIa0grOE00LzJUbzdvNU9BZDZ1MEhCdGR3djF3MjZyYUYzWHNBejJ5QVgx?= =?utf-8?B?UXF2MUx3emNtMkNkMFdZeWVRMXM0VXJXS0tLWlZ4cVhhQm54YjE5VHl2Tnor?= =?utf-8?Q?rEBwjc=3D?= X-Microsoft-Exchange-Diagnostics: 1; DB6PR0501MB2229; 6:X3gGdVuE1Qeap5KMLOZibIRjPNg26JelnVfsFNANlUbKulFGLFv6MYuJSQKnHNxtUiDIdOPGFSju1rR0xZ/RMSm2G5pGjMo5WOuBihOfb6ZjtYTIYE8rXhfjj4HwlusrFF+Mke3s5ne26c/8Y6y9q9EMe5PMCilbjXXc2ZVJm9PzzZIFu33zvmACBLlm9EE2S0qEuEP50s8Ug7JPzyE2TDo/+6h/u2sFy11Pl/XoyJiEXJV8nskcmlIN0PcpHJdcfgRzydDxzpAJYEvs4MTysoU40S2OT0NRIqdVBvpRRi78U5z2wFPieIlktwCk7NHV6QGjTFC3LcVGJoUhG5bmyq0ZdWXdhN+LU9Q6Luqcpe0=; 5:utW7hASeqJK8bayvp/wAlx4OAloeAcRTlpxMCQlbVubSLfByxfNhXTxj+8pu3XO0hnOZb4w/cx199oeWcT3wV4HtRHGo3fX6C91RKnoqEOVxXh4qpo8L+1Ynl3qBf75ck7z02Lje/ps6tHDJr1feFEupOQYfiF/DKAKuAHbPL+I=; 24:Kj7Ka2g7CV6xE4469yRvzag0MHzW28YNEwRt1K5nwEpDqf7hyKfONigIlB9/exdzT8EYb3PowKWiocJiGWlEoumVz2CvDte3CT8UVllasS8=; 7:sWtVQJsRobqOBo0Vlk6cn40hg0I6i4WMOB/x9gd/FtnAmDCXCXOYj39ktBLeDoI0R44nEbTYvddd11gdNy4nmbLVpaL0y8i5HQkdgWGVL++e8Crm9gvr7HHinGZ+8iSnYlj8fm1W7rDBt0bZ+GBtEWyxZDrgu/KkC1eRTK2CtaisAD0/sZ9ru20EGVA8RASKvWJiUHDc/l73S/G0Tg85S2BvNpaU8nyxDeRnZy5a3MEkGFYMBMTdmnDw3P9Sm8eK SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2017 10:12:35.9862 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 92d9fb72-df84-4978-b3e3-08d5485b5c76 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0501MB2229 Subject: Re: [dpdk-dev] [PATCH v3 2/2] examples/ipsec-secgw: add target queues in flow actions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Dec 2017 10:12:39 -0000 Hi Anoob, On 12/21/2017 10:06 AM, Anoob Joseph wrote: > HI Boris, > > > On 12/20/2017 09:49 PM, Boris Pismenny wrote: >> Hi, >> >>> On Wed, Dec 13, 2017 at 07:14:19PM, Nelio Laranjeiro wrote: >>> >>> Hi, >>> >>> On Wed, Dec 13, 2017 at 07:23:19PM +0530, Anoob Joseph wrote: >>>> Hi Nelio, >>>> >>>> >>>> On 12/13/2017 06:23 PM, Nelio Laranjeiro wrote: >>>>> Hi Anoob, >>>>> >>>>> On Wed, Dec 13, 2017 at 05:08:19PM +0530, Anoob Joseph wrote: >>>>>> Hi Nelio, >>>>>> >>>>>> >>>>>> On 12/13/2017 03:32 PM, Nelio Laranjeiro wrote: >>>>>>> Hi Anoob, >>>>>>> >>>>>>> On Wed, Dec 13, 2017 at 12:11:18PM +0530, Anoob Joseph wrote: >>>>>>>> Hi Nelio, >>>>>>>> >>>>>>>> >>>>>>>> On 12/12/2017 08:08 PM, Nelio Laranjeiro wrote: >>>>>>>>> Hi Anoob, >>>>>>>>> >>>>>>>>> On Tue, Dec 12, 2017 at 07:34:31PM +0530, Anoob Joseph wrote: >>>>>>>>>> Hi Nelio, >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> On 12/12/2017 07:14 PM, Nelio Laranjeiro wrote: >>>>>>>>>>> Hi Anoob, >>>>>>>>>>> >>>>>>>>>>> On Tue, Dec 12, 2017 at 06:13:08PM +0530, Anoob Joseph >>> wrote: >>>>>>>>>>>> Hi Nelio, >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> On 12/11/2017 07:34 PM, Nelio Laranjeiro wrote: >>>>>>>>>>>>> Mellanox INNOVA NIC needs to have final target queue >>>>>>>>>>>>> actions to perform inline crypto. >>>>>>>>>>>>> >>>>>>>>>>>>> Signed-off-by: Nelio Laranjeiro >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> --- >>>>>>>>>>>>> >>>>>>>>>>>>> Changes in v3: >>>>>>>>>>>>> >>>>>>>>>>>>>        * removed PASSTHRU test for ingress. >>>>>>>>>>>>>        * removed check on configured queues for the queue >>> action. >>>>>>>>>>>>> Changes in v2: >>>>>>>>>>>>> >>>>>>>>>>>>>        * Test the rule by PASSTHRU/RSS/QUEUE and apply the >>> first one validated. >>>>>>>>>>>>> --- >>>>>>>>>>>>>        examples/ipsec-secgw/ipsec.c | 57 >>> ++++++++++++++++++++++++++++++++++++++++++-- >>>>>>>>>>>>> examples/ipsec-secgw/ipsec.h |  2 +- >>>>>>>>>>>>>        2 files changed, 56 insertions(+), 3 >>>>>>>>>>>>> deletions(-) >>>>>>>>>>>>> >>>>>>>>>>>>> diff --git a/examples/ipsec-secgw/ipsec.c >>>>>>>>>>>>> b/examples/ipsec-secgw/ipsec.c index >>>>>>>>>>>>> 17bd7620d..1b8b251c8 100644 >>>>>>>>>>>>> --- a/examples/ipsec-secgw/ipsec.c >>>>>>>>>>>>> +++ b/examples/ipsec-secgw/ipsec.c >>>>>>>>>>>>> @@ -142,6 +142,7 @@ create_session(struct ipsec_ctx >>> *ipsec_ctx, struct ipsec_sa *sa) >>>     rte_eth_dev_get_sec_ctx( >>>>>>>>>>>>> sa- >>>> portid); >>>>>>>>>>>>> const struct rte_security_capability >>>>>>>>>>>>> *sec_cap; >>>>>>>>>>>>> +            int ret = 0; >>>>>>>>>>>>>                    sa->sec_session = >>> rte_security_session_create(ctx, >>>>>>>>>>>>> &sess_conf, >>> ipsec_ctx->session_pool); @@ >>>>>>>>>>>>> -201,15 +202,67 @@ create_session(struct ipsec_ctx >>> *ipsec_ctx, struct ipsec_sa *sa) >>>>>>>>>>>>> sa->action[0].type = >>> RTE_FLOW_ACTION_TYPE_SECURITY; >>>>>>>>>>>>> sa->action[0].conf = sa->sec_session; >>>>>>>>>>>>> -            sa->action[1].type = >>> RTE_FLOW_ACTION_TYPE_END; >>>>>>>>>>>>> - >>>>>>>>>>>>>                    sa->attr.egress = (sa->direction == >>>>>>>>>>>>> >>>     RTE_SECURITY_IPSEC_SA_DIR_EGRESS); >>>>>>>>>>>>> sa->attr.ingress = (sa->direction == >>>>>>>>>>>>> >>>     RTE_SECURITY_IPSEC_SA_DIR_INGRESS); >>>>>>>>>>>>> +            if (sa->attr.ingress) { >>>>>>>>>>>>> +                uint8_t rss_key[40]; >>>>>>>>>>>>> +                struct rte_eth_rss_conf >>> rss_conf = { >>>>>>>>>>>>> + .rss_key = rss_key, >>>>>>>>>>>>> +                    .rss_key_len = 40, >>>>>>>>>>>>> +                }; >>>>>>>>>>>>> +                struct rte_eth_dev >>> *eth_dev; >>>>>>>>>>>>> + union { >>>>>>>>>>>>> +                    struct >>> rte_flow_action_rss rss; >>>>>>>>>>>>> + struct { >>>>>>>>>>>>> +                    const struct >>> rte_eth_rss_conf *rss_conf; >>>>>>>>>>>>> + uint16_t num; >>>>>>>>>>>>> +                    uint16_t >>> queue[RTE_MAX_QUEUES_PER_PORT]; >>>>>>>>>>>>> + } local; >>>>>>>>>>>>> +                } action_rss; >>>>>>>>>>>>> +                unsigned int i; >>>>>>>>>>>>> +                unsigned int j; >>>>>>>>>>>>> + >>>>>>>>>>>>> +                sa->action[2].type = >>> RTE_FLOW_ACTION_TYPE_END; >>>>>>>>>>>>> +                /* Try RSS. */ >>>>>>>>>>>>> +                sa->action[1].type = >>> RTE_FLOW_ACTION_TYPE_RSS; >>>>>>>>>>>>> + sa->action[1].conf = >>> &action_rss; >>>>>>>>>>>>> + eth_dev = ctx->device; >>>>>>>>>>>>> + >>>     rte_eth_dev_rss_hash_conf_get(sa->portid, >>>>>>>>>>>>> + >>> &rss_conf); >>>>>>>>>>>>> +                for (i = 0, j = 0; >>>>>>>>>>>>> +                     i < eth_dev->data- >>>> nb_rx_queues; ++i) >>>>>>>>>>>>> + if (eth_dev->data- >>>> rx_queues[i]) >>>>>>>>>>>>> + >>>     action_rss.local.queue[j++] = i; >>>>>>>>>>>>> + action_rss.local.num = j; >>>>>>>>>>>>> +                action_rss.local.rss_conf = >>> &rss_conf; >>>>>>>>>>>>> +                ret = rte_flow_validate(sa- >>>> portid, &sa->attr, >>>>>>>>>>>>> + sa- >>>> pattern, sa->action, >>>>>>>>>>>>> + &err); >>>>>>>>>>>>> +                if (!ret) >>>>>>>>>>>>> +                    goto flow_create; >>>>>>>>>>>>> +                /* Try Queue. */ >>>>>>>>>>>>> +                sa->action[1].type = >>> RTE_FLOW_ACTION_TYPE_QUEUE; >>>>>>>>>>>>> + sa->action[1].conf = >>>>>>>>>>>>> +                    &(struct >>> rte_flow_action_queue){ >>>>>>>>>>>>> + .index = 0, >>>>>>>>>>>>> +                }; >>>>>>>>>>>>> +                ret = rte_flow_validate(sa- >>>> portid, &sa->attr, >>>>>>>>>>>>> + sa- >>>> pattern, sa->action, >>>>>>>>>>>>> + &err); >>>>>>>>>>>>> +                if (ret) >>>>>>>>>>>>> +                    goto >>> flow_create_failure; >>>>>>>>>>>>> +            } else { >>>>>>>>>>>>> +                sa->action[1].type = >>>>>>>>>>>>> + >>>     RTE_FLOW_ACTION_TYPE_PASSTHRU; >>>>>>>>>>>>> + sa->action[2].type = >>> RTE_FLOW_ACTION_TYPE_END; >>>>>>>>>>>> We would need flow validate here also. And, for >>>>>>>>>>>> egress, the application will be able to set metadata >>>>>>>>>>>> (set_pkt_metadata API) per packet. So flow may not be >>>>>>>>>>>> required for such cases. But if the flow create fails, >>>>>>>>>>>> the session create would also fail. It might be better if we >>> check whether the PMD would need metadata (part of the sec_cap- >>>> ol_flags). >>>>>>>>>>> Seems what you are describing is outside of this scope >>>>>>>>>>> which is only related to correctly implement the generic >>>>>>>>>>> flow API with terminal actions. >>>>>>>>>> Since SECURITY+PASSTHRU won't be terminal, this code >>>>>>>>>> segment might be misleading. >>>>>>>>> Well, I don't mind adding an extra verification even if the >>>>>>>>> create should fail if the validate fails, as there is no >>>>>>>>> other option it is just like adding another if statement >>>>>>>>> considering  the validate() cannot guarantee the flow will >>>>>>>>> be created(), other errors like ENOMEM are still possible in the >>> creation stage. >>>>>>>> Good point. I was thinking of a scenario when flow for egress >>>>>>>> itself would be optional. >>>>>>>>>>> I'll suggest to add it in another patch. >>>>>>>>>>> >>>>>>>>>>> Anyway, the flow validate is useful in the ingress to >>>>>>>>>>> select the best behavior RSS/Queue, if the flow validate >>>>>>>>>>> may fail, the flow create should also fail for the same >>>>>>>>>>> reasons. >>>>>>>>>>> >>>>>>>>>>>> If the driver doesn't need metadata and the flow >>>>>>>>>>>> create fails, then the create session should fail. Any >>> thoughts? >>>>>>>>>>> How the create_session() can fail without having all the >>>>>>>>>>> informations (pattern, metadata, ...) the application wants to >>> offload? >>>>>>>>>> Is flow mandatory for the egress traffic? My understanding is, >>> it's not. >>>>>>>>>> "set_pkt_metadata" API gives application the ability to do >>>>>>>>>> the lookup and pass the info along with the packet. In >>>>>>>>>> such cases, flow creation is not necessary. >>>>>>>>> Some NIC need to apply a flow rule for Egress and they don't >>>>>>>>> need metadata for the packet. >>>>>>>> Understood. In that case, what I proposed could be a separate >>>>>>>> patch. The ingress path is proper with this patch, but we can >>>>>>>> keep egress open for improvements. >>>>>>> What do you mean with "keep egrees open for improvements"? >>>>>> In egress side, this set of flow actions won't be having any >>>>>> terminating action. And addition of PASSTHRU won't be required, >>>>>> as it >>> will be implicit. >>>>> Flow API does not define any behavior on Egress.  We have to >>>>> define it. >>>> Understood. >>>>>> Creating flow for egress would allow hardware to perform the SA >>>>>> lookup. But we cannot remove the lookup in application, as it's >>>>>> the SA which has the information whether the packet need to be >>>>>> completely offloaded. Once this lookup is done, this information >>>>>> could be communicated to hardware using the set_pkt_metadata. >>>>>> >>>>>> This will eliminate the second lookup in the hardware. So the flow >>>>>> could be optional. The current patch assumes flow is mandatory for >>>>>> egress as well. >>>>>> For Cavium hardware, egress side flow is not required and we will >>>>>> be using "set_pkt_metadata" API. May be Radu can give his thoughts >>> on this. >>>>> Got it, what is missing here is a verification on the sa->ol_flags >>>>> and only use the rte_flow for RTE_SECURITY_TX_HW_TRAILER_OFFLOAD >>> as >>>>> other NICs are using the RTE_SECURITY_TX_OLOAD_NEED_MDATA. >>>> Precisely. >>> I'll make the changes discussed here, splitting this patch into >>> ingress/Egress >>> and use the of_flags. >>> >>>>> Do you know why such difference is not hidden by the library?  It >>>>> won't help application which will need to have different >>>>> configuration path depending on the NIC capabilities. >>>> I can only speculate the reasons. I think, application will have to >>>> know the NIC capabilities as the usage of rte_flow would be a one time >>>> configuration while using set_pkt_metadata would be per packet API >>>> call. If library is to hide this, it would incur unwanted checks in >>>> the data >>> path. >>> >>> Why not embedding all the configuration part necessary for all PMD >>> (as this >>> example is making though this modifications) inside rte_security >>> library and >>> in et_dev add a new Tx burst API with another array containing the >>> metadata >>> for the each packet. >>> >>> PMD who needs such metadata have it along with the packet they are >>> processing, others can ignore it. >>> >>>  From an application point of view, this become transparent and >>> friendly, one >>> function to set the offload request, one function to send packets and >>> another one in Rx for the symmetry if necessary. >>> >> The call to rte_flow is necessary both on Tx and Rx. >> >> The reason for using setting the flow on Tx is to provide the packet >> header fields >> which are required to identify the SA. This use enables >> extensibility. For instance, >> we could describe ESP over VXLAN simply be providing the appropriate >> rte_flow >> configuration. If the flow creation fails, then this is not supported. >> A similar use-case is the use of VLANs with ESP traffic. >> >> I understand that it is possible to use the metadata to provide >> applications with all >> information. But, a user is better served by an API that indicates an >> error when the >> control operation is executed (e.g. rte_flow) and not during the >> data-path (e.g. metadata). > I can see the benefits of using rte_flow in both rx & tx, but this > unnecessarily introduces hardware requirements for supporting inline. > Rte_flow would do two operations: > 1) Pattern matching > 2) Perform some operation with the above matched packets > > Issue is with pattern matching, not about performing the operations > specified. If we need rte_flow in the tx, the PMD should support > pattern matching in software or hardware. Since the application will > have to do a lookup in it's space to determine the SA, the secondary > lookup in the PMD may not be necessary. But making rte_flow mandatory > would make tx side pattern matching mandatory, which may not be > supported on all hardware (with inline crypto/protocol). Also the > pattern matching hardware module should be able to submit to inline > performing module for this to work. > > May be the right approach is to decouple pattern matching from actions > to be performed for the flow. In other words, add a new API to allow > application to submit a packet to a flow. In such case, application > could do the lookup and submit packet to a flow. The packet submitted > could be validated to see if it is matching the flow properties. If it > is matching, then the actions specified for the flow would be > performed. Adding such an API will allow rte_flow to be used with > hardware which doesn't have packet filtering features. > > The flow could have a "pattern item" which would say whether > application can submit packets to the flow. Submit would be allowed > only for those flows. flow_validate would give PMD the option to > accept or reject such a model. This may need some thought before we > can start implementing, like, whether we should support "submit" for > flows which doesn't have terminating action. > > Any thoughts? I think that your suggested API is more or less the intended use of rte_flow egress actions with rte_security. Would it be wrong to say that you could use rte_flow without doing pattern matching in HW or in the PMD in the data-path? Suppose that your HW doesn't support pattern matching on tx. But, you do support IPsec inline crypto on tx according to user provided pointers that you set in the set_pkt_metadata callback. The user will call rte_create_flow with some pattern, in response you check that the driver's set_pkt_metadata could handle such patterns and actions on tx. If yes, then return success, otherwise return false. The successful creation of the flow will indicate to the user that packets with this format will be offloaded. Packets with other formats will not get offload and set_pkt_metadata for such packets shouldn't be called! When using rte_flow with IPsec, it is used not to indicate that HW must do this pattern matching. But rather to indicate that software will send packets that match a pattern with proper metadata and expect an action to be applied. Software cannot expect this action to be applied unless the packet matches the pattern and the proper metadata is provided. For example, packets with IPv6 extension headers should not go through IPsec inline crypto offload if the pattern is IPv6/ESP because the next IP protocol must be ESP.