Re: [dpdk-dev] [PATCH v2 3/3] drivers: move ifc driver to the vDPA class

[Kevin Traynor <ktraynor@redhat.com>]

On 10/01/2020 12:59, Thomas Monjalon wrote:
> 10/01/2020 13:34, Maxime Coquelin:
>> On 1/10/20 1:31 PM, Wang, Haiyue wrote:
>>> From: Thomas Monjalon <thomas@monjalon.net>
>>>> 10/01/2020 10:07, Matan Azrad:
>>>>> From: Wang, Haiyue
>>>>>> From: Matan Azrad
>>>>>>>>  delete mode 100644 doc/guides/nics/ifc.rst  create mode 100644
>>>>>>>> doc/guides/vdpadevs/features/ifcvf.ini
>>>>>>>>  create mode 100644 doc/guides/vdpadevs/ifc.rst  delete mode 100644
>>>>>>>> drivers/net/ifc/Makefile  delete mode 100644
>>>>>>>> drivers/net/ifc/base/ifcvf.c  delete mode 100644
>>>>>>>> drivers/net/ifc/base/ifcvf.h  delete mode 100644
>>>>>>>> drivers/net/ifc/base/ifcvf_osdep.h
>>>>>>>>  delete mode 100644 drivers/net/ifc/ifcvf_vdpa.c  delete mode 100644
>>>>>>>> drivers/net/ifc/meson.build  delete mode 100644
>>>>>>>> drivers/net/ifc/rte_pmd_ifc_version.map
>>>>>>>>  create mode 100644 drivers/vdpa/ifc/Makefile  create mode 100644
>>>>>>>> drivers/vdpa/ifc/base/ifcvf.c  create mode 100644
>>>>>>>> drivers/vdpa/ifc/base/ifcvf.h  create mode 100644
>>>>>>>> drivers/vdpa/ifc/base/ifcvf_osdep.h
>>>>>>>>  create mode 100644 drivers/vdpa/ifc/ifcvf_vdpa.c  create mode
>>>>>>>> 100644 drivers/vdpa/ifc/meson.build  create mode 100644
>>>>>>>> drivers/vdpa/ifc/rte_pmd_ifc_version.map
>>>>>>>>
>>>>>>
>>>>>> git mv drivers/net/ifc/ drivers/vdpa/ifc  ? ;-)
>>>>>
>>>>> Yes, and more file move in docs. (you can see like rename in git 😊)
>>>>> Adjusted also the classes makefiles\measons to remove from net and to add in vdpa.
>>>>> Also MAINTAINER file etc...
>>>>
>>>> I think the comment from Haiyue was about the files deleted and created
>>>> in the patch, instead of being moved (renamed).
>>>
>>> Yes, I moved one Intel PMD code, then the patch is very small, it is like:
>>>
>>>  rename drivers/{net/iavf/base => common/iavf}/iavf_common.c (100%)
>>>  rename drivers/{net/iavf/base => common/iavf}/iavf_devids.h (100%)
>>>
>>> detail is : https://patchwork.dpdk.org/patch/64384/
>>
>> Nice, and the advantage of doing so is that git would be smarter when
>> doing backport to stable branch.
> 
> No, git won't be smarter.
> As explained below, the format of the diff does not change the internal
> git representation of the change.
> Move/Rename is just a nice formatting done by smart detection.
> 

+1. Thanks for considering it, just checked and confirmed this with a
test backport on one of the "moved" files. (btw, see stats when patch is
applied with git version 2.21.1.)

 MAINTAINERS                                       | 14 ++++++--------
 doc/guides/nics/index.rst                         |  1 -
 doc/guides/{nics => vdpadevs}/features/ifcvf.ini  |  0
 doc/guides/{nics => vdpadevs}/ifc.rst             |  0
 doc/guides/vdpadevs/index.rst                     |  1 +
 drivers/net/Makefile                              |  3 ---
 drivers/net/meson.build                           |  1 -
 drivers/vdpa/Makefile                             |  6 ++++++
 drivers/{net => vdpa}/ifc/Makefile                |  0
 drivers/{net => vdpa}/ifc/base/ifcvf.c            |  0
 drivers/{net => vdpa}/ifc/base/ifcvf.h            |  0
 drivers/{net => vdpa}/ifc/base/ifcvf_osdep.h      |  0
 drivers/{net => vdpa}/ifc/ifcvf_vdpa.c            |  0
 drivers/{net => vdpa}/ifc/meson.build             |  0
 drivers/{net => vdpa}/ifc/rte_pmd_ifc_version.map |  0
 drivers/vdpa/meson.build                          |  2 +-
 16 files changed, 14 insertions(+), 14 deletions(-)


>>>> As far as I know, this is for 2 reasons:
>>>> 	- there is no move in internal git representation
>>>> 	- some versions of git-diff does not detect moves properly,
>>>> 	  but option -M may help
> 
> 
>