From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A3C94A04F9; Fri, 10 Jan 2020 20:17:43 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8CD5E1EB8A; Fri, 10 Jan 2020 20:17:42 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id CD2271EB7A for ; Fri, 10 Jan 2020 20:17:41 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1578683861; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=tZ6ZuO0zntJX7Z7jD+BQI+xk8BQJOMJncQ5Lr3xLh2s=; b=gdE7hQVJKc/YxxEzJVz1Nxo15GUe7UbZf2T0SAqWBlo4WF+DAS11wuiul2aMr61uqSD57u EqYyFz8GSfCeyt9C/DwMG8Dx492VxGyldR0PwPmfoszMMob0SCWUB8QBXkBfb9y172L1g+ GqwbFYQJYQe+wV9QkiBPoTWzvKif19g= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-387-0Ykpz4b8MXuLmbZbfgC3Mg-1; Fri, 10 Jan 2020 14:17:37 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0C57C593A0; Fri, 10 Jan 2020 19:17:35 +0000 (UTC) Received: from [10.36.118.48] (unknown [10.36.118.48]) by smtp.corp.redhat.com (Postfix) with ESMTP id B4A6E1001901; Fri, 10 Jan 2020 19:17:15 +0000 (UTC) To: Thomas Monjalon , "Wang, Haiyue" , Maxime Coquelin Cc: Matan Azrad , "Bie, Tiwei" , "Wang, Zhihong" , "Wang, Xiao W" , "Yigit, Ferruh" , "dev@dpdk.org" , Andrew Rybchenko References: <1577287161-10321-1-git-send-email-matan@mellanox.com> <1762954.eGJsNajkDb@xps> From: Kevin Traynor Autocrypt: addr=ktraynor@redhat.com; keydata= mQINBF2J2awBEADUEPNhgNI+nJNgiTAUcw4YIgVXEoHlsNPyyzG1BEXkWXALy0Y3fNTiw6+r ltWDkF9jzL9kfkecgQ67itGfk1OaBXgSGKuw1PUpxAwX2Bi76LAR6M5OsyGM9TSVVQwARalz hMwRBIZPzPc7or6Pw7jAOJ8SQGJ1Zlp1YJCjrvpe87V1tH/LY8Wnxn/EuoseFmWILAQZAtYS tGjcrAgYn3SPMLR1B0BP5bTBY06vWQjiufH8drenfDnMJAzuBdG1mqjnTqCjULZ3Hunv4xqZ aMnkvL/K5Tj1c12Oe4930EE53LrXIBUltRg5mBudSWHnC7twjH0082HH9f963Z/2UI63SFIT iUvRvAzJYytgy7XnWLQ0+goZBADKYfolOuC0H8VgCaux8u8KFF28Dy+N6TV2KI58jTlyg1Zu l7QwykZpnOkJFiy37Gfbu3YEOzO72cP/S7/A+zvuqkxi63jyEkd+FY99vLt/HN2MUZwRmKDw UPbLkmrs8WU01/POVsqDcfvz7vu2St8hqqTiSIdQGS2zyTKB2/DvPSM3jws3udkIYSuhn+X4 QBiV6lkVZ7DSE6a065gnAauAql+b32Eymy+xnG5jCt1tR+0Cp2VZYCR9OU2gmomUKBDoX/He pSgED01CqYPNjN+TddirwmQX7ep4DtXc8FWvv2g/pq9WZFQk2QARAQABtCNLZXZpbiBUcmF5 bm9yIDxrdHJheW5vckByZWRoYXQuY29tPokCTgQTAQgAOBYhBAoiOaH51tHF7VYtEI9CINER a+yJBQJdidmsAhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEI9CINERa+yJoxIP/3VF 2TIgW4ckxhRFCvFu/606bnvCPie88ake4uWVWMAWwcMc4fKEltRWRCpkSVOwgqoMHnyHxK5r kOKzx2CLJMX5TgTMfKzPuaBDHngHLUzl2DStpBzrod0cVg5TShdmmfjY61uxRJKz+DlSkwgJ riADdVF5PPosQXTkKSGf2ombpTGpx/pue9ocjnr3x4SDpRLlnooM6Jf/3Y3Ib4jX6HPEyWuY b+owIIk9y2nRRGPQ6jbqAhsrXd9V+77UL0QuGWloMuKMZFbNg8hbu7X5aFijAbfxj4YUgojS ba7gfGZQan8h32A9KGQWrmsCBc3j2GqEPsX0r05X7cn7WL6IOPgQJ5EiQ7PlazQYVLrvZg9B n0GKK0k6895mLG0ZZ5v/qajOPF52etSmvFD1WUPb4OqaHqGA9ZtMpaKFRt7Y6rpXqKNU1xzW F5KjbTPtTb9WF3An8dciVv+AYUI7totkZYkWvQtgss8lfaX3NKUvXLVxqK0z3dQyr7rF/tYz PneTKypSksjCgaEBLSrsRmM5zKfe7tSNF/fDntfIq/029Jtcw29TcWEP57peNu6TtejewQD9 sTI+oqiXvW2D5l7LNUDYG8eMJp2oT7I0ZSBRvwcbmjH0DtN/bXCCFfCvk8Yic68F3tV1ctix wQARVKDBhT30uCxycRWojCYqTgNJJS71uQINBF2J2awBEADP57PR2IpSYBeNSrsAjeIcsahE N4SQP2C4s50S8QEWAUhqMRI7WNv5cfeef0nDvcl1IUA6oz5SokbcsbMa+mRgaNF4N5KikWTO LPYxq2YVJoXwJ+tKmNzyOLFUIfFJ4NBJZple5dTfWzD00Dbb19Mri1hy1mWMqNTPGBee1+hw Qcp6n3mmGECvajs8G5A7NyXbwL8ihN7HX9D01ucD62b4G03yKe2g/hvKgcdUVmhCldJlF27I 2fSR9tDxH9pZqRODY4rjbFZEey/vWKXqjE+DQ8AtMSEaDfFe5D+i4Aw6erWQ3Wr+DwZt1/7G dIAElGA/q90T1ENVwJX9y7fsQssawKYYdDqURHCl5JuDXI+VXUypExipUUT5SPycMmbLsx0D iKEqPPDQWKxkIDVKqj2+EhamSuJznZUwBLJKn0h4zrIWiXWUy07lRwtVuhaDXhF3GfW+5W/x wAg7Qg3w00ASsb/XTHBIhMnenKDfS7ihtQA8SacwX8ySdxb+15XPyiplM979qBQ0mhnilulm MIJzEf/JxoYR5huuj4f1PFqqrsP06Dl+YGB7dQZp3IKggS5c3/TAynARRg9N89UsDXNtp7X0 tgIPFF5k6fnHE0J5O64GYHeTqN/1aE6dAEOV9WrGzQAJxU9ipikb8jKAWXzLewRIKGmoPcRZ WdB0NmIjmQARAQABiQI2BBgBCAAgFiEECiI5ofnW0cXtVi0Qj0Ig0RFr7IkFAl2J2awCGwwA CgkQj0Ig0RFr7IkkORAAl/NbX93WK5MEoRw7/DaPTo/Lo6Pj1XMeSqGyACigHK/452UDvlEH NjNJMzYYrNIjMtEmN9VVCfjT38CSca7mpGQVwchc0mC7QSPAETLCS+UacVf/Kwxz5FfkEUUw UT7A+uyVOIgW3d9ldlRzkHA2czonSSgTQU+i2g6DM4ha+BuQb4byAXH6HQHt/Zh1J64z0ohH v6iGsCzCY/sMWF8+LEGSnzMGRCLiiwSF0vJBHbzWK68fANaF4gBV0Z/+6tQRFN7YMhj/INmk qgvHj1ZzHFNtirjMGPRxoZs51YoLQM/aBPxKrnmXThx1ufH+0L6sGmFTugiDt0XSEkC5reH7 a+VhQ1VTFFQrClA8NmDSPzFeuhru4ryaaDHO+uEB16cNHxHrQtlP/2hts2JM5lwkZRWJ5A57 h8eDEIK5be47T85NVHfuTaboNRmgg1HygVejhGUtt69u/0MVRg/roUTa0FyEbNsvz4qAecyW yWzMcVrcGJDQLC9JLKEpoyUF6gdTKaiDL2Vao4+XRIA3Y57b6MO35a3HuzAv7+i5Z0mnDEJO XxXqTOmKYpMIGexzM/PtuA0712sT1abG9tAJ17ao/B7cqMW5IkKkalemFbWfI2unns4Papvo tk9igVqyp6EJDU98z5TJioCVojwK2laDaoIjTJk9YYv3iwCsqPd5feU= Message-ID: <3a921f8c-2744-2329-ead5-dc963cb2288a@redhat.com> Date: Fri, 10 Jan 2020 19:17:14 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <1762954.eGJsNajkDb@xps> Content-Language: en-US X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-MC-Unique: 0Ykpz4b8MXuLmbZbfgC3Mg-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v2 3/3] drivers: move ifc driver to the vDPA class X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/01/2020 12:59, Thomas Monjalon wrote: > 10/01/2020 13:34, Maxime Coquelin: >> On 1/10/20 1:31 PM, Wang, Haiyue wrote: >>> From: Thomas Monjalon >>>> 10/01/2020 10:07, Matan Azrad: >>>>> From: Wang, Haiyue >>>>>> From: Matan Azrad >>>>>>>> delete mode 100644 doc/guides/nics/ifc.rst create mode 100644 >>>>>>>> doc/guides/vdpadevs/features/ifcvf.ini >>>>>>>> create mode 100644 doc/guides/vdpadevs/ifc.rst delete mode 10064= 4 >>>>>>>> drivers/net/ifc/Makefile delete mode 100644 >>>>>>>> drivers/net/ifc/base/ifcvf.c delete mode 100644 >>>>>>>> drivers/net/ifc/base/ifcvf.h delete mode 100644 >>>>>>>> drivers/net/ifc/base/ifcvf_osdep.h >>>>>>>> delete mode 100644 drivers/net/ifc/ifcvf_vdpa.c delete mode 1006= 44 >>>>>>>> drivers/net/ifc/meson.build delete mode 100644 >>>>>>>> drivers/net/ifc/rte_pmd_ifc_version.map >>>>>>>> create mode 100644 drivers/vdpa/ifc/Makefile create mode 100644 >>>>>>>> drivers/vdpa/ifc/base/ifcvf.c create mode 100644 >>>>>>>> drivers/vdpa/ifc/base/ifcvf.h create mode 100644 >>>>>>>> drivers/vdpa/ifc/base/ifcvf_osdep.h >>>>>>>> create mode 100644 drivers/vdpa/ifc/ifcvf_vdpa.c create mode >>>>>>>> 100644 drivers/vdpa/ifc/meson.build create mode 100644 >>>>>>>> drivers/vdpa/ifc/rte_pmd_ifc_version.map >>>>>>>> >>>>>> >>>>>> git mv drivers/net/ifc/ drivers/vdpa/ifc ? ;-) >>>>> >>>>> Yes, and more file move in docs. (you can see like rename in git =F0= =9F=98=8A) >>>>> Adjusted also the classes makefiles\measons to remove from net and to= add in vdpa. >>>>> Also MAINTAINER file etc... >>>> >>>> I think the comment from Haiyue was about the files deleted and create= d >>>> in the patch, instead of being moved (renamed). >>> >>> Yes, I moved one Intel PMD code, then the patch is very small, it is li= ke: >>> >>> rename drivers/{net/iavf/base =3D> common/iavf}/iavf_common.c (100%) >>> rename drivers/{net/iavf/base =3D> common/iavf}/iavf_devids.h (100%) >>> >>> detail is : https://patchwork.dpdk.org/patch/64384/ >> >> Nice, and the advantage of doing so is that git would be smarter when >> doing backport to stable branch. >=20 > No, git won't be smarter. > As explained below, the format of the diff does not change the internal > git representation of the change. > Move/Rename is just a nice formatting done by smart detection. >=20 +1. Thanks for considering it, just checked and confirmed this with a test backport on one of the "moved" files. (btw, see stats when patch is applied with git version 2.21.1.) MAINTAINERS | 14 ++++++-------- doc/guides/nics/index.rst | 1 - doc/guides/{nics =3D> vdpadevs}/features/ifcvf.ini | 0 doc/guides/{nics =3D> vdpadevs}/ifc.rst | 0 doc/guides/vdpadevs/index.rst | 1 + drivers/net/Makefile | 3 --- drivers/net/meson.build | 1 - drivers/vdpa/Makefile | 6 ++++++ drivers/{net =3D> vdpa}/ifc/Makefile | 0 drivers/{net =3D> vdpa}/ifc/base/ifcvf.c | 0 drivers/{net =3D> vdpa}/ifc/base/ifcvf.h | 0 drivers/{net =3D> vdpa}/ifc/base/ifcvf_osdep.h | 0 drivers/{net =3D> vdpa}/ifc/ifcvf_vdpa.c | 0 drivers/{net =3D> vdpa}/ifc/meson.build | 0 drivers/{net =3D> vdpa}/ifc/rte_pmd_ifc_version.map | 0 drivers/vdpa/meson.build | 2 +- 16 files changed, 14 insertions(+), 14 deletions(-) >>>> As far as I know, this is for 2 reasons: >>>> =09- there is no move in internal git representation >>>> =09- some versions of git-diff does not detect moves properly, >>>> =09 but option -M may help >=20 >=20 >=20