From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E5ACC43B01; Mon, 12 Feb 2024 16:05:32 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A18DD402D9; Mon, 12 Feb 2024 16:05:32 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2048.outbound.protection.outlook.com [40.107.243.48]) by mails.dpdk.org (Postfix) with ESMTP id 2B82A402D0 for ; Mon, 12 Feb 2024 16:05:31 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DEDMcqFntvN9pQjLNU2Zw1Gnec0r1hHVeD6A9XdNkMPkbwvkv3nL5sz1vZjR90sthNhq5AOuAFhx4OHUjkwhpUubvS5G1Z4EV8A0E1CBe6p/A/ki4F8YKdZk0JQYSi2N6xotHmSCwFLvo00yplpfSfvN1XbReIFXJQA/FIJ4LIdAtztxP0M1dix04mhGEo+hsesr6tD5qWPkaAiK5bvE+ic76TAUESsgYoJFJ7G7PRnqY3WNAgYPlr05UbhE3jTHeKwQuFzWjsHVXkLaAr4xrpiYWMTqpjaQI8MIquQhNaXdX4ePgrw1HlP12mLSZh+11KpJatnNuEEza2k+uY3Ngg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Xv+jX75c4d6x8vhV2J4HUnCiF/Rmjrq85kKqwksnDX0=; b=LK95uHt+wyd+S1e5bqbP5QVmord0vVWfNQ1HcuDAUokloU7lynuWV5LFztXWO3EJLbjuFen2R2eglk/Fn+tDYuWzrC6Y8g3VaPjNsci0N2ozNBjPwZqckIbcjlv/dNOp13/k5s3bZpaKYB0ehSmlwa0OdP8K48R2NX1/u2WQua4O0kSCY9bZqWDqVZjAUdajxnUp+xUTsPyZaQhANBuI+1s9VMo7oOtOSV09tKRK2vkg5ynBjkPxKsCaJZcO1drXVs8md5oL8VfZ7G4iRfz7N183qzobXAqZMNXLNxvDJf3d/qU8S/IG1sxlcoC6dPcEXs5+iAW0DjazaDwDXD5rjg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Xv+jX75c4d6x8vhV2J4HUnCiF/Rmjrq85kKqwksnDX0=; b=AIND7uRtqEzHOx26TC0NabUyDPhQBVGw1uS8K65TUj6soakb5IcAX6JHDyREATbdpwWY+DmL8s7zXoP9tdG+cfolkGmCsS6ugGonyRBIVfa953o74FYZJVEI/cbkmDIFqI8Z+95awyKnXP+gHxDeUOgGlfz0SPUWdjwUX/SaDB8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by DM6PR12MB4482.namprd12.prod.outlook.com (2603:10b6:5:2a8::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.25; Mon, 12 Feb 2024 15:05:26 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529%4]) with mapi id 15.20.7292.022; Mon, 12 Feb 2024 15:05:25 +0000 Message-ID: <3ac2323e-da6a-4af5-8851-932974ffb769@amd.com> Date: Mon, 12 Feb 2024 15:05:22 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6] gro : packets not getting flushed in heavy-weight mode API Content-Language: en-US To: Kumara Parameshwaran , hujiayu.hu@foxmail.com Cc: dev@dpdk.org References: <20240117195228.423261-1-kumaraparamesh92@gmail.com> <20240211045511.1221879-1-kumaraparamesh92@gmail.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20240211045511.1221879-1-kumaraparamesh92@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0279.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a1::27) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|DM6PR12MB4482:EE_ X-MS-Office365-Filtering-Correlation-Id: 67ac9235-5da0-416f-911f-08dc2bdc0aef X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qTVceWc5ACuwgpUc7mmmv947rBX+xRxYDiyo+VxuUtghEYcYMP4se3LqTcN320rXGsTBoHw8wE+/UgRUbIkKY+CKBC6muaveb3ZP1z8v7HXnxQGoMbKSDojT2KME+sASa+i9uKWg/raOSTrtERpYM/N1uVD+iYFhFBSOzXLEpednee4+RpICP4TvErG0foeBydyqc4jArk30PS8qSN8QHaA13vUDCswGagYaJmxKB5NkddPkZoxnoV2iM9oOlEtsjU038RXZlO7rtRY2HA3hO2Ox8qMb+nATjo63s1b0Ieq1iMrGbTcZkt43lznYoZo8V7yU7tnSroTrzyD6nsFH3SnwVc/fYs25veq9Voq6OJyjZMUWXrVdjPKJDUoxRdNrs30QhVj8gFXktjLMq5kHDCBzgd3RKu6vqYIze8QawQ+X/HCFz1FgAvSddbSKtD4paCsghvJEDK96QXh/0QjFON4WVwM2laFfW0zni4jshWzXssFu3RvyBNWqEpPS4+3ld8QnnNOzXbuciz1YymNYY186cOKZ5NStYQG/ncaxKQnyRvZy9z2T7VSjIhm9HK1V X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(136003)(366004)(396003)(39860400002)(346002)(376002)(230922051799003)(230273577357003)(64100799003)(451199024)(186009)(1800799012)(36756003)(41300700001)(31686004)(316002)(66476007)(66556008)(66946007)(86362001)(31696002)(4326008)(8676002)(8936002)(5660300002)(966005)(6506007)(6486002)(6666004)(478600001)(2906002)(38100700002)(2616005)(44832011)(53546011)(26005)(83380400001)(6512007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VnJJUlcxbHVvc0ZQZ3lSNU5LTldWNjE4cTd0Y0JONVpXdlRMTnVxenNjbHps?= =?utf-8?B?ZlFZWVpKMCszN29tb3RKdVErR2NwMlRZclVZU1p0bFRmcjBPRzFnK2dQVThG?= =?utf-8?B?QkpaaCtrVW5tNytCdGJoRFgwRXFqbW9OeDNGcnMyNjdTZlp4cjN4am5pS2ZD?= =?utf-8?B?ajFyRFJ0R01JYmxWQmZXT1FTWEY3NGx0QkN2VzdMSGhvcHdlMmdCYVVPSVF6?= =?utf-8?B?c1liMmROWENUQzljbnRaazBRdFI0NHp3VzlaMVEzUjA5STVpVWVlTG4vRTlE?= =?utf-8?B?VGhOekFCVVBpcUhhc2tJWkZuZ1NvdlRoL0xxWDIwdkxuTnQ3MnhSL01yd2dz?= =?utf-8?B?VWZ1bWZCVmxOZzk3WjRENDFlMTBtY0dRRWVUY0VERThoQ2xtbjFONnFuMFNv?= =?utf-8?B?cHZ1VWFYZDhhYzE3OUZhQzI3MmJCZEtsWW5JOU5taFVnK1pBUUFNUHc2Y0pq?= =?utf-8?B?U2p1R2RIZllIS0o5QnpaZzVzb0twTFREcWdyK3ZzUzhENldWaDkxNlFpbXNt?= =?utf-8?B?anNxVitKZ2FmT0ErM29vcEVzbCszM0ZreVRwNnFYSk1zU0ZKMHRhRnExL3dP?= =?utf-8?B?Q2JoN0J6MjE5dGVPbVd1eWt0K0grSDhFamp6aVl6alVaaGlDK0h4dHN1Mllv?= =?utf-8?B?QmdXR3FSR0JFaUpHYW1vSC9jeTBtRGpwMmhoeXIyZk5CRjZYeXF5ZTNoTktt?= =?utf-8?B?MFgrZGgzZUp3bThwaDI3dWkrZi83ZmdVMEVQemZ2cGJkcEtNc1J2dkU4QWgx?= =?utf-8?B?TVY3Vno1ckJGY1cwR2IveUxxR0xLbWRDWnVGcDI0bUUrTkNmdmw0Z3R1cWJN?= =?utf-8?B?MTFKam16UmVNNHpITHR5RVFEVGdUNkl6UVV3NVF1Q1J5b25Nc25NVFk0S0tJ?= =?utf-8?B?cm41UWkrbGJMejhJOU9OWkRSZ0hGTUQ2WVRLT01sditBM1o1eEx2L1BDWEZK?= =?utf-8?B?UTFncTZEZG1HY0Z4QlJScVVUNWpUQnQxckhBTFg0SURRaDNwYS9QREdIc1du?= =?utf-8?B?bnBjRGdaVThrQXdhZlJ4MWhsZDRLVE1xeUtMN0ZVL0tjVTVnUDNNQjJvaTZJ?= =?utf-8?B?T1ljR0c4QytsREZpckRZeU5DSldmbjEyd0RXbzZvZFZXcG96Nm1OYWRIazJx?= =?utf-8?B?TmRRZWxRaWlleVk2NXloM1BldU41MzJCUlh5SHhiaE9EeHBxZWF5WndrU1l1?= =?utf-8?B?M3ZMR0VUanMrVUtZTkJRdUkrVTdacVUwaWJDZDN6djlXQ2FXbGFFQXRZZHVz?= =?utf-8?B?bk1WRnQydWNhWDBjdW9zZlNZMllxdmd4dUFHdjJUdkdLRDI4U3ZyR3VLVkZL?= =?utf-8?B?TDNqSzd5c3BEVkFGTWhNSVI5QWRZekpQaStPU2s5anJlKzd6KzdHakhiSmJU?= =?utf-8?B?YUVZWmhFQnRJa0YwL1dGbHJ0ek55UUd1TGtpcFFjZnBqcnZCWkt2RldPTStK?= =?utf-8?B?UWR1M3VSQ3FqRVFOUEdvUFRBR1lpMkNVK0NHb1NtK1dOMW9aVE9iSFFQQVc2?= =?utf-8?B?SDFsZ1h2RnRiTy85aDlJVGZLYzMxclRLdzdzbDVzOUFBcHk5Y2NXRUZwdkpQ?= =?utf-8?B?ZSs0bFhvUnFBWTlzQzhpWXJHMldpQkhMaEdnRWRoZVMvUmsvTmlKL2E1bmdP?= =?utf-8?B?ZTBBS1RLN1lITXJKRHhvdjcvWWZZUytRRWprZERJN0ZTTmpmNXdzRkxTcXhw?= =?utf-8?B?WnlHS09TREFyYXFsb0xjOCsza1Z2SmRleHhVVUIxU052S2NkZ2EyeEhCa3gv?= =?utf-8?B?dkZBWHc4WE5uTHQxZGFCb1d6RS9xUmtDRW8wRE5sZjY3Y1NZTlJEZ21MMnhq?= =?utf-8?B?aGpVRmtFTjVuRXhoTzMzTEpJem1XQXdsaS8yOG9uVlROY2pRN1ZCeC82R2JV?= =?utf-8?B?OEZkQWNXVVJmZFFFWXpWKzg1K2VuSHZLQ1cwZEl5REdlQ1hhVzdheTJ6ZlBK?= =?utf-8?B?ZnJhMm8yUkVDMTE4MzVQMFh0M3NaVTZNTTA2VzlGU0xqWWdDZ0NBcUJjYm4r?= =?utf-8?B?cHk2TUkvN29vZW5IWXp3ZFRITXJRT1ViUy9qRjZFeDM0K24zK2hsaVE3MS9z?= =?utf-8?B?MEY4bnRhZG5aZ3laRlYwTlFoUks5VTZZanVHVEI0Zm1FcVhEcU1waDB0UEZM?= =?utf-8?Q?F6/psz+pr0O8XVow6H4PaT12e?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 67ac9235-5da0-416f-911f-08dc2bdc0aef X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Feb 2024 15:05:25.8483 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TizxJu88Wk6wKps9h4fqvFUDE6eQUMJ5BTF0tQmAI3+55sUC8NmR+cNeMYKQUhp3 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4482 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/11/2024 4:55 AM, Kumara Parameshwaran wrote: > In heavy-weight mode GRO which is based on timer, the GRO packets > will not be flushed in spite of timer expiry if there is no packet > in the current poll. If timer mode GRO is enabled the > rte_gro_timeout_flush API should be invoked. > Related to the patch title, 'gro: ' indicates a component for gro library (lib/gro), but this is a testpmd patch, can you please update it as: "app/testpmd: ..." And can you please add a fixes tag [1], so this patch can be backported. [1] https://doc.dpdk.org/guides/contributing/patches.html#commit-messages-body > Signed-off-by: Kumara Parameshwaran > --- > v1: > Changes to make sure that the GRO flush API is invoked if there are no packets in > current poll and timer expiry. > > v2: > Fix code organisation issue > > v3: > Fix warnings > > v4: > Fix error and warnings > > v5: > Fix compilation issue when GRO is not defined > > v6: > Address review comments > > app/test-pmd/csumonly.c | 14 ++++++++++---- > 1 file changed, 10 insertions(+), 4 deletions(-) > > diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c > index c103e54111..21b45b4ba4 100644 > --- a/app/test-pmd/csumonly.c > +++ b/app/test-pmd/csumonly.c > @@ -863,16 +863,22 @@ pkt_burst_checksum_forward(struct fwd_stream *fs) > > /* receive a burst of packet */ > nb_rx = common_fwd_stream_receive(fs, pkts_burst, nb_pkt_per_burst); > +#ifndef RTE_LIB_GRO > if (unlikely(nb_rx == 0)) > return false; > - > +#else > + gro_enable = gro_ports[fs->rx_port].enable; > + if (unlikely(nb_rx == 0)) { > + if (!gro_enable || (gro_flush_cycles == GRO_DEFAULT_FLUSH_CYCLES)) > + return false; > + if ((rte_gro_get_pkt_count(current_fwd_lcore()->gro_ctx) == 0)) > + return false; > Why not "||" this condition to previous if block, instead of adding a new if? > + } > +#endif > Can you please put a comment in the GRO block that explains why these checks are done and why we may not want to return although 'nb_rx == 0'? Another option is make the block as below and keep the code below to get 'gro_enable': ``` if (unlikely(nb_rx == 0)) { #ifndef RTE_LIB_GRO return false; #else // Comment explaining what is done here gro_enable = gro_ports[fs->rx_port].enable; if (...) return false; #endif } ``` Above sample that keeps the #ifdef in a narrow scope ("nb_rx == 0" block) looks tidier to me, but both works fine, no strong opinion from me, what do you think? > rx_bad_ip_csum = 0; > rx_bad_l4_csum = 0; > rx_bad_outer_l4_csum = 0; > rx_bad_outer_ip_csum = 0; > -#ifdef RTE_LIB_GRO > - gro_enable = gro_ports[fs->rx_port].enable; > -#endif > > txp = &ports[fs->tx_port]; > tx_offloads = txp->dev_conf.txmode.offloads;