From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 21863A0093; Thu, 10 Feb 2022 14:22:40 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0F728411AE; Thu, 10 Feb 2022 14:22:40 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id C56AA4013F for ; Thu, 10 Feb 2022 14:22:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644499358; x=1676035358; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=kH05Cqh9bCRKoHljSejtH79wesoW4kdBgr4t7gJR3PM=; b=U3xwxuJPUtpzeeMwYzeWDzaVz0+iEhPTrTdzBq+Yz+D+3JXScZ0pppnT dPriIiC7Uiwhb2zQhU0vYaJ1gY9rznwcWF7BaEr1EpT3l9ZiJUous+0fo VqAE62NyL4jFGxpnikVUrVJ34QUkp6Z5IWxMHV1PR4N+OdaBcEH4uNmd2 pOWZkn+F9E22+0U2bFdJG0YlZKKG53KfSFud0EVsUM8GTHC457tBJYj6Y GZCrBM6W1FIkmyCNo41DiYT3Xfu/xlMjEHqzDDydPjq2b4JibpsZDF0RE U4g1Uejfb8kY05J6tMxviDstoFKypFCVow6i8WrnNMjjbNgR7CCHR5A5X Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10253"; a="310226327" X-IronPort-AV: E=Sophos;i="5.88,358,1635231600"; d="scan'208";a="310226327" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Feb 2022 05:22:36 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,358,1635231600"; d="scan'208";a="585954620" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by fmsmga008.fm.intel.com with ESMTP; 10 Feb 2022 05:22:36 -0800 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 10 Feb 2022 05:22:36 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 10 Feb 2022 05:22:35 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Thu, 10 Feb 2022 05:22:35 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.170) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Thu, 10 Feb 2022 05:22:35 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=b/j+dnkLbbBM3ojOOD9VSTCRENwkg56GPwKTW/jUIQLxuGrGIczXIf9jap6usuhPlXbgRK1IFxxOsnauShvShQrvPzmZ58j+GdtRsTQNtll91Hmf8qVwlqxrL24UPXzotsHGTkyxzuvHtfpu0/tZs4vmnGMVN1DzOu55M1Q2KF9I+meXzzqgUihuXkPwCJe+2l3vTVBD0QtphO13z5VpaVxwEqXuDPLfVelQg7FpEasYltlgJRA49WmPdThtisoGNlO92Apc4OwXWUh8+zQXOVwaFBVfZ2JM2aPNpGBomam3ZvnjVhP7iLssEkIMOBzKDrJbBPZXUwEbII4Pn0QHTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vfXCdR/HBy6zDOzPYZOHFQy9edo7Ogo5WeV9XZR5lt0=; b=U7tprVKxONfgyJ9LZrzZjszvXZPdrPLps295rhUSaTS1yhsbAxsmxyiiIQ81dwwOvjEmH+hSjkWgq0Ii6ssNltjfmOlFBbPof88JwaNMM5x0ED/yBqtPd1yjQZewUtcgYrdEx5KanZ2uCeHYEhnXoFes8wJnkRm2xWA1K/GKdglC659zTQjG0hHk8FmeQkIbs2i4MZcF0HcnqGCu0lxtqe3ozzSXTNevnfHrN7buX25DbFhaFL75fbiSYfSbDn48TCgGG8F/2e0RCh3IvwdmN+Dk+6cjTQ/1Tkk2gFubaoNDBhFPo9Bxvyi9n8wsC6XI2ZWjP/H0pemVev5HbhKSgQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by SN6PR11MB3343.namprd11.prod.outlook.com (2603:10b6:805:ba::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Thu, 10 Feb 2022 13:22:34 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2%4]) with mapi id 15.20.4975.011; Thu, 10 Feb 2022 13:22:34 +0000 Message-ID: <3aca3a4c-3703-221b-ab88-524030ec18ab@intel.com> Date: Thu, 10 Feb 2022 13:22:27 +0000 Subject: Re: [PATCH v3] ethdev: introduce dump API Content-Language: en-US To: "Min Hu (Connor)" , CC: =?UTF-8?Q?Morten_Br=c3=b8rup?= , Ray Kinsella , Ajit Khaparde , Thomas Monjalon , Andrew Rybchenko , David Marchand References: <20220111115437.32855-1-humin29@huawei.com> <20220209012106.23404-1-humin29@huawei.com> <60e29397-888b-0132-25b9-e9d470be3a5d@intel.com> <860bd211-e9cc-fb91-a6d5-553172f128d4@huawei.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <860bd211-e9cc-fb91-a6d5-553172f128d4@huawei.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0023.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:151::10) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 633e8e38-8f55-4b52-fcc2-08d9ec9865b9 X-MS-TrafficTypeDiagnostic: SN6PR11MB3343:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jpUPD+/CQaeCthezzqTid6OjX+rBw0hU7pZXgg6zZQi7Cfc/MAty8jhxMoK8c9U/y/U12VllvbXdpZLqIdLqqe4s8pO0WZ87l2QmLv+N2qLdIeLlhtDSk0UtjieQjuOpp4Z79RdVbG2RiAkgYotCENUFYRzc+o8Y8RjXls0gayGvRMr34Q0GWNev0CIVmSs1gdLYSJs7WCQPIfg+OCQZZC4my+W7TdKBX06iNhvuH7nab2oupvU3zdkuIYwDltXFHyxjMLsHf0Ttpnm80yKkkvkRJZzHivMb3JhqgRLgkIz0Oyhvyp/107Hl8eNCRhDUN9jJZr9qSl396h8e1Iu6Rs2nZXOtPr8AX4jpco678471xcItpArHTP46eZWZ5x0BFLjSMripWAeKZm2um6SHtLYszl19tkzJQAa61EF9ImrjNY0gdDB70qD6LnuQ1vP7vEHHZHIHyTKaRZ+WP+EmPDwYlj60tQsXR0YQNAbTQMPfcUflxifLgeYtOLd2qNPBI7zSYFZ6qBeWfm/lHLjJfEcr2P1n2a4ZBBuIHNnzEMxD6Kc6x1xE91Ve4hvl9qWyFxNfW5KcNjF8wvsIRmCG1ILnyCUaqVTiZcfVyx08FcSB1PU4JBz4tlzvW/JhXb4VsUdkKQEpZYLZosRHqg1J7MNsxdRrGl/++Kufw9UOL+jRyKAma7u6QbozhvTBuTwNh/f+i+salq5MrumA0lFNBQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(44832011)(53546011)(66476007)(31696002)(6506007)(4326008)(508600001)(66574015)(55236004)(8676002)(66556008)(8936002)(6666004)(2906002)(6512007)(66946007)(82960400001)(83380400001)(5660300002)(2616005)(6486002)(316002)(31686004)(186003)(38100700002)(54906003)(26005)(86362001)(36756003)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NW8vSkptNHJBemd2K2xLc3ppS1cvbklZbHFYZk9RL2J2TVcraTRMaXQ0RUZK?= =?utf-8?B?L1VyemN6UUZhKzBIZG5tSEtCT29KTUs1alRtdmxCanU3QjZRd2hNQWw2S2Ix?= =?utf-8?B?aVZKc3ZkNlFpd2FkbGRXRi9mdWpsNXZkZUpsTFcrM2tFcHc5STQvenZKTW9J?= =?utf-8?B?ak0yR2RxUEJYRTRNNFJLamZQVFMzamJCNXZwZmt6V1psSkdNVnBDc1ltaGFW?= =?utf-8?B?bEhzczdxZDA3NDB2TEVFR0xEWVExdnpqaFB2akRnZzh4bHdHU2o3Znc5bkpZ?= =?utf-8?B?d0pYUlEzU2JuR1pvYlc4ZUxrNEhCd29pTUZvdmxxUW9qbUhOSENMaXgxb3Rm?= =?utf-8?B?YjRrNTVocWQvTVorbXpIMlhNcUdVWEJlTW5lQ2RwZHE1akprbTVYdEk4RlVX?= =?utf-8?B?Z2l0UHRLK3RRZ2NRWWMrWldlWjZZNWxCb1lqa2ZJc0lLU1drZlAyWGs0eFZM?= =?utf-8?B?bUZBVXlmZDBJMUg0VUYzVkwxYnZsS3BDd2NtSGdnZTdQQTZnTzJBYm54M210?= =?utf-8?B?RVdSRE5HN09tNFJtd1lsdWtDMEk0MjB5QVAyRFhyL1F2cGszSnNtMmxmRlpl?= =?utf-8?B?ck93eCtEd0NCTHFRWlc0b3BtVWdqR2xpc3BzV2pBU1lReERCZ0ZkTE54MHZ5?= =?utf-8?B?VjVxN1BaNkNKcWVCZTVwclZkNDRmdVVRd0tmZ1JUNVQyZWxqSGw3dTlXd0Zw?= =?utf-8?B?T1grekV6akVXcFNWVHUyK3paTkExSjU3NVhON0M5RUVGTkF4R3orL2x4Vzda?= =?utf-8?B?bjQ5OXVESXVVOHFGR1dUUGJTYjBLQ2duVHp6ZDdhZXFXK05Ta0YwQlRJZVBK?= =?utf-8?B?ZEcwZVRsY0UrVFMrMkhjUnVucTBVZ1QrZ0NYbER6Z1gzb0E5YlVLL1NodHl2?= =?utf-8?B?dGgrdWRLbWRacHlCTndMczNzNEdScURNZE1KQjY5OSt3N1B4UjJNVzUzdUhZ?= =?utf-8?B?VVVjRmd3OGpndDhKRExQYzhlTnJpWjFFbDlNeWxBZGcvdHVTSmUxNnVHWlNr?= =?utf-8?B?VTVETTl2WTJPdFhJcW1WeUI3ajZUdHZkUlFWT1J5cWdHcTRvSTJiSlpETVZE?= =?utf-8?B?UVNEclIwYnA4ZEJObUVYUGtOcFhRVm9rMWxxTnRVMDRLYk5Pd3h0Y3lITUt4?= =?utf-8?B?VzV3OVlnZjVaMFhFU1dsejMyWU1vQ3RZcWdUZnlCaVF0UXNPUENxbEgvMGhL?= =?utf-8?B?UzJ2d2pQbHl5OVpLZ3dkZUZhaHRTcmg5bmdxb1hlN0ZmcTlyR2NGeTc2emxD?= =?utf-8?B?T2hUbC9aYmpXOHNwTzRncTJiVlVMOUQ0VjVuQzFZYmJGRlVwUm1tSDkvK1Vq?= =?utf-8?B?MjZlV05uYU9lZlpRRTJyNlN4N0YrSlZ6UXN2OFgvbzJRRTMxQWhVL2lSdkJP?= =?utf-8?B?SWUzb2Rwd2tiZjBsVFhxOE9KR1V3emphVElxS2pGTWhQZm5ZdDZMeXlOMHZY?= =?utf-8?B?N3Y0RTAxT3VDbWZnMDZ4cEJHalpYUUNtcjRHSGYyYjlHMnRCQVlHak9YQm9Q?= =?utf-8?B?aWZDZERldUR4eWRTK1o3RDBqMit3NEE4NEc3U2hhQVZ2Z015cXc0VkFiSEdT?= =?utf-8?B?M3gra21vZzEyeXFSM3ZUcTQwVm5JSlFFbmJxcU51R09iRGs5dWFkRlIreS9x?= =?utf-8?B?dlNITzBIV2I2bmVvTloxTEZwUkFDeWVYeWJ1Y2FXa2pyMFdBOTc2N3Rpa21G?= =?utf-8?B?ZTFzSHZTb3JsY0tOTlZvM0NxZGRSMm9aN2oyTkxkYUhBT3hFekhNMzJKdlFT?= =?utf-8?B?c3FIMnhCUHZqZzl2cUZWZDVMeWhCcndUUjBxaWlKbCtYSWpMUy9tdlJLSEZu?= =?utf-8?B?dWFoZzNJUGZtbnFmOXpXT0FOOXhNa0lZcG9FaXNiM2tpQmRRTTFkYTA2anc2?= =?utf-8?B?WG9ndG4xamo4NURoMHNMNTdtMmdwYTRrZ1hncjA0OUhld2lwaGlsZ0o3a2JL?= =?utf-8?B?MkQxUmRTblBqdzF4bVVsTkVFU0l4ZFFybmJ6WmtMQzFQOTN1SjBneFhlRWsz?= =?utf-8?B?WFQ0bExaQks3dlRiRCtPYjJ4YUlOM0VmTmlFMVAyTGZxdnY2bTZ0R3lrMlY1?= =?utf-8?B?OFIrUzlUaDNuSVp6OEgxYlNYUG5uWThUb0xxc0U5REpmdG1nb2QrbEhVZU0v?= =?utf-8?B?K05keFJDVmpiblBXbXFNR3dwZ0dOZW9PcGY3N1lWdHR3bURxZXFFM1BSZWNQ?= =?utf-8?Q?GUNLZotwZ/+3XgQAHIVFWJw=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 633e8e38-8f55-4b52-fcc2-08d9ec9865b9 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2022 13:22:33.9725 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VbKUqLKb91AAl7SKT+foDSeq4rtk73yP+/oSvm3d5POJxtSYvTXun2he5vCI9qpduj89qZCXDi7ik9Pq9P6/Xg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3343 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/10/2022 1:16 PM, Min Hu (Connor) wrote: > Hi, Ferruh, > > 在 2022/2/10 20:37, Ferruh Yigit 写道: >> On 2/9/2022 1:21 AM, Min Hu (Connor) wrote: >>> Added the ethdev dump API which provides querying private info from ethdev. >>> There exists many private properties in different PMD drivers, such as >>> adapter state, Rx/Tx func algorithm in hns3 PMD. The information of these >>> properties is important for debug. As the information is private, the new >>> API is introduced. >>> >>> Signed-off-by: Min Hu (Connor) >>> Acked-by: Morten Brørup >>> Acked-by: Ray Kinsella >>> Acked-by: Ajit Khaparde >>> --- >>> v3: >>> * change 'ethdev' to 'device' >>> v2: >>> * fixed comments from Ferruh. >>> --- >>>   doc/guides/rel_notes/release_22_03.rst |  7 +++++++ >>>   lib/ethdev/ethdev_driver.h             | 23 +++++++++++++++++++++++ >>>   lib/ethdev/rte_ethdev.c                | 17 +++++++++++++++++ >>>   lib/ethdev/rte_ethdev.h                | 20 ++++++++++++++++++++ >>>   lib/ethdev/version.map                 |  3 +++ >> >> >> Btw, can you please confirm that there will be a PMD implementation >> in this release, (it can be after -rc1)? > YES, I will send a set of patches about hns3 PMD implementation once the > API is accepted. ack, thanks. >> Because our policy requires at least one PMD implementation is >> implemented to accept a new API. >> (Thomas/David, please correct me if I remember the policy wrong) >> .