From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olivier.matz@6wind.com>
Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67])
 by dpdk.org (Postfix) with ESMTP id 74D342BA6
 for <dev@dpdk.org>; Thu, 13 Oct 2016 21:59:05 +0200 (CEST)
Received: from lfbn-1-5996-232.w90-110.abo.wanadoo.fr ([90.110.195.232]
 helo=[192.168.1.13])
 by mail.droids-corp.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <olivier.matz@6wind.com>)
 id 1bumCh-00068O-1l; Thu, 13 Oct 2016 22:02:11 +0200
To: Thomas Monjalon <thomas.monjalon@6wind.com>
References: <1476368171-18176-1-git-send-email-olivier.matz@6wind.com>
 <1476368171-18176-13-git-send-email-olivier.matz@6wind.com>
 <20161013160551.GB16751@yliu-dev.sh.intel.com> <1603777.zeWNS1Z9oX@xps13>
Cc: Yuanhan Liu <yuanhan.liu@linux.intel.com>, dev@dpdk.org,
 konstantin.ananyev@intel.com, sugesh.chandran@intel.com,
 bruce.richardson@intel.com, jianfeng.tan@intel.com, helin.zhang@intel.com,
 adrien.mazarguil@6wind.com, stephen@networkplumber.org, dprovan@bivio.net,
 xiao.w.wang@intel.com, maxime.coquelin@redhat.com
From: Olivier Matz <olivier.matz@6wind.com>
Message-ID: <3acf2e9f-f10e-ca74-0bcc-f882ca609991@6wind.com>
Date: Thu, 13 Oct 2016 21:58:34 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Icedove/45.2.0
MIME-Version: 1.0
In-Reply-To: <1603777.zeWNS1Z9oX@xps13>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v3 12/12] net/virtio: add Tso support
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 13 Oct 2016 19:59:05 -0000



On 10/13/2016 08:50 PM, Thomas Monjalon wrote:
> 2016-10-14 00:05, Yuanhan Liu:
>> On Thu, Oct 13, 2016 at 04:16:11PM +0200, Olivier Matz wrote:
>>> +/* When doing TSO, the IP length is not included in the pseudo header
>>> + * checksum of the packet given to the PMD, but for virtio it is
>>> + * expected.
>>> + */
>>> +static void
>>> +virtio_tso_fix_cksum(struct rte_mbuf *m)
>>> +{
>>> +	/* common case: header is not fragmented */
>>> +	if (likely(rte_pktmbuf_data_len(m) >= m->l2_len + m->l3_len +
>>> +			m->l4_len)) {
>>> +		struct ipv4_hdr *iph;
>>> +		struct ipv6_hdr *ip6h;
>>> +		struct tcp_hdr *th;
>>> +		uint16_t prev_cksum, new_cksum, ip_len, ip_paylen;
>>> +		uint32_t tmp;
>> ...
>>> +	} else {
>>
>> As discussed just now, if you drop the else part, you could add my
>> ACK for the whole virtio changes, and Review-ed by for all mbuf and
>> other changes.
>>
>> Thoams, please pick them by youself directly: since it depends on
>> other patches and they will be picked (or already be picked?) by you.
> 
> Applied
> 	- without TSO checksum on fragmented header
> 	- with some release notes changes
> 	- with Yuanhan acked/reviewed
> Thanks
> 

Thanks Thomas, and also to Xiao, Maxime and Yuanhan for the review!