From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B81FCA057B; Wed, 1 Apr 2020 22:52:00 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D516D1C1A6; Wed, 1 Apr 2020 22:51:59 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id 7EFB21C199 for ; Wed, 1 Apr 2020 22:51:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1585774317; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=7XgOlBrXB9LfRlagkZA+xGRxm2jbHPHvlIOWOQeJzMU=; b=gCO0A1zpFQoyX3+J9hR77IcZaZFRM0kRufXG+gkyZbGBZtPdiu90FESXX6XHfCLxG+BVw7 e3TSsG2NZ/cClHiAN63IvL2+7RTeNQpLRxCqHYRbjMKReOoZniTY5kzlDe9w43+jD25Z6Q Cq6zBwNCqy97V6o7hhAWK1RRh3FuigU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-212-Z8ayDlHfNHyXNtVHeLGmCA-1; Wed, 01 Apr 2020 16:51:56 -0400 X-MC-Unique: Z8ayDlHfNHyXNtVHeLGmCA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 617F2107ACC7; Wed, 1 Apr 2020 20:51:55 +0000 (UTC) Received: from [10.33.36.227] (unknown [10.33.36.227]) by smtp.corp.redhat.com (Postfix) with ESMTP id 410CB48; Wed, 1 Apr 2020 20:51:54 +0000 (UTC) To: Matteo Croce , dev@dpdk.org Cc: stable@dpdk.org References: <20200401131044.7259-1-mcroce@redhat.com> From: Kevin Traynor Autocrypt: addr=ktraynor@redhat.com; keydata= mQINBF2J2awBEADUEPNhgNI+nJNgiTAUcw4YIgVXEoHlsNPyyzG1BEXkWXALy0Y3fNTiw6+r ltWDkF9jzL9kfkecgQ67itGfk1OaBXgSGKuw1PUpxAwX2Bi76LAR6M5OsyGM9TSVVQwARalz hMwRBIZPzPc7or6Pw7jAOJ8SQGJ1Zlp1YJCjrvpe87V1tH/LY8Wnxn/EuoseFmWILAQZAtYS tGjcrAgYn3SPMLR1B0BP5bTBY06vWQjiufH8drenfDnMJAzuBdG1mqjnTqCjULZ3Hunv4xqZ aMnkvL/K5Tj1c12Oe4930EE53LrXIBUltRg5mBudSWHnC7twjH0082HH9f963Z/2UI63SFIT iUvRvAzJYytgy7XnWLQ0+goZBADKYfolOuC0H8VgCaux8u8KFF28Dy+N6TV2KI58jTlyg1Zu l7QwykZpnOkJFiy37Gfbu3YEOzO72cP/S7/A+zvuqkxi63jyEkd+FY99vLt/HN2MUZwRmKDw UPbLkmrs8WU01/POVsqDcfvz7vu2St8hqqTiSIdQGS2zyTKB2/DvPSM3jws3udkIYSuhn+X4 QBiV6lkVZ7DSE6a065gnAauAql+b32Eymy+xnG5jCt1tR+0Cp2VZYCR9OU2gmomUKBDoX/He pSgED01CqYPNjN+TddirwmQX7ep4DtXc8FWvv2g/pq9WZFQk2QARAQABtCNLZXZpbiBUcmF5 bm9yIDxrdHJheW5vckByZWRoYXQuY29tPokCTgQTAQgAOBYhBAoiOaH51tHF7VYtEI9CINER a+yJBQJdidmsAhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEI9CINERa+yJoxIP/3VF 2TIgW4ckxhRFCvFu/606bnvCPie88ake4uWVWMAWwcMc4fKEltRWRCpkSVOwgqoMHnyHxK5r kOKzx2CLJMX5TgTMfKzPuaBDHngHLUzl2DStpBzrod0cVg5TShdmmfjY61uxRJKz+DlSkwgJ riADdVF5PPosQXTkKSGf2ombpTGpx/pue9ocjnr3x4SDpRLlnooM6Jf/3Y3Ib4jX6HPEyWuY b+owIIk9y2nRRGPQ6jbqAhsrXd9V+77UL0QuGWloMuKMZFbNg8hbu7X5aFijAbfxj4YUgojS ba7gfGZQan8h32A9KGQWrmsCBc3j2GqEPsX0r05X7cn7WL6IOPgQJ5EiQ7PlazQYVLrvZg9B n0GKK0k6895mLG0ZZ5v/qajOPF52etSmvFD1WUPb4OqaHqGA9ZtMpaKFRt7Y6rpXqKNU1xzW F5KjbTPtTb9WF3An8dciVv+AYUI7totkZYkWvQtgss8lfaX3NKUvXLVxqK0z3dQyr7rF/tYz PneTKypSksjCgaEBLSrsRmM5zKfe7tSNF/fDntfIq/029Jtcw29TcWEP57peNu6TtejewQD9 sTI+oqiXvW2D5l7LNUDYG8eMJp2oT7I0ZSBRvwcbmjH0DtN/bXCCFfCvk8Yic68F3tV1ctix wQARVKDBhT30uCxycRWojCYqTgNJJS71uQINBF2J2awBEADP57PR2IpSYBeNSrsAjeIcsahE N4SQP2C4s50S8QEWAUhqMRI7WNv5cfeef0nDvcl1IUA6oz5SokbcsbMa+mRgaNF4N5KikWTO LPYxq2YVJoXwJ+tKmNzyOLFUIfFJ4NBJZple5dTfWzD00Dbb19Mri1hy1mWMqNTPGBee1+hw Qcp6n3mmGECvajs8G5A7NyXbwL8ihN7HX9D01ucD62b4G03yKe2g/hvKgcdUVmhCldJlF27I 2fSR9tDxH9pZqRODY4rjbFZEey/vWKXqjE+DQ8AtMSEaDfFe5D+i4Aw6erWQ3Wr+DwZt1/7G dIAElGA/q90T1ENVwJX9y7fsQssawKYYdDqURHCl5JuDXI+VXUypExipUUT5SPycMmbLsx0D iKEqPPDQWKxkIDVKqj2+EhamSuJznZUwBLJKn0h4zrIWiXWUy07lRwtVuhaDXhF3GfW+5W/x wAg7Qg3w00ASsb/XTHBIhMnenKDfS7ihtQA8SacwX8ySdxb+15XPyiplM979qBQ0mhnilulm MIJzEf/JxoYR5huuj4f1PFqqrsP06Dl+YGB7dQZp3IKggS5c3/TAynARRg9N89UsDXNtp7X0 tgIPFF5k6fnHE0J5O64GYHeTqN/1aE6dAEOV9WrGzQAJxU9ipikb8jKAWXzLewRIKGmoPcRZ WdB0NmIjmQARAQABiQI2BBgBCAAgFiEECiI5ofnW0cXtVi0Qj0Ig0RFr7IkFAl2J2awCGwwA CgkQj0Ig0RFr7IkkORAAl/NbX93WK5MEoRw7/DaPTo/Lo6Pj1XMeSqGyACigHK/452UDvlEH NjNJMzYYrNIjMtEmN9VVCfjT38CSca7mpGQVwchc0mC7QSPAETLCS+UacVf/Kwxz5FfkEUUw UT7A+uyVOIgW3d9ldlRzkHA2czonSSgTQU+i2g6DM4ha+BuQb4byAXH6HQHt/Zh1J64z0ohH v6iGsCzCY/sMWF8+LEGSnzMGRCLiiwSF0vJBHbzWK68fANaF4gBV0Z/+6tQRFN7YMhj/INmk qgvHj1ZzHFNtirjMGPRxoZs51YoLQM/aBPxKrnmXThx1ufH+0L6sGmFTugiDt0XSEkC5reH7 a+VhQ1VTFFQrClA8NmDSPzFeuhru4ryaaDHO+uEB16cNHxHrQtlP/2hts2JM5lwkZRWJ5A57 h8eDEIK5be47T85NVHfuTaboNRmgg1HygVejhGUtt69u/0MVRg/roUTa0FyEbNsvz4qAecyW yWzMcVrcGJDQLC9JLKEpoyUF6gdTKaiDL2Vao4+XRIA3Y57b6MO35a3HuzAv7+i5Z0mnDEJO XxXqTOmKYpMIGexzM/PtuA0712sT1abG9tAJ17ao/B7cqMW5IkKkalemFbWfI2unns4Papvo tk9igVqyp6EJDU98z5TJioCVojwK2laDaoIjTJk9YYv3iwCsqPd5feU= Message-ID: <3ad97d74-02c9-6827-e778-8c1be0d7d106@redhat.com> Date: Wed, 1 Apr 2020 21:51:53 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200401131044.7259-1-mcroce@redhat.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] net/dpdkoin: add new driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 01/04/2020 14:10, Matteo Croce wrote: > DPDK polls the packet in a busy loop. This means that CPU constantly spin= s > looking for packets, regardless of the network traffic. > DPDK does this to reduce latency and avoid using interrupts, at expense o= f > efficiency: this might consume more processing power and generate more he= at > than needed, potentially increasing the TCO of a DPDK appliance. >=20 > Here comes DPDKoin. DPDKoin is a DPDK PMD, which instead of moving > packets, mines cryptocurrencies. > DPDKoin just does a few calculations to every poll cycle, this means that > when the network is loaded, DPDKoin consumes just a few cycles, but when > there is no traffic, DPDKoin mines currencies in a busy loop. > The coins are mined with no extra consumption, as the CPU would spin > anyway. >=20 > This is a system running with two 10G cards running with DPDK: >=20 > PID USER PR NI VIRT RES SHR S %CPU %MEM TIME+ COMM= AND > 8223 root 10 -10 260.6g 597516 19100 S 199.8 0.5 0:17.89 test= pmd >=20 > And this is the same system with a DPDKoin port added: >=20 > PID USER PR NI VIRT RES SHR S %CPU %MEM TIME+ COMM= AND > 9438 root 10 -10 260.6g 598892 19800 S 199.8 0.5 0:19.43 test= pmd >=20 > As you can see, we don't observe any change in the CPU usage, and besides= , > the earned coins lowers the appliance TCO. >=20 > Just for reference, a test run log follows: >=20 > $ sudo testpmd --no-huge -m 1024 --no-pci --vdev eth_dpdkoin0 --vdev eth_= dpdkoin1 > EAL: Detected 8 lcore(s) > EAL: Detected 1 NUMA nodes > EAL: Multi-process socket /var/run/dpdk/rte/mp_socket > EAL: Selected IOVA mode 'VA' > EAL: Probing VFIO support... > testpmd: create a new mbuf pool : n=3D203456, size=3D= 2176, socket=3D0 > testpmd: preferred mempool ops selected: ring_mp_mc > Configuring Port 0 (socket 0) > Port 0: 4A:50:3C:33:55:21 > Configuring Port 1 (socket 0) > Port 1: BA:BB:0A:BB:0C:CA > Checking link statuses... > Done > No commandline core given, start packet forwarding > io packet forwarding - ports=3D2 - cores=3D1 - streams=3D2 - NUMA support= enabled, MP allocation mode: native > Logical Core 1 (socket 0) forwards packets on 2 streams: > RX P=3D0/Q=3D0 (socket 0) -> TX P=3D1/Q=3D0 (socket 0) peer=3D02:00:00:= 00:00:01 > RX P=3D1/Q=3D0 (socket 0) -> TX P=3D0/Q=3D0 (socket 0) peer=3D02:00:00:= 00:00:00 >=20 > io packet forwarding packets/burst=3D32 > nb forwarding cores=3D1 - nb forwarding ports=3D2 > port 0: RX queue number: 1 Tx queue number: 1 > Rx offloads=3D0x0 Tx offloads=3D0x0 > RX queue: 0 > RX desc=3D0 - RX free threshold=3D0 > RX threshold registers: pthresh=3D0 hthresh=3D0 wthresh=3D0 > RX Offloads=3D0x0 > TX queue: 0 > TX desc=3D0 - TX free threshold=3D0 > TX threshold registers: pthresh=3D0 hthresh=3D0 wthresh=3D0 > TX offloads=3D0x0 - TX RS bit threshold=3D0 > port 1: RX queue number: 1 Tx queue number: 1 > Rx offloads=3D0x0 Tx offloads=3D0x0 > RX queue: 0 > RX desc=3D0 - RX free threshold=3D0 > RX threshold registers: pthresh=3D0 hthresh=3D0 wthresh=3D0 > RX Offloads=3D0x0 > TX queue: 0 > TX desc=3D0 - TX free threshold=3D0 > TX threshold registers: pthresh=3D0 hthresh=3D0 wthresh=3D0 > TX offloads=3D0x0 - TX RS bit threshold=3D0 > libbitcoin 0.1: mining on CPU2 > libbitcoin 0.1: mining on CPU4 > --- > config/common_base | 5 + > drivers/net/Makefile | 1 + > drivers/net/dpdkoin/Makefile | 23 + > drivers/net/dpdkoin/meson.build | 3 + > drivers/net/dpdkoin/rte_eth_dpdkoin.c | 696 ++++++++++++++++++ > .../net/dpdkoin/rte_pmd_dpdkoin_version.map | 3 + > mk/rte.app.mk | 1 + > 7 files changed, 732 insertions(+) > create mode 100644 drivers/net/dpdkoin/Makefile > create mode 100644 drivers/net/dpdkoin/meson.build > create mode 100644 drivers/net/dpdkoin/rte_eth_dpdkoin.c > create mode 100644 drivers/net/dpdkoin/rte_pmd_dpdkoin_version.map I see you are requesting this for backport to stable branches. While this is not fixing a specific commit per se, it is clearly fixing a gap whereby it would be unfair for stable users to miss out on any potential bonanza. Unfortunately there is a blocker due to validation. Normally, we might be concerned by lack of it, but in this case the concern is that it might encourage too much validation and many lengthy stress tests that could impact release dates.