From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1B0B0A0C4D; Mon, 4 Oct 2021 16:11:29 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C0C4E412BC; Mon, 4 Oct 2021 16:11:28 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 45F134123A for ; Mon, 4 Oct 2021 16:11:27 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10126"; a="225758793" X-IronPort-AV: E=Sophos;i="5.85,346,1624345200"; d="scan'208";a="225758793" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Oct 2021 07:04:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,346,1624345200"; d="scan'208";a="544295897" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by fmsmga004.fm.intel.com with ESMTP; 04 Oct 2021 07:04:04 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 4 Oct 2021 07:04:04 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 4 Oct 2021 07:03:59 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Mon, 4 Oct 2021 07:03:59 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.48) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Mon, 4 Oct 2021 07:03:59 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hl8ypYp6fy2S8nkbqFJ6biXCf4wMG8xilkTWInzeDmZe2XyCYqLl6uZe2WhdsSktBjYmHKWrsNRmN/TsiPic1W92keKXqCOsQpFkNyRzHTLm+hHGlKvBQEX9DKidrj6FeWZgw6T8H7gDfDmJ4c0+JeVcmg1QmjD/CvgI+egelvyQVKV+mEYOOXFUsfFh83mPSU9sWuvsgwno1cC+MCXdQ+fhUeZsIJlAdMJaXQN5CSkNAbjD5eMUh47AwkURgu+9M85mnfaojSZvFKfvR77Ocf3UHwQDz01B+bhfdDOfljg+6ukDzB6JCbq5QDkLQ0OHpK7s4BrnOT+o8LLD15kujw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+wgthdhlOsi6P+m9GPorwDAOlA29WsUiqmUkjo79rqU=; b=XdzAWR2+fUXx8xoti3TE/u4yO2OjRV6806VfwzYMRim1nCSK2O0ZJ+ui19hZyzLCKcRoUOBd0H/SUBfyZRgMShQICvftvoatNkfb0mpmrA2iOQ4k1R8cu1gm0QXf7kwxaEsfHLEq9FbHhyoW9GcFM2Kerbz7fM3XDMcZjKzWn3LO6yBEvI1UWRS5jzjYCBm5s8rxcI+3oUugt/X1OtUTJGXErLd8BFM3bfRCBx15IrzwR4QR+gD9d5Xxv2ir/vpZ39w/jnrvS/QnU4JioQx1Mwdutb0TN/fljUBm+8Wnb+90EbumfGpPBEzoU40UmpuSyEh/0M74Poy8Pw/PYnvkDw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+wgthdhlOsi6P+m9GPorwDAOlA29WsUiqmUkjo79rqU=; b=r+NNqV0nboVcHLHbhr0CGI400nEYRepMfh0XAo9lhkxhEYtEj8RGoe+aNC1ZF9PkC92oKeLGifl0JPUlbr0LLwQdKF4Qw4dVGOq5knb2dVocpWUtx8/FmRN6T9CK902EW+5mnNxDWxoVOexFYpCPaiY6KLrcz5OKUXSoGsohSPI= Authentication-Results: nfware.com; dkim=none (message not signed) header.d=none;nfware.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5160.namprd11.prod.outlook.com (2603:10b6:510:3e::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.16; Mon, 4 Oct 2021 14:03:58 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc%4]) with mapi id 15.20.4566.022; Mon, 4 Oct 2021 14:03:58 +0000 To: Elad Nachman CC: Eric Christian , dev , Igor Ryzhov References: <20210924105409.21711-1-eladv6@gmail.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <3ae193df-292c-4907-df4a-88ce3d6735fc@intel.com> Date: Mon, 4 Oct 2021 15:03:52 +0100 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DB6PR0301CA0057.eurprd03.prod.outlook.com (2603:10a6:4:54::25) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB6PR0301CA0057.eurprd03.prod.outlook.com (2603:10a6:4:54::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.14 via Frontend Transport; Mon, 4 Oct 2021 14:03:57 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2dbf1c37-a209-460f-035a-08d9873fcf9b X-MS-TrafficTypeDiagnostic: PH0PR11MB5160: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6790; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5/ccrEyGvgQcnrzpYnHQTl+YtUeBW3L8XPm8iz2++nJ8THAlb1qwocxlQz0APw5ahJRHvG7rOhywMYR3q+vGRZfpH1qnafIJ+NsRcGCat5EAj/FYW3a9KRqgxhujclzG+LdF+dLabAQnhayH4BIdupBfnvPhnUnrxq+Bm6zFAWDnOxJK5oH3iR0UNpzzv0W833QrHb3jGDnava0xdfdNnsSX2Sfa/0Cg0wVUgBEStrhIWDryDTRgh0SlJg+mo/pddhnbGFyD296by/npZCHT7RUyZyJvLos5VtlFONxzG8HdWPN9pqZpPzAVuooD39JlVG8hKXZic9vlAOF8+Dq20yoRADaw0jqhAjWuRRPVZcrVyfr21N281oJJwWEd3ayZCjCrDLRiQLZ9a/3SOf0YrhSa085bRq/78hzu3bAl9Ttq2D8XyfwRw2P0t46k34pxvnimNE13BmOgc2kWtrAYXOnyyodLPJcMZB/9LdMMsMagFFSMklhDcFA+FhbNrrV+PSKaFFUJ0bf5pnjcW4nlDNoDhiRRemEUaFSvCgk4GIuDq+QiVOmsEsUWW7j1H48cyQdMGoJz1gLabzkw6PqwSRb68aoKznqeqX6OOu+XQWiok5vSPekhrgnYjy/n/W/F7rCzzbPOhfl2EhLAfQ3eJil2rUO4pHR1ZY/PfHzI+/4pwlA4e0V8SWkzK+NIQKyUWrx7ZlzOfiFA9TxcFjtGYg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(5660300002)(83380400001)(6486002)(508600001)(6666004)(53546011)(2906002)(2616005)(38100700002)(8936002)(4326008)(31696002)(54906003)(6916009)(186003)(36756003)(86362001)(31686004)(16576012)(8676002)(26005)(44832011)(956004)(66476007)(66556008)(66946007)(316002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z09aSU5IK3ZlcXp6N0tyQitLSnI2RzRPekxxQldEOUFMak5sVkFWaCtuZGts?= =?utf-8?B?UFN5aHBEVkNaYXpTb2pDRnBjZHZyOW04VmQ5SUVqc2lUSi8wM3Z5T1RJTVN0?= =?utf-8?B?NnlNQjloVENLMjlkTlFBZjVlNUpZZXQyN3FoM0xiVEhiTFRVWlIwdWk5ZTlV?= =?utf-8?B?bVNRdXVvQmdIdytNcGcxN2Z4U0NuZzVaTitwTEJmb2VmbHAzeXgyZkZzNk45?= =?utf-8?B?dG1UMjk5WERaN0ZqeThPS1JWalh1akdmOUVyWGJXekRaemFtZmpLdmp2MUhz?= =?utf-8?B?VUdhR3JSczBEWkFYZktnNmZ2L1dxK3YvWUUxbSswVUdyeHIzSEdoVWVROHZq?= =?utf-8?B?R3MrR29wdStvanhxS0k1ejRRWXhFZUxveGJBZU9TNllUYW5XaFp4cHZWeFI2?= =?utf-8?B?c2ZlblMxVGdVY3FBOEZJWkNJZmYvWnEwZ2taODJDYTB0Nng1WjlCUTU5UEhC?= =?utf-8?B?SE1CNE5sc1k3a2N3Q0hyeE1mQWFIYW14Vi9NbTNWZzRPN2F3c2N1TkFKSXZo?= =?utf-8?B?ZEZUaElSZFpXS0JkRzhSK0J2ekk5U24wdndUMWREYmVoYXVOL3E5d3RTWjZS?= =?utf-8?B?NVpIWVBMcGNWRHR3TnY5MityREw1UnlwdVdJcUJIRnhsTzdBdjVCd0czd0VJ?= =?utf-8?B?ZHVvOHlTdkJ5a0lhd1NhZnNmc21SYjM4MUtjMTcrdWE0RW13VTZCelM0Q3l3?= =?utf-8?B?bEJMbVR2WENlL05ROEtBbzBrdWRnRFg5R2ZlMXNZQmw2T2FrcHNUL0VzRzlP?= =?utf-8?B?R0wvUmN2MElJOTZJREtDLzhhZDlUK1l3Ti94VWg2TU9PTmpDc1p2QldVU21G?= =?utf-8?B?bWs0ckVoc2R4WFZvUW42eFN6RXpzeXl1T2NlZ2N1WmYzcUxhMkcvTm4vQmMz?= =?utf-8?B?a3kvTitkeXJjbGdiSS9EeHhLZkkzNWIyZGczQ3ZOWW9JZldZZ1FyYUZ2Nnc4?= =?utf-8?B?V2x3MHArbjhrSytnRWtxTFFrVDZwMzRCRWlLcFpmY01rVE52cjBUWk5vMmk0?= =?utf-8?B?ek5TSll2REFzTnl2a3Erd0pyYU5RUENLNjRLU2QrTEdlcDJCZXNtSEZxMUdu?= =?utf-8?B?ODdxU0trRFBJM0tId0wyVmkwWDVJS3pJV05XUmFkcnp0RnJFMkx0Vk5YZ3V5?= =?utf-8?B?RnFNam9YQUR1anZ5eDVjSmpKQzFlR3lqVi9jK2JiUU5BT2U4eGhSWXV2YWRT?= =?utf-8?B?VFdtZUlRTlRkbmY1SjlaT3NHNmI4czRQdlZodFhNY1dBQnltamF5ZndhbWhn?= =?utf-8?B?ZEdaQVMxditaYlVEQzRGbEgzTzk4MjhJSE5jUVh1OC9YSDZZcEM1TkpOdm16?= =?utf-8?B?M1JucHY0WURFMTh4VUduMGkxejFYYU5ocFpjcmFTc3NrWjdzNGVZbFhudUFW?= =?utf-8?B?MUQ1aHdGMkQzcE5ONUZVd1JkYWRTUkhiUFRXcUxGdmIyQmp6Ym50eHdZY0xE?= =?utf-8?B?cnlNb25xWkdhU2o2OGF1dExzS2JjVG5NMXI3NHkvV2U2UVdoWjRFTzJqV0VD?= =?utf-8?B?TUlHY2JRRldSNGhzR3d0eU82bHpSS1ZuY1RzUGxITWVxU3NEMjNJMDBadU80?= =?utf-8?B?TjFrWUVhTGhWbFZHRkd0TW5SdU9MdWVkMVJKclVZM1B5REtPK2dHV1h3Yncx?= =?utf-8?B?ejhSRWFIVXM1cDdLYXFnWHZZUUkrQVAzSVdCcm03eWRLSXltZktxSDNxdFpR?= =?utf-8?B?NVdNQ01VUXMwMEIyN2F1WThVeS9PRnE2a1VCTERNRGd2MERZT2drcWUrdEl5?= =?utf-8?Q?Ilx0qbMWtJlJp5lJnG0PdtGtIm2KDvpfjz9g0pa?= X-MS-Exchange-CrossTenant-Network-Message-Id: 2dbf1c37-a209-460f-035a-08d9873fcf9b X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2021 14:03:58.6473 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: eWhEOFLi9HzPGkcW4RgGGejGFrKZtoMByOg69FUpsWvAoj8y1y3dx//BkpgDiT4BydyUt+5DIsr+/kj5sCZ40g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5160 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2] kni: Fix request overwritten X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/4/2021 2:09 PM, Elad Nachman wrote: > Hi, > > EAGAIN is propogated back to the kernel and to the caller. > So will the user get an error, or it will be handled by the kernel and retried? > We cannot retry from the kni kernel module since we hold the rtnl lock. > Why not? We are already waiting until a command time out, like 'kni_net_open()' can retry if 'kni_net_process_request()' returns '-EAGAIN'. And we can limit the number of retry for safety. > FYI, > > Elad > > בתאריך יום ב׳, 4 באוק׳ 2021, 16:05, מאת Ferruh Yigit ‏< > ferruh.yigit@intel.com>: > >> On 9/24/2021 11:54 AM, Elad Nachman wrote: >>> Fix lack of multiple KNI requests handling support by introducing a >>> request in progress flag which will fail additional requests with >>> EAGAIN return code if the original request has not been processed >>> by user-space. >>> >>> Bugzilla ID: 809 >> >> Hi Eric, >> >> Can you please test this patch, if it solves the issue you reported? >> >>> >>> Signed-off-by: Elad Nachman >>> --- >>> kernel/linux/kni/kni_net.c | 9 +++++++++ >>> lib/kni/rte_kni.c | 2 ++ >>> lib/kni/rte_kni_common.h | 1 + >>> 3 files changed, 12 insertions(+) >>> >> >> <...> >> >>> @@ -123,7 +124,15 @@ kni_net_process_request(struct net_device *dev, >> struct rte_kni_request *req) >>> >>> mutex_lock(&kni->sync_lock); >>> >>> + /* Check that existing request has been processed: */ >>> + cur_req = (struct rte_kni_request *)kni->sync_kva; >>> + if (cur_req->req_in_progress) { >>> + ret = -EAGAIN; >> >> Overall logic in the KNI looks good to me, this helps to serialize the >> requests >> even for async ones. >> >> But can you please clarify how it behaves in the kernel side with '-EAGAIN' >> return type? Will linux call the ndo again, or will it just fail. >> >> If it just fails should we handle the re-try on '-EAGAIN' within the kni >> module? >> >>