From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 6DD2D2965; Tue, 17 Jul 2018 11:28:32 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Jul 2018 02:28:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,365,1526367600"; d="scan'208";a="73002306" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.237.220.102]) ([10.237.220.102]) by fmsmga001.fm.intel.com with ESMTP; 17 Jul 2018 02:28:28 -0700 To: Reshma Pattan , dev@dpdk.org Cc: jasvinder.singh@intel.com, bernard.iremonger@intel.com, stable@dpdk.org References: <1531760319-2996-1-git-send-email-reshma.pattan@intel.com> From: "Burakov, Anatoly" Message-ID: <3b00cf4a-4557-1c02-2a3b-e8df75cf32b8@intel.com> Date: Tue, 17 Jul 2018 10:28:28 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1531760319-2996-1-git-send-email-reshma.pattan@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] test: fix incorrect return types X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Jul 2018 09:28:33 -0000 On 16-Jul-18 5:58 PM, Reshma Pattan wrote: > UTs should return either TEST_SUCCESS or TEST_FAILED only. > They should not return 0, -1 and any other value. > > Fixes: 9c9befea4f ("test: add flow classify unit tests") > CC: jasvinder.singh@intel.com > CC: bernard.iremonger@intel.com > CC: stable@dpdk.org > > Signed-off-by: Reshma Pattan > --- Perhaps it should be highlighted that along with making them return TEST_SUCCESS/FAILURE, you're also fixing the -ENOMEM return in one of the code paths. Otherwise, Reviewed-by: Anatoly Burakov -- Thanks, Anatoly