From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 79C37A327F for ; Mon, 21 Oct 2019 23:41:47 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D7C5649DF; Mon, 21 Oct 2019 23:41:45 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id 3A8BE2C28 for ; Mon, 21 Oct 2019 23:41:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1571694104; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UvNIMGzbOJ3JIG7Rd/nMvNu2a91/TaGMQxI12+MFVkg=; b=QmBHcowyYwfCXx8npk3ecISv4ZAOUp7LlzxVOg474ZLDEz3/NEbOnb36jweBbNOZ5ablYD 8ei+4ozqQj55k8BKwMoI03sjD/Zr4l0cblPoc2a4MUruCdOCrEUkktK854a/9U3lvxhY0I biNWKyl7b86zWo8axrLs5ultK5Z1Rn8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-160-anZxDCcfNM64b_NxhUiwTg-1; Mon, 21 Oct 2019 17:41:41 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1259C1800D79; Mon, 21 Oct 2019 21:41:40 +0000 (UTC) Received: from [10.36.118.52] (unknown [10.36.118.52]) by smtp.corp.redhat.com (Postfix) with ESMTP id 546005D6A5; Mon, 21 Oct 2019 21:41:36 +0000 (UTC) To: Rasesh Mody , "dev@dpdk.org" , Jerin Jacob Kollanukkaran , "ferruh.yigit@intel.com" Cc: GR-Everest-DPDK-Dev References: From: Kevin Traynor Message-ID: <3b0226a8-56f5-00ff-bfe8-6d423b26ef6f@redhat.com> Date: Mon, 21 Oct 2019 22:41:33 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-MC-Unique: anZxDCcfNM64b_NxhUiwTg-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH 1/3] net/qede/base: fix for FW bug X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 21/10/2019 21:46, Rasesh Mody wrote: >> From: Kevin Traynor >> Sent: Monday, October 21, 2019 1:10 PM >> >> ---------------------------------------------------------------------- >> On 21/10/2019 19:52, Rasesh Mody wrote: >>> Hi Kevin, >>> >>>> From: Kevin Traynor >>>> Sent: Monday, October 21, 2019 3:58 AM >>>> >>>> --------------------------------------------------------------------- >>>> - On 20/10/2019 06:20, Rasesh Mody wrote: >>>>> In our testing we have identified a critical FW bug. Performance is >>>>> degraded significantly for certain packet sizes with 8.40.25.0 FW. >>>>> >>>>> This patch updates the FW to version 8.40.33.0. The updated FW has a >>>>> fix to performance issue. >>>>> >>>>> The patch also adds initialization for FW overlay RAM as part of >>>>> hardware initialization which is required by the new FW. >>>>> >>>>> Fixes: 066f0d380a2f ("net/qede/base: update FW to 8.40.25.0") >>>>> >>>> Hi Rasesh, it should be: >>>> >>>> Fixes: 21c959e2cb10 ("net/qede/base: update FW to 8.40.25.0") >>>> >>> I could not find the 21c959e2cb10 reference, can you please let me know >> which tree is it coming from? >> dpdk-next-net and dpdk-next-net-brcm trees. The commit doesn't seem to >> be in dpdk tree yet. > dpdk-next-net tree gives a different reference as below.=20 > Fixes: 0cd01921343e ("net/qede/base: update FW to 8.40.25.0") >=20 ah ok, I figured out it is a problem on my side - got back in sync with the remote and I see the same commit-id. Sorry for the noise. > The one, originally used, is from dpdk-next-net-mrvl tree. >=20 > Do you suggest to update the Fixes tag to a commit id from dpdk-next-net = tree? >=20 The best would be the dpdk tree, but you can't do that as it's not there yet. I'd probably go with the highest tree that it has been merged into (dpdk-next-net) but i'm not sure it really matters. From a stable view, we won't find the sha1 in the dpdk tree, but we'd see that there's no stable tag and we'd find the commit through the title.