From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9F82D43CBA; Fri, 15 Mar 2024 14:34:34 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0F50742ED0; Fri, 15 Mar 2024 14:34:34 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 83BFC42E6B for ; Fri, 15 Mar 2024 14:34:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710509672; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=IxtUnQROTtIOHsxuIbcNb70pI6VJeshlzi1UhGa7ytA=; b=G0g27bqfyj14/d0S1yOzX2RXEF654j32fYIg1CrHroGG6mmKWAPB+fvApSliZD+z9cCKg5 NFtx59fKjMi5nMKZVw2ac236gAbCJgRghhxnPGMHwLC6yuZAJQk0QzFQOVXqjhn/3K+QHt mI6EUCjBL64ZlHHMNXhGEEGXeuPH6PQ= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-693-T0Mzzq2uMcGdBLqf9hM2kQ-1; Fri, 15 Mar 2024 09:34:28 -0400 X-MC-Unique: T0Mzzq2uMcGdBLqf9hM2kQ-1 Received: by mail-lf1-f71.google.com with SMTP id 2adb3069b0e04-513cf3f8d67so2090940e87.1 for ; Fri, 15 Mar 2024 06:34:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710509667; x=1711114467; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IxtUnQROTtIOHsxuIbcNb70pI6VJeshlzi1UhGa7ytA=; b=hjrrsITiJ1nWqtHFuMkbmFNiG2t7b8DU0l1WbmAR+3DRwEJ7j0Zoz+VgQl3cgJkqyg 7sP5sQtiN1VTVYGJMOk19WP0ikTnbTkTo9ymhFT5yEojcwK0V+7089Vfzy/5235Z4WwT HX7OeGzEplDJ+tsx36DK87SWxy/vyYCcgcqFGn+FxIXQ2NrE/tNJsmavcwmCwzmoNhbu wsgYrgvgUeKhIvXZ4Y6fQyIsaUMZPentudfY9EYOPAoTjp/eiu7S+hQPJ8ZHhAAhw0ol Ij4JIiuNTiXp1FLvKgDmUi1d4vuSGOdXhRk7uTiY29o+JZMmBr1hpUoGfVdaVlVBhcwN gdjQ== X-Gm-Message-State: AOJu0Yz4MP/lM2fJ/I0mQRg8TZptBqz257WD1nfoAERlAqGZloXbgTf7 X1baAIVxmwqkPw0i8bchH77/VdFhH4cd+RdOCIof+euk54zOMizdPaOd7h8mjxnXXYkTt2wrkKK +DkgND6zJkEGfvDS6a1/mCjDkH1dcQEeMcLc6DiCS X-Received: by 2002:ac2:4c19:0:b0:513:a73f:c0ed with SMTP id t25-20020ac24c19000000b00513a73fc0edmr3644526lfq.51.1710509666828; Fri, 15 Mar 2024 06:34:26 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG1DUhSC6OlcGA4jOq6x3djGc/GQWEl0QlaCl+uYBcJmcECHmnbLTPc2YIzJ3MFqjg2In+AJg== X-Received: by 2002:ac2:4c19:0:b0:513:a73f:c0ed with SMTP id t25-20020ac24c19000000b00513a73fc0edmr3644506lfq.51.1710509666435; Fri, 15 Mar 2024 06:34:26 -0700 (PDT) Received: from [192.168.0.36] ([78.19.70.144]) by smtp.gmail.com with ESMTPSA id n7-20020a05600c3b8700b00413ea3db648sm8594463wms.26.2024.03.15.06.34.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 Mar 2024 06:34:25 -0700 (PDT) Message-ID: <3b217cec-0b6a-45d2-8ff8-c8e2e8061283@redhat.com> Date: Fri, 15 Mar 2024 13:34:24 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Deprecated packet modification flow actions To: Dariusz Sosnowski , Chaoyong He , "NBU-Contact-Thomas Monjalon (EXTERNAL)" , Ferruh Yigit , Andrew Rybchenko , Ori Kam , Ajit Khaparde , Somnath Kotur , Rahul Lakkireddy Cc: "dev@dpdk.org" , "techboard@dpdk.org" References: From: Kevin Traynor Autocrypt: addr=ktraynor@redhat.com; keydata= xsFNBF2J2awBEADUEPNhgNI+nJNgiTAUcw4YIgVXEoHlsNPyyzG1BEXkWXALy0Y3fNTiw6+r ltWDkF9jzL9kfkecgQ67itGfk1OaBXgSGKuw1PUpxAwX2Bi76LAR6M5OsyGM9TSVVQwARalz hMwRBIZPzPc7or6Pw7jAOJ8SQGJ1Zlp1YJCjrvpe87V1tH/LY8Wnxn/EuoseFmWILAQZAtYS tGjcrAgYn3SPMLR1B0BP5bTBY06vWQjiufH8drenfDnMJAzuBdG1mqjnTqCjULZ3Hunv4xqZ aMnkvL/K5Tj1c12Oe4930EE53LrXIBUltRg5mBudSWHnC7twjH0082HH9f963Z/2UI63SFIT iUvRvAzJYytgy7XnWLQ0+goZBADKYfolOuC0H8VgCaux8u8KFF28Dy+N6TV2KI58jTlyg1Zu l7QwykZpnOkJFiy37Gfbu3YEOzO72cP/S7/A+zvuqkxi63jyEkd+FY99vLt/HN2MUZwRmKDw UPbLkmrs8WU01/POVsqDcfvz7vu2St8hqqTiSIdQGS2zyTKB2/DvPSM3jws3udkIYSuhn+X4 QBiV6lkVZ7DSE6a065gnAauAql+b32Eymy+xnG5jCt1tR+0Cp2VZYCR9OU2gmomUKBDoX/He pSgED01CqYPNjN+TddirwmQX7ep4DtXc8FWvv2g/pq9WZFQk2QARAQABzSNLZXZpbiBUcmF5 bm9yIDxrdHJheW5vckByZWRoYXQuY29tPsLBjgQTAQgAOBYhBAoiOaH51tHF7VYtEI9CINER a+yJBQJdidmsAhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEI9CINERa+yJoxIP/3VF 2TIgW4ckxhRFCvFu/606bnvCPie88ake4uWVWMAWwcMc4fKEltRWRCpkSVOwgqoMHnyHxK5r kOKzx2CLJMX5TgTMfKzPuaBDHngHLUzl2DStpBzrod0cVg5TShdmmfjY61uxRJKz+DlSkwgJ riADdVF5PPosQXTkKSGf2ombpTGpx/pue9ocjnr3x4SDpRLlnooM6Jf/3Y3Ib4jX6HPEyWuY b+owIIk9y2nRRGPQ6jbqAhsrXd9V+77UL0QuGWloMuKMZFbNg8hbu7X5aFijAbfxj4YUgojS ba7gfGZQan8h32A9KGQWrmsCBc3j2GqEPsX0r05X7cn7WL6IOPgQJ5EiQ7PlazQYVLrvZg9B n0GKK0k6895mLG0ZZ5v/qajOPF52etSmvFD1WUPb4OqaHqGA9ZtMpaKFRt7Y6rpXqKNU1xzW F5KjbTPtTb9WF3An8dciVv+AYUI7totkZYkWvQtgss8lfaX3NKUvXLVxqK0z3dQyr7rF/tYz PneTKypSksjCgaEBLSrsRmM5zKfe7tSNF/fDntfIq/029Jtcw29TcWEP57peNu6TtejewQD9 sTI+oqiXvW2D5l7LNUDYG8eMJp2oT7I0ZSBRvwcbmjH0DtN/bXCCFfCvk8Yic68F3tV1ctix wQARVKDBhT30uCxycRWojCYqTgNJJS71zsFNBF2J2awBEADP57PR2IpSYBeNSrsAjeIcsahE N4SQP2C4s50S8QEWAUhqMRI7WNv5cfeef0nDvcl1IUA6oz5SokbcsbMa+mRgaNF4N5KikWTO LPYxq2YVJoXwJ+tKmNzyOLFUIfFJ4NBJZple5dTfWzD00Dbb19Mri1hy1mWMqNTPGBee1+hw Qcp6n3mmGECvajs8G5A7NyXbwL8ihN7HX9D01ucD62b4G03yKe2g/hvKgcdUVmhCldJlF27I 2fSR9tDxH9pZqRODY4rjbFZEey/vWKXqjE+DQ8AtMSEaDfFe5D+i4Aw6erWQ3Wr+DwZt1/7G dIAElGA/q90T1ENVwJX9y7fsQssawKYYdDqURHCl5JuDXI+VXUypExipUUT5SPycMmbLsx0D iKEqPPDQWKxkIDVKqj2+EhamSuJznZUwBLJKn0h4zrIWiXWUy07lRwtVuhaDXhF3GfW+5W/x wAg7Qg3w00ASsb/XTHBIhMnenKDfS7ihtQA8SacwX8ySdxb+15XPyiplM979qBQ0mhnilulm MIJzEf/JxoYR5huuj4f1PFqqrsP06Dl+YGB7dQZp3IKggS5c3/TAynARRg9N89UsDXNtp7X0 tgIPFF5k6fnHE0J5O64GYHeTqN/1aE6dAEOV9WrGzQAJxU9ipikb8jKAWXzLewRIKGmoPcRZ WdB0NmIjmQARAQABwsF2BBgBCAAgFiEECiI5ofnW0cXtVi0Qj0Ig0RFr7IkFAl2J2awCGwwA CgkQj0Ig0RFr7IkkORAAl/NbX93WK5MEoRw7/DaPTo/Lo6Pj1XMeSqGyACigHK/452UDvlEH NjNJMzYYrNIjMtEmN9VVCfjT38CSca7mpGQVwchc0mC7QSPAETLCS+UacVf/Kwxz5FfkEUUw UT7A+uyVOIgW3d9ldlRzkHA2czonSSgTQU+i2g6DM4ha+BuQb4byAXH6HQHt/Zh1J64z0ohH v6iGsCzCY/sMWF8+LEGSnzMGRCLiiwSF0vJBHbzWK68fANaF4gBV0Z/+6tQRFN7YMhj/INmk qgvHj1ZzHFNtirjMGPRxoZs51YoLQM/aBPxKrnmXThx1ufH+0L6sGmFTugiDt0XSEkC5reH7 a+VhQ1VTFFQrClA8NmDSPzFeuhru4ryaaDHO+uEB16cNHxHrQtlP/2hts2JM5lwkZRWJ5A57 h8eDEIK5be47T85NVHfuTaboNRmgg1HygVejhGUtt69u/0MVRg/roUTa0FyEbNsvz4qAecyW yWzMcVrcGJDQLC9JLKEpoyUF6gdTKaiDL2Vao4+XRIA3Y57b6MO35a3HuzAv7+i5Z0mnDEJO XxXqTOmKYpMIGexzM/PtuA0712sT1abG9tAJ17ao/B7cqMW5IkKkalemFbWfI2unns4Papvo tk9igVqyp6EJDU98z5TJioCVojwK2laDaoIjTJk9YYv3iwCsqPd5feU= In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 15/03/2024 09:24, Dariusz Sosnowski wrote: >> NFP plans support RTE_FLOW_ACTION_TYPE_MODIFY_FIELD flow action in >> 24.07 or 24.11. >> For remove of legacy flow, does there also correspond patches in OVS project? > I am not familiar with any patches to OVS. Thanks for raising this. > > For the record, in latest commit on main branch in OVS (commit fa0dfa18d534) I see that the following modify actions are used: > > RTE_FLOW_ACTION_TYPE_SET_MAC_SRC > RTE_FLOW_ACTION_TYPE_SET_MAC_DST > RTE_FLOW_ACTION_TYPE_SET_IPV4_SRC > RTE_FLOW_ACTION_TYPE_SET_IPV4_DST > RTE_FLOW_ACTION_TYPE_SET_TTL > RTE_FLOW_ACTION_TYPE_SET_TP_SRC > RTE_FLOW_ACTION_TYPE_SET_TP_DST > RTE_FLOW_ACTION_TYPE_SET_IPV6_SRC > RTE_FLOW_ACTION_TYPE_SET_IPV6_DST > > We'd need to sync with OVS developers, but I assume we cannot just remove these without providing a proper replacement, so the functionality is not broken. Yes, but I'd add that this is a general point about the API, regardless of OVS or other projects. > I think that, once there's an agreement on the timeline of implementing MODIFY_FIELD in PMDs, we'd need to work > with OVS to migrate it to MODIFY_FIELD. After OVS uses MODIFY_FIELD actions, deprecated actions could be safely removed from OVS and DPDK. > Ideally, there would be some overlap where both methods are present and fully supported for a couple of releases. That would ease integration for users, rather than having an abrupt switchover date. OVS only takes DPDK LTS versions, so it could only take the next YY.11 release with this change. Any OVS patches to switchover would need to be ready/reviewed in OVS before the DPDK YY.11 release integration, otherwise it could delay updating DPDK version and missing other new functionality/new drivers etc. There is an OVS 'dpdk-latest' experimental branch that is paired with head of DPDK main branch. You can send OVS patches to it for new DPDK changes to refine and test with, in advance of a DPDK YY.11 release. > What do you all think? > > Also, this opens a question about other upstream projects using deprecated actions. Do you know if there are other projects besides OVS? > A quick search through some projects and I didn't see them used elsewhere. thanks, Kevin. > Best regards, > Dariusz Sosnowski >