From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8E731A0503; Fri, 20 May 2022 13:00:36 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6E77A427ED; Fri, 20 May 2022 13:00:36 +0200 (CEST) Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by mails.dpdk.org (Postfix) with ESMTP id DE39B40222 for ; Fri, 20 May 2022 13:00:34 +0200 (CEST) Received: from kwepemi500012.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4L4Nyz5TJLzjWxM; Fri, 20 May 2022 18:59:39 +0800 (CST) Received: from [10.67.103.128] (10.67.103.128) by kwepemi500012.china.huawei.com (7.221.188.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Fri, 20 May 2022 19:00:31 +0800 Subject: Re: [PATCH 05/12] net/hns3: fix an unreasonable memset To: Ferruh Yigit , Andrew Rybchenko , CC: References: <20220519122917.2334-1-humin29@huawei.com> <20220519122917.2334-6-humin29@huawei.com> <1c148094-3550-b78e-7c23-1819582a83ff@oktetlabs.ru> <19acdf78-af14-25fa-a52b-8b1f96d3fcb3@huawei.com> <02c76cd2-da56-7619-d52a-fa997bc81106@oktetlabs.ru> <3024730f-ca6a-e82e-2c7d-80c41d4fd6ad@huawei.com> From: "Min Hu (Connor)" Message-ID: <3b31ec33-3992-7ce4-ac32-30fa96ca0d7a@huawei.com> Date: Fri, 20 May 2022 19:00:31 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.103.128] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To kwepemi500012.china.huawei.com (7.221.188.12) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, 在 2022/5/20 18:43, Ferruh Yigit 写道: > On 5/20/2022 10:14 AM, Min Hu (Connor) wrote: >> [CAUTION: External Email] >> >> Hi,Andrew, >> >> 在 2022/5/20 16:59, Andrew Rybchenko 写道: >>> On 5/20/22 11:37, Min Hu (Connor) wrote: >>>> Hi, Andrew , >>>> >>>> 在 2022/5/20 15:58, Andrew Rybchenko 写道: >>>>> On 5/19/22 15:29, Min Hu (Connor) wrote: >>>>>> From: Huisong Li >>>>>> >>>>>> This patch fixes an unreasonable memset. >>>>>> >>>>>> Fixes: bba636698316 ("net/hns3: support Rx/Tx and related >>>>>> operations") >>>>>> Cc: stable@dpdk.org >>>>>> >>>>>> Signed-off-by: Huisong Li >>>>>> Signed-off-by: Min Hu (Connor) >>>>>> --- >>>>>>   drivers/net/hns3/hns3_rxtx.c | 2 +- >>>>>>   1 file changed, 1 insertion(+), 1 deletion(-) >>>>>> >>>>>> diff --git a/drivers/net/hns3/hns3_rxtx.c >>>>>> b/drivers/net/hns3/hns3_rxtx.c >>>>>> index 510802be05..5a2cfe5a54 100644 >>>>>> --- a/drivers/net/hns3/hns3_rxtx.c >>>>>> +++ b/drivers/net/hns3/hns3_rxtx.c >>>>>> @@ -776,7 +776,7 @@ hns3vf_reset_all_tqps(struct hns3_hw *hw) >>>>>>       int ret; >>>>>>       uint16_t i; >>>>>> -    memset(msg_data, 0, sizeof(uint16_t)); >>>>>> +    memset(msg_data, 0, sizeof(msg_data)); >>>>> >>>>> It looks a bit suspicious. May be it is better to do: >>>>>      memset(&msg_data, 0, sizeof(msg_data)); >>>> I think this is too hard to understand for &msg_data is **p. >>>> maybe it confuse others when use memset to operate level-2 pointer. >>> >>> msg_data == &amsg_data >>> since it is an array >> Yes, you are right, the address of 'msg_data ' is the same >> as the address of '&amsg_data'. >> >> But I still think this usage is not common. >> like the current code in DPDK: >> ***** >> static int >> app_parse_flow_conf(const char *conf_str) >> { >>         int ret; >>         uint32_t vals[5]; >>         struct flow_conf *pconf; >>         uint64_t mask; >> >>         memset(vals, 0, sizeof(vals)); >> ... >> ***** >> >> how about others's opinion? @Ferruh, @Thomas. >> > > I would use array without address operator, so original patch lgtm. thanks Ferruh. > > +1 to main purpose of the patch (to replace 'sizeof(uint16_t)'). > .