From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 9E78E3772 for ; Tue, 16 Jan 2018 09:54:20 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CC36D12E50B; Tue, 16 Jan 2018 08:54:19 +0000 (UTC) Received: from [10.36.112.47] (ovpn-112-47.ams2.redhat.com [10.36.112.47]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 90136600D2; Tue, 16 Jan 2018 08:54:18 +0000 (UTC) To: Junjie Chen , yliu@fridaylinux.org Cc: dev@dpdk.org References: <1516015939-11266-1-git-send-email-junjie.j.chen@intel.com> From: Maxime Coquelin Message-ID: <3b349d35-cd2a-6b65-f07d-08f15d77d4b3@redhat.com> Date: Tue, 16 Jan 2018 09:54:16 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <1516015939-11266-1-git-send-email-junjie.j.chen@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Tue, 16 Jan 2018 08:54:19 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH] vhost: do deep copy while reallocate vq X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Jan 2018 08:54:20 -0000 On 01/15/2018 12:32 PM, Junjie Chen wrote: > When vhost reallocate dev and vq for NUMA enabled case, it doesn't perform > deep copy, which lead to 1) zmbuf list not valid 2) remote memory access. > This patch is to re-initlize the zmbuf list and also do the deep copy. > > Signed-off-by: Junjie Chen > --- > lib/librte_vhost/vhost_user.c | 31 +++++++++++++++++++++++++++++++ > 1 file changed, 31 insertions(+) > Reviewed-by: Maxime Coquelin Thanks, Maxime