From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9E0F9A00BE; Thu, 28 May 2020 14:41:28 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6E2431DBAE; Thu, 28 May 2020 14:41:28 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id EC9ED1BFC8 for ; Thu, 28 May 2020 14:41:26 +0200 (CEST) IronPort-SDR: 3qMNxh3oXfAi7BynruiciPZuh+Blh2CXNS3I3F6ltFWKVttinY9SieQr+UsEJj7Rc+d1u6VMrE 34r43558i/UQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 May 2020 05:41:25 -0700 IronPort-SDR: EOV/XfW4Ndf/+eMfd2qHYKPhzvUxK/sfbF2INgCEu+UGt/2Ribvlkt9H7Jv7qOFPcm0KBVdDPU z4IgvA0MUQGQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,444,1583222400"; d="scan'208";a="376356596" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.252.45.206]) ([10.252.45.206]) by fmsmga001.fm.intel.com with ESMTP; 28 May 2020 05:41:25 -0700 From: "Burakov, Anatoly" To: Louise Kilheeney , dev@dpdk.org References: <20200522132320.26373-1-louise.kilheeney@intel.com> <20200522132320.26373-3-louise.kilheeney@intel.com> <7a5b9243-508b-f40f-7fba-1ac72548c7c2@intel.com> Message-ID: <3b3e0cc6-3f83-adb1-3c65-bec943bc6f39@intel.com> Date: Thu, 28 May 2020 13:41:24 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.8.1 MIME-Version: 1.0 In-Reply-To: <7a5b9243-508b-f40f-7fba-1ac72548c7c2@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 20.08 2/9] usertools/dpdk-devbind: support python3 only X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 28-May-20 1:39 PM, Burakov, Anatoly wrote: > On 22-May-20 2:23 PM, Louise Kilheeney wrote: >> Changed script to explicitly use python3 only. >> >> Signed-off-by: Louise Kilheeney >> --- > > There is a bunch of old cruft in a few scripts, such as python > compatibility checks and reimplementation of check_output. it would be > nice if those were fixed as well. > > If you look for imports or the word "python" in code, chance are you'll > find some comments saying something about "let's do this hack for python > 2 compatibility" :) > I would also suggest using /usr/bin/env python3 rather than explicit path to /usr/bin/python3. -- Thanks, Anatoly