From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <arybchenko@solarflare.com>
Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com
 [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 17097201
 for <dev@dpdk.org>; Thu,  8 Nov 2018 07:25:49 +0100 (CET)
X-Virus-Scanned: Proofpoint Essentials engine
Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))
 (No client certificate requested)
 by mx1-us3.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id
 C6BCB98008B; Thu,  8 Nov 2018 06:25:47 +0000 (UTC)
Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com
 (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 8 Nov 2018
 06:25:42 +0000
To: Wenzhuo Lu <wenzhuo.lu@intel.com>, <dev@dpdk.org>
References: <1531373220-42150-1-git-send-email-wenzhuo.lu@intel.com>
 <1541642954-37497-1-git-send-email-wenzhuo.lu@intel.com>
 <1541642954-37497-2-git-send-email-wenzhuo.lu@intel.com>
From: Andrew Rybchenko <arybchenko@solarflare.com>
Message-ID: <3b646bb3-0fd6-efda-6508-93f39d6af5f6@solarflare.com>
Date: Thu, 8 Nov 2018 09:25:38 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.2.1
MIME-Version: 1.0
In-Reply-To: <1541642954-37497-2-git-send-email-wenzhuo.lu@intel.com>
Content-Language: en-GB
X-Originating-IP: [91.220.146.112]
X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To
 ukex01.SolarFlarecom.com (10.17.10.4)
X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24210.003
X-TM-AS-Result: No-7.089800-8.000000-10
X-TMASE-MatchedRID: zGP2F0O7j/sOwH4pD14DsPHkpkyUphL9wx0jRRxcQfOtj24Xqh0yXLqp
 W/iJ1C/pbiC5thfjUOB2U51zmt8pLoqztqrk0ko7gZTbeFUhryF8yGO3dvk8/QJ1vk7thYuGUdf
 EKc10rU4vQVE0yOGFpYqBZeVCt3Cf0nbjHOkZyPk+W6N2SzBTB8qLkmpzwoU0nnVL/j1phjt5RA
 29TjvO6DU3HPhRrRy9/76CM4Z/MGblRxm3A2wKujl/1fD/GopdcmfM3DjaQLHZs3HUcS/scHl6h
 n76fRjuaGDJtB3CARn8DCdjQLpH0+8bG0hySHt2f6IU27naL/RBzVtdFWIr+8xX4CxcFVkDMC2f
 mlBoihpxImdDERYlnDQa0dTfxBktlExlQIQeRG0=
X-TM-AS-User-Approved-Sender: Yes
X-TM-AS-User-Blocked-Sender: No
X-TMASE-Result: 10--7.089800-8.000000
X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24210.003
X-MDID: 1541658348-52qwwXFAb1An
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] [PATCH v3 2/2] ethdev: device configuration
 enhancement
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Nov 2018 06:25:49 -0000

On 11/8/18 5:09 AM, Wenzhuo Lu wrote:
> The new configuration is stored during the process.
> But the process may fail. We better rolling the
> configuration back as the new one doesn't take effect.
>
> Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>

I would say that the order is wrong. We should fix this bug first and
the changeset should have appropriate Fixes tags.
I think this bug is older and should be fixed first.
Then the second bug should be fixed without this one present.