From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <ferruh.yigit@intel.com> Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 168E32BAD for <dev@dpdk.org>; Tue, 20 Dec 2016 14:04:59 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP; 20 Dec 2016 05:04:58 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,378,1477983600"; d="scan'208";a="1074413783" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.29]) ([10.237.220.29]) by orsmga001.jf.intel.com with ESMTP; 20 Dec 2016 05:04:57 -0800 To: Stephen Hemminger <stephen@networkplumber.org>, dev@dpdk.org References: <20161219215944.17226-1-sthemmin@microsoft.com> <20161219215944.17226-5-sthemmin@microsoft.com> Cc: Stephen Hemminger <sthemmin@microsoft.com> From: Ferruh Yigit <ferruh.yigit@intel.com> Message-ID: <3b6ec414-247e-c7a0-2ea3-3298440d011c@intel.com> Date: Tue, 20 Dec 2016 13:04:56 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20161219215944.17226-5-sthemmin@microsoft.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 04/13] eal: introduce driver type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Tue, 20 Dec 2016 13:05:01 -0000 On 12/19/2016 9:59 PM, Stephen Hemminger wrote: > Since multiple buses and device types need to be supported. > Provide type field in driver. > --- > lib/librte_eal/common/include/rte_dev.h | 15 ++++++++++++--- > lib/librte_eal/common/include/rte_pci.h | 1 + > lib/librte_eal/common/include/rte_vdev.h | 1 + > 3 files changed, 14 insertions(+), 3 deletions(-) > > diff --git a/lib/librte_eal/common/include/rte_dev.h b/lib/librte_eal/common/include/rte_dev.h > index e5471a22..3f4e26e6 100644 > --- a/lib/librte_eal/common/include/rte_dev.h > +++ b/lib/librte_eal/common/include/rte_dev.h > @@ -144,12 +144,21 @@ void rte_eal_device_insert(struct rte_device *dev); > void rte_eal_device_remove(struct rte_device *dev); > > /** > + * Type of device driver > + */ > +enum rte_driver_type { > + PMD_VIRTUAL, > + PMD_PCI, > +}; There were types in v16.07 and previous. Types has been removed in v16.11. Now are we sure we want to add them back?