From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 300B2A04B1; Mon, 5 Oct 2020 17:20:21 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 650951B677; Mon, 5 Oct 2020 17:20:19 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id AB07F1B673 for ; Mon, 5 Oct 2020 17:20:17 +0200 (CEST) IronPort-SDR: DheIn7406Pgco2SXFXZcBWfm3Au76LIOr2UekTWtihDSJY0hJn8YyI8XZ7osSqgE8mTBAFWDhD MNxN6h4hHHGw== X-IronPort-AV: E=McAfee;i="6000,8403,9764"; a="143629586" X-IronPort-AV: E=Sophos;i="5.77,338,1596524400"; d="scan'208";a="143629586" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga107.fm.intel.com with ESMTP; 05 Oct 2020 08:15:24 -0700 IronPort-SDR: yDenM8nSWj0mOHSld3uoCRnanlS/vB2iDn1nTCcDTXOp2xsLbany1xnxYnO5S5jSTog0gRrJQg t8abKo0bRhEQ== X-IronPort-AV: E=Sophos;i="5.77,338,1596524400"; d="scan'208";a="526125976" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.225.105]) ([10.213.225.105]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Oct 2020 08:12:14 -0700 To: Hariprasad Govindharajan , dev@dpdk.org References: <1601909255-26251-1-git-send-email-hariprasad.govindharajan@intel.com> From: Ferruh Yigit Message-ID: <3b6f6141-7e6f-c092-81c0-3c1b328b3d8f@intel.com> Date: Mon, 5 Oct 2020 16:12:10 +0100 MIME-Version: 1.0 In-Reply-To: <1601909255-26251-1-git-send-email-hariprasad.govindharajan@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] linux/igb_uio: add Makefile to build the kernel module X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/5/2020 3:47 PM, Hariprasad Govindharajan wrote: > With DPDK 20.11 release, the igb_uio module is no more part of DPDK. > There are use cases where this module is required, for example while > testing the virtual ports in OvS, the virtual ports are bound to > igb_uio module inside a VM. So, this patch provides a Makefile > which can be used to build this module and use as needed. > > Before building this module, the user is expected to build the > DPDK using meson build system and make sure that the required > libraries are installed in the path /usr/local > Can you please highlight in the commit log that this is for the dpdk-kmods repo: https://git.dpdk.org/dpdk-kmods/ > Signed-off-by: Hariprasad Govindharajan > --- > linux/igb_uio/Makefile | 8 ++++++++ > 1 file changed, 8 insertions(+) > create mode 100644 linux/igb_uio/Makefile > > diff --git a/linux/igb_uio/Makefile b/linux/igb_uio/Makefile > new file mode 100644 > index 0000000..be39131 > --- /dev/null > +++ b/linux/igb_uio/Makefile > @@ -0,0 +1,8 @@ > +obj-m += igb_uio.o I think we can drop this from this makefile, it is in Kbuild > +DPDK_INSTALL=/usr/local/include Can we use "?=" assignment to accept user provided value Also since it points the header folder, what do you think about changing the macro name to highlight that it is for headers folder? > + > +all: > + make EXTRA_CFLAGS="-I $(DPDK_INSTALL)" -C /lib/modules/`uname -r`/build/ M=$(PWD) Same for the kernel path, can you make it variable to user can override? > + > +clean: > + make -C /lib/modules/$(shell uname -r)/build M=$(PWD) clean >