From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CFC51A0C4A; Thu, 8 Jul 2021 14:43:56 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9CF8F40696; Thu, 8 Jul 2021 14:43:56 +0200 (CEST) Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by mails.dpdk.org (Postfix) with ESMTP id 23C6B4014F for ; Thu, 8 Jul 2021 14:43:55 +0200 (CEST) Received: from dggeme756-chm.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4GLG9L6cpCzcb9Z; Thu, 8 Jul 2021 20:40:38 +0800 (CST) Received: from [10.67.103.128] (10.67.103.128) by dggeme756-chm.china.huawei.com (10.3.19.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Thu, 8 Jul 2021 20:43:51 +0800 To: Martin Havlik , Chas Williams , Declan Doherty , Tomasz Kulasek CC: , Jan Viktorin References: <20210622092531.73112-1-xhavli56@stud.fit.vutbr.cz> <20210622092531.73112-3-xhavli56@stud.fit.vutbr.cz> From: "Min Hu (Connor)" Message-ID: <3b731983-2bc2-746e-4303-6654b2de1193@huawei.com> Date: Thu, 8 Jul 2021 20:43:51 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: <20210622092531.73112-3-xhavli56@stud.fit.vutbr.cz> Content-Type: text/plain; charset="gbk"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.103.128] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggeme756-chm.china.huawei.com (10.3.19.102) X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH 2/3] net/bonding: fix not checked return value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" ÔÚ 2021/6/22 17:25, Martin Havlik дµÀ: > Return value from bond_ethdev_8023ad_flow_set() is now checked > and appropriate message is logged on error. > > Fixes: 112891cd27e5 ("net/bonding: add dedicated HW queues for LACP control") > Cc: tomaszx.kulasek@intel.com > > Signed-off-by: Martin Havlik > Cc: Jan Viktorin > --- > drivers/net/bonding/rte_eth_bond_pmd.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c > index 4c43bf916..a6755661c 100644 > --- a/drivers/net/bonding/rte_eth_bond_pmd.c > +++ b/drivers/net/bonding/rte_eth_bond_pmd.c > @@ -1819,8 +1819,14 @@ slave_configure(struct rte_eth_dev *bonded_eth_dev, > internals->mode4.dedicated_queues.flow[slave_eth_dev->data->port_id], > &flow_error); > > - bond_ethdev_8023ad_flow_set(bonded_eth_dev, > + errval = bond_ethdev_8023ad_flow_set(bonded_eth_dev, > slave_eth_dev->data->port_id); > + if (errval != 0) { > + RTE_BOND_LOG(ERR, > + "bond_ethdev_8023ad_flow_set: port=%d, err (%d)", > + slave_eth_dev->data->port_id, errval); > + return errval; > + } > } > Firstly, I think your patch is OK, But I want to know what is your standard to decide which function should check return value or not(of course, they are none-void)? While, I noticed "bond_ethdev_lsc_event_callback" nearby was not checked, but you ignored it. > /* Start device */ >