From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <shreyansh.jain@nxp.com>
Received: from NAM01-BY2-obe.outbound.protection.outlook.com
(mail-by2nam01on0086.outbound.protection.outlook.com [104.47.34.86])
by dpdk.org (Postfix) with ESMTP id 7D45BDE0
for <dev@dpdk.org>; Fri, 31 Mar 2017 07:35:30 +0200 (CEST)
Received: from BY2PR03CA053.namprd03.prod.outlook.com (10.141.249.26) by
BL2PR03MB273.namprd03.prod.outlook.com (10.255.231.11) with Microsoft SMTP
Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id
15.1.1005.10; Fri, 31 Mar 2017 05:35:29 +0000
Received: from BY2FFO11FD004.protection.gbl (2a01:111:f400:7c0c::105) by
BY2PR03CA053.outlook.office365.com (2a01:111:e400:2c5d::26) with Microsoft
SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1005.10 via
Frontend Transport; Fri, 31 Mar 2017 05:35:28 +0000
Authentication-Results: spf=fail (sender IP is 192.88.168.50)
smtp.mailfrom=nxp.com; 6wind.com; dkim=none (message not signed)
header.d=none;6wind.com; dmarc=fail action=none header.from=nxp.com;
Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not
designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com;
client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net;
Received: from tx30smr01.am.freescale.net (192.88.168.50) by
BY2FFO11FD004.mail.protection.outlook.com (10.1.14.158) with Microsoft SMTP
Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1005.5
via Frontend Transport; Fri, 31 Mar 2017 05:35:25 +0000
Received: from [10.232.14.39] ([10.232.14.39])
by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id v2V5ZMHE027858;
Thu, 30 Mar 2017 22:35:23 -0700
To: <olivier.matz@6wind.com>
References: <11490938158-936-1-git-send-email-shreyansh.jain@nxp.com>
<1490938537-1177-1-git-send-email-shreyansh.jain@nxp.com>
CC: <dev@dpdk.org>, <thomas.monjalon@6wind.com>, <hemant.agrawal@nxp.com>,
<david.hunt@intel.com>
From: Shreyansh Jain <shreyansh.jain@nxp.com>
Message-ID: <3b7b65f5-aa8b-fa4a-de8e-8458ec78ce87@nxp.com>
Date: Fri, 31 Mar 2017 11:11:19 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <1490938537-1177-1-git-send-email-shreyansh.jain@nxp.com>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
X-EOPAttributedMessage: 0
X-Matching-Connectors: 131354121278274694;
(91ab9b29-cfa4-454e-5278-08d120cd25b8); ()
X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI;
SFV:NSPM;
SFS:(10009020)(6009001)(336005)(39410400002)(39400400002)(39850400002)(39380400002)(39450400003)(39840400002)(39860400002)(2980300002)(1110001)(1109001)(339900001)(24454002)(199003)(377454003)(189002)(9170700003)(31696002)(8936002)(81166006)(105606002)(104016004)(31686004)(54356999)(2906002)(76176999)(6666003)(8676002)(33646002)(36756003)(50986999)(230700001)(6246003)(2950100002)(53936002)(38730400002)(106466001)(2351001)(110136004)(6916009)(54906002)(8656002)(5660300001)(77096006)(4326008)(65826007)(229853002)(47776003)(23746002)(65956001)(65806001)(356003)(85426001)(305945005)(189998001)(50466002)(86362001)(4001350100001)(83506001)(64126003);
DIR:OUT; SFP:1101; SCL:1; SRVR:BL2PR03MB273; H:tx30smr01.am.freescale.net;
FPR:; SPF:Fail; MLV:ovrnspm; A:1; MX:1; PTR:InfoDomainNonexistent; LANG:en;
X-Microsoft-Exchange-Diagnostics: 1; BY2FFO11FD004;
1:j5opvGkA88qP+eFfaAXyb3BLTssS1wLStki1wAU0P3ShyN32wfF06ogdyybxgjwRHIa38raMG/AD2x8XSYQDUfCQxTYFrMRiVOEQ8ADxYrdVM5VZQHzZ0PhST9e3Q0gLZ4GBH4VPUZOZBmldiviNmzbwlwzu2oVHERUeJHYYfLfkgXIU1ZonL22JU8yzWtr+UZ/ZgdDeh3ElUYFS3qWNXe95ymZDgJ03UKYXkOcvOaCvPFAd4N0ANzb6JPMGlvnnFGcvbWhUiU8EqCxXi/8QRAX8diQv1FLTK1no8NfnJBBjK8oDy19QAa2WW6UUBvXyEsNUvL4J0F1Zd8CPqqZBBk3GdS05971MxnLRxjYA6ThsNWuzAc8ja8rju8vIRbUIOxQiza3/d4Kn9n3hhhbWUqdYTtZwRN/r/xuy0XDBX4DhR9FE8ofmArRXNJihL2HQrvSOUEPLIQFd+IKBu8dKaEvqzExiH05v7qj4qmiMX1r4prQDn66aDOuxyMToTyailkjz7XHVgZM/HPPR9l01A7VRH8S/O4Ivq3L0GgpUMhHHJfn4DMBWyoyXwsTc9i2QMfOrpr3T6T8Z7msK1J11ILWnGsCCyLIJLC2WdFa7plLrjQUZPQ8HV4a33eirNLo4
X-MS-Office365-Filtering-Correlation-Id: d4f53356-f9af-40f6-3c86-08d477f7bd0a
X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0;
RULEID:(22001)(2017030255075)(201703131430075)(201703131517081);
SRVR:BL2PR03MB273;
X-Microsoft-Exchange-Diagnostics: 1; BL2PR03MB273;
3:Agio7q+dH/mlzsZhuuS9jMClRy3McpftOR6WqU7xUbYqKt5aWwIx7tIML1m8XeqYgJJJ/FQ49WRtimEMn6f/pXcGtvscNR4XHgiQPKxUmhycWXfy3a9dviBQdaYKIwJ2f9wX00MOm6DlC04xLnTCKe5Os0bTXY154jZ5W/e+Iqmg3N+JWO+zbVyjZ3jd3TeOgbmFWt5s3Nq9Rq3/fdMtBibtYv/nB1nqHhEmQrRAylpZ0qBegLJl+CYbqyqj56OT7yUdVcB6kQ2KEgBUqd4wWRxP6IX/boZDc42mmJGi5Rtqx/Fx4v7FUkNoJWYtn6Y+bQ/o+/gI+rXMD1lnmG5hm4gRyCaRFLv0QuccXHixctbkPQ0/TqYjmX8pu1VT7EUtx/WsdNJtk/Trq6wj9Bp6x86VYC7DZSSJDtcb3toQHPvEg8N0D4frMoZWv/ezXz2FJSdwXOEoPd5bbgnEmIS7Dg==;
25:/VMcOweFKZTm3SAf5O0IlIYi5FiKfFI3SsJhKPRVb1aiE1c+Jr6wQuYQprvOf1jBQvY6XOHFyR9qH7jPNDGuXryggk3dvlbfdDnZvKYQHGNa0MyBJPN6h+y71IUQN88NQhGF3S0bfmh20bLXtgrxMT01L5LIEgHjtGBOdbEApQ5vaUpVD2V5kSxbAaPcPMkDH2p1XM0rLuT0nR2ZdTaxMzhCfuqIAooZAlcNnbTUn3ciPQk+wRwvkxljsuRd3sxyaOMomPwOs3m5Uhtc1duI+VHJc6JAS/7GeOaPny4U3XEeTCeg1HM83F0zB9/M2TlOZjEjzI+cRs+JaD2OcM9EVxZ5YmEZUw3hEPNgxeJ1WZnNjUQ1mhQeDOF8BtDHeb1cOVt9zZDu3th20+c9i3qIH2jtAQC9TWLhUt4lPraCIhY4WXQk+2remhBWu4TON43IaWE2jOoMCTnmM6C6EiTNiw==
X-Microsoft-Exchange-Diagnostics: 1; BL2PR03MB273;
31:CvEySs3I4lAl3UtvL8UwHyPG03BErMZMh71CgFGIjBqh3mi4WCZ6POnU5mMpKZ9bpNQeWwtYxd7GlqYa3Gj/iP5KNbFS6iuh9xVdolJl70LDjBziAStzfzM5NKUbEcxm1Rwoxxl52Nd8US1X0uQt3U5PPfgK6xKJpudHS5JoK5AbX32wqLeuiAbBIe9D6Ez4DVGlVxolmnrRJ+vr7qUDZb7VQSaPQSTvzJSQqvKCXM4jrMm0izZsgf7wuiJBh9daN5knZOUWHZcP7wRIDLK1q1W16p0lwHnmlx8PmRJOq6o=
X-Microsoft-Antispam-PRVS: <BL2PR03MB2739BC239F48375FE47184D90370@BL2PR03MB273.namprd03.prod.outlook.com>
X-Exchange-Antispam-Report-Test: UriScan:(185117386973197);
X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0;
RULEID:(6095135)(601004)(2401047)(13023025)(13017025)(13015025)(5005006)(8121501046)(13024025)(13018025)(10201501046)(93006089)(93001089)(3002001)(6055026)(6096035)(20161123556025)(20161123561025)(20161123565025)(201703131430075)(201703131448075)(201703131433075)(201703161259075)(20161123563025);
SRVR:BL2PR03MB273; BCL:0; PCL:0; RULEID:(400006); SRVR:BL2PR03MB273;
X-Microsoft-Exchange-Diagnostics: 1; BL2PR03MB273;
4:hSgK1iNUBXUH98M666yHimCcJyTwqvH7+mYvIQ2NVhQEMmUde6HQ/trGfnZI9TuLbTVuezEEkHCK77PBJuAtLEVkwFmVsUDdIh/vodELHk5VJWPxQjNdJWuWxllz7tqRg8G5ziJGQFIjJINZ5i+OuE3SYeKMArYZZS4gBAn0H3PC1WKoBQjuv9CHuKcJZtNbRXSnit1a5iBIL50oGuCOn48AFgx4FsJsD4988Q9FuJ7dqidI7PN192nLWw16ewDYkYvYa6egqROIvdO/M4wMT3OHmKEW4muuIfzv4ywFXFArW4Sm+aCcqlfeCc/m+7XtzoNejcZ/mq+PwGfiLjKKnyiSc7xk+ZaTW9DoLRzJEgLUxfgdu0F40zjGaa/dBziYy6Wi3OGgQj68VPvYBxm7xEYQTsZlJ31PhLnNmI5Hrz+6xha+xa13tcpueDnAxY9luihH8E88yzZIpAh9G9XBrlUBquNmSICyAksvLf5VwyPMzqVUT7xzY6aJC9q44nWvGpR031O4UTL6IS+uPC5tdl7yfyrvlq6/9vq9+Gv+qaTygJ1AIHgUJVBC3RaXSPIEs14Ra1tLMSf5Bqs7gasC/MYVCDEK6IPmbplLf4MwNzk6fTuijiqZY4Jue6XzJGOwfGRoT+PYlSuXTKPq5cttzqekmy2wGz2MCiAtc7zTDHTZ8YF3qrXx7mfqgnPLD2un4p50zkonHQet/9hIxPua8K45qke9jqojLiP0gwUPZO4BIFYw8E2mggWphVnZ6Vt4LOAGxEplM+WwHJEhCEGUwAYzq1Q7BubcIZsN355NGj4hIILNon25ip8awMQa2TYgAdpbQ8OVM6+R5sx3ho95oj6mwb4GDxh7Qy9MNuxG03e3rcya9Qx30uyl2IQW9ij55aR2LZQ2pybczWYDZrUZrg==
X-Forefront-PRVS: 02638D901B
X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; BL2PR03MB273;
23:JI83apDS6UWOOIl+qJVRq82fmJfQc0ArcyUDAB?=
=?Windows-1252?Q?VHowizz0ddMpu7/aEU9hd6k89GlXvJIvRxUdSNN8Aj9D7H5scP0zjUvd?=
=?Windows-1252?Q?LjSvnInybbmC7S1AYvmS7UP4dKfwneoLZxUInYgsSIMRiggFU1mzHCnN?=
=?Windows-1252?Q?R3302MaPzJbWAm9z4npkRpwsivbj+vzk/eF8zfWix4aTdFCEsIrtf2Ff?=
=?Windows-1252?Q?CF758GhjUnpkPBQJQmqEXsNSmF+fDbyb2Hkcy2wiNe+uXBkRbYg0Ybvx?=
=?Windows-1252?Q?TTflVLcR+kZuwevsqeNeT8nrkMDuZ4fbFi5cbHjDkcitzyc3VD0BTRKS?=
=?Windows-1252?Q?l9mtajq0ep7tIPu/vOadCS7Sgsy+VjzilQFdabAkqoVBa6Zq0LdG8eEA?=
=?Windows-1252?Q?viz+qB0u+zs/cervMwIQF8s+0eJ9vlpr0fcg7V1CCPvV8ohuIy2/x3yH?=
=?Windows-1252?Q?uLC1N254CnLyNRGNV1fw2zA3cSBwNr8b3PDMF9UfrS+63pPFSItdpvku?=
=?Windows-1252?Q?+l2DQOA8oYoxEqQ+f/5vzuUJIB0opHIbmGUq1VtKLRQBLtzIjW1GqYmh?=
=?Windows-1252?Q?+CkYRthrLayC8yVvydjltYlxdmqaXSkad+BdLecXqZMp8P4qThWHxpBA?=
=?Windows-1252?Q?HxIjPpD8ahBxotJkXVfVfJlNmotXg8niMU0Lxigl3tmz0ywudjsqo7Xk?=
=?Windows-1252?Q?AbrUaKlxVtUvo2vKROBAt6FfhhZLsEfv7BE/3Nt3r+3nUfzaqcFh08vj?=
=?Windows-1252?Q?++baRbQTfPrbQX7u5lKPCv6FH/QslOQcYiUZZa5Wys1rV4d/jxQVrg8E?=
=?Windows-1252?Q?WDtfx+piD4Na77QR698gLI6S3AP6Cq8CT+MSnCDYQUgvBoXZO93d79En?=
=?Windows-1252?Q?eBN7p43hkB6Z921Z/RQ0QN9mrhoBCCBzNSBaKOAdiJ6vnkznrYjvSLj/?=
=?Windows-1252?Q?ujYc7IESpdH6s4w0NEG+WlFQSwlI74da3dLyhG4qpqnJaCFFvbb24OBi?=
=?Windows-1252?Q?lTJP0sfySDhW9KoKL76HlnT0QtCN7Vbquy+YvTL+AljlZ/0mrJnWvGtl?=
=?Windows-1252?Q?vAgYQDFTIUbsC2PsNO/SMTkCd9Px/YZY/5qqkFo+Gz58HKbi0crTcnjH?=
=?Windows-1252?Q?aZX1c6o8Ja6l3AgG970txa/o1W5aODuORWoMg+YVNxZG+zUffKspmfVi?=
=?Windows-1252?Q?o3fS6qjHM7SbZwRQUJ1uA28jDCd/9SRUce8igcIK+v2xlWgmCwbhfgYR?=
=?Windows-1252?Q?8ZKysdVu7ES5ISBtGRNztvN9H09hjZ8fnAZ4stGIldI59eFtaUZ2rJMR?=
=?Windows-1252?Q?TWEAvFhZz9cueQROvkvGAAMTqM83Hd+pgelWIEBE6dfT3KhOLrdzmYQG?=
=?Windows-1252?Q?Fs4a4IAEcyrr70WhYXiAXha6r9JTZxpEcLQMb3d2fS7Yz9jh8WaLKAoc?=
=?Windows-1252?Q?70UuYEObHhGUdfTeUpfAh341exyy8c8X7lAx64Stq3yPSaH9JCBJJlJZ?=
=?Windows-1252?Q?mahS5cGL8IOauctxlvXVj2BqYE3dL6URLU2nmtrtq93mSk8bydeiNNMt?=
=?Windows-1252?Q?UKXNrNIDVyVl8o6bAj0hhCSoJC7VfzlhWnu4C7eP61/RXPMXFtjV6/ow?=
=?Windows-1252?Q?=3D=3D?=
X-Microsoft-Exchange-Diagnostics: 1; BL2PR03MB273;
6:ACkup5sPPoen+HNR3AuE4fWXyYOJg9rJdl8GjX6KBUKFkkQVmbojE1BgyPswIP/dN1XsczbcKLe9NIZlqQbRdYRBsi+PaCIfgKzLand4N2NVqGWA3ThoVDELLfVzAwkhayzAfkJyELjuGRtxqcxchTLiTDt/Qo4yqxLC0hppu1wsXxqPF3TD49r2S/aeKqItMw6dRPZ97nguFbLQDClksMBV9aRdgFzEoaXFHTPGm2UiZtPlTQTnssVVLxXTR8bnqiVXRQrv1OOov74CVeo3wwiF3eIiupPKiF2dx6bs5QfneemKmTx/lWjZMX3MYXG7ZonqiCMqYumxzhegBwl+jGhVdg1NAa09NIIkS2/BawX9pIgnVodiR4pzkFyLaIYJnDYmmgroSEaQqPNwO4qhOQ==;
5:9rAX7ggHMnAyBU7+ZOGqeFmzbPaNaab6rsPrCU5szrS5pzkG983RZd0ih2X1uJKLRWNiAflkPVpHctahaAqto/gSuw0kJaGmMH6MhK8Z6eMDh5kbi/w1jJD4nn94hzfKp5qhwYYzVKH2u7uWoIRuMm4q/IiBbE3hPeXc1ncdGHQWO+Mp2UD4rAnnTwvVzAve;
24:jhLog1wFReI5rUMCzADHc0kzyppPD2BJp+ralDaqt1VLx7Ry6LMvjECaxdC0QdadILyC3QBXSxqNHrEP0vsFrAD/Ckx9zxHyArHPaCzvoS4=
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-Microsoft-Exchange-Diagnostics: 1; BL2PR03MB273;
7:QBhxibtTt9RUEiwTBMvYwMCi0l+icWMoBWuWdt6I2pefM+HeGN9Q3oEaf4rFCfaXluErNuEIA0IH1H/AFk3rihPi9C86Ttd6u8MgRZ0NKTvt6pTa1MepbpaXgbsXwctVsT03JZE9OQ4BLaJklycvpOuSQSX+mmdsUSin70ibgCrF12gEyx2m2OJyxowDtgXwTIN4UqPz7aB+efIfbeWPR4dfMvMcbKAsHigVEJlSi48IcUW+oM4kHQOj9wmC/Vop+Bz1XuvAqn2l+w3xe/FCIN3yvBsN32Dbea7gHes5Pou6FbVXt35QvUGG+Sk/maUM+PJs3VXik669li/Mu+Feqw==
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Mar 2017 05:35:25.8930 (UTC)
X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50];
Helo=[tx30smr01.am.freescale.net]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL2PR03MB273
Subject: Re: [dpdk-dev] [PATCH v3 1/3] mempool: fix segfault when shared
mempool handler not linked
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 31 Mar 2017 05:35:31 -0000
On Friday 31 March 2017 11:05 AM, Shreyansh Jain wrote:
> Fixes: 449c49b93a6b ("mempool: support handler operations")
>
> In case the stack or ring mempool handler are compiled as shared
> library and not linked in with test binary, segfault is reported.
> This is because return value of rte_mempool_set_ops_byname is not
> being checked in rte_mempool_ops_alloc.
>
> This patch handles error returned from rte_mempool_set_ops_byname
> when a mempool is not found.
>
> Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
> ---
$ devtools/check-git-log.sh <this patch>
Is it candidate for Cc: stable@dpdk.org backport?
mempool: fix segfault when shared mempool handler not linked
I am not sure this needs to be in stable. Previous versions never had
an external mempool handler and ring/stack are statically linked in
always.
Though, if a new handler is added (out of tree) over 16.11, and somehow
and application requests for it without linking the library, this
segfault would occur.
Any suggestions?
And just to add to this patch, this segfault is in 'test' binary. It may
not necessarily be the case for other application if they are
handling the error well.